Clear final Bazel Clippy diagnostics

[shiny-code-bot]

Finish Line

The app-server and exec diagnostics discovered by the exact 899-target Bazel Clippy proof are resolved without lint suppression, and the gate advances cleanly into the separately tracked TUI reachability cluster.

Current Status

Implementation is committed at a74de093ee on code/issue-684-app-server-bazel-clippy; PR #686 is open, labeled code-reviewed, and being monitored through merge.

• Removed the superseded app-server cloud-config-loader clear method.
• Replaced the eight-position ConfigManager::new call with crate-private named ConfigManagerArgs, including explicit correction of a harmless reversed test-only home-path callsite.
• Removed the unused codex-exec test-only ANSI constructor superseded by identity-aware construction.
• just test -p codex-app-server compiled and ran 1,200 tests: 1,177 passed and 23 retained the existing unrelated integration baseline.
• just test -p codex-exec compiled and ran 150 tests: 147 passed and three retained the existing unrelated resume/state-store baseline.
• just fmt and git diff --check are clean.
• Exact Bazel Clippy analyzes all 899 targets and clears app-server and exec. The next failures are the separate TUI reachability cluster in Restore TUI reachability for exact Bazel Clippy #685.
• Final Gemini review reported no findings. Opus found no code defect and requested explicit disclosure of the corrected test-only home-path mapping. JetBrains returned only pre-existing spelling findings on unchanged lines and no semantic execution proof; no worktree mutation occurred.

Next action: monitor PR #686 through merge, then continue #685 from the merged main commit.

Acceptance Criteria

• Remove the unused codex-exec test-only ANSI constructor; do not suppress dead_code.
• Remove the unused app-server cloud-config-loader clearing path; do not suppress dead_code for production code.
• Make ConfigManager construction self-documenting with named arguments; do not add a blanket Clippy allowance.
• Preserve cloud config, managed requirements, thread config loader, product identity, and human-output behavior.
• App-server and exec compile under their focused test suites; unrelated baseline failures are recorded separately.
• Exact 899-target Bazel Clippy advances past both app-server and exec with no diagnostics from the changed files.
• Final Opus and Gemini reviews report no actionable findings.

Relationships

• Final validation cleanup under Restore release Clippy runtime wiring #645.
• Restore release Clippy runtime wiring #645 continues to block Publish and prove Codex Lab lab.5 #624 until this issue closes and the exact Bazel proof is recorded.
• related: Restore TUI reachability for exact Bazel Clippy #685 - Restore TUI reachability for exact Bazel Clippy #685

Open Questions

• None. Prefer the smallest constructor-input grouping consistent with existing app-server ownership boundaries.