Minor fixes#608
Open
odadacharles wants to merge 2 commits into
Open
Conversation
Signed-off-by: Charles Odada <charles.odada@canonical.com>
Signed-off-by: Charles Odada <charles.odada@canonical.com>
odadacharles
requested review from
SecondSkoll,
akcano,
dwilding,
medubelko,
rkratky and
tang-mm
as code owners
Contributor
Author
|
This doesn't seem to affect the running of the |
medubelko
approved these changes
Jun 8, 2026
| SPHINX_HOST ?= 127.0.0.1 | ||
| SPHINX_PORT ?= 8000 | ||
| SPHINX_AUTOBUILD_OPTS ?= -D=llms_txt_enabled=0 | ||
| SPHINX_AUTOBUILD_OPTS ?= -D llms_txt_enabled=0 |
Collaborator
There was a problem hiding this comment.
I support this change because it's one less noise character.
As far as I can tell, though, -D= is technically fine. -D/--define can only assign one value, so users won't run into argument parsing issues if they leave it in. If it supported variadic parameters, then the technical case would be stronger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdwith relevant non-documentation file changes?According to the sphinx-llm docs, the second
=inSPHINX_AUTOBUILD_OPTS ?= -D=llms_txt_enabled=0is supposed to be a space.Ref: https://pypi.org/project/sphinx-llm/