Make Tunables::inlining_sum_size_threshold a hard limit (#11458)

* Make `Tunables::inlining_sum_size_threshold` a hard limit

This prevents infinitely inlining small recursive functions whose size is less
than `Tunables::small_callee_size`.

* Add test case

Author: fitzgen

crates/wasmtime/src/compile.rs

@@ -853,6 +853,18 @@ the use case.
             "we never inline recursion"
         );
 
+        // Put a limit on how large we can make a function via inlining to cap
+        // code bloat.
+        let sum_size = caller_size.saturating_add(callee_size);
+        if sum_size > tunables.inlining_sum_size_threshold {
+            log::trace!(
+                "  --> not inlining: the sum of the caller's and callee's sizes is greater than \
+                 the inlining-sum-size threshold: {callee_size} + {caller_size} > {}",
+                tunables.inlining_sum_size_threshold
+            );
+            return false;
+        }
+
         // Consider whether this is an intra-module call.
         //
         // Inlining within a single core module has most often already been done
@@ -890,18 +902,6 @@ the use case.
             return true;
         }
 
-        // It is often not worth inlining if the sum of the caller and callee
-        // sizes is too large.
-        let sum_size = caller_size.saturating_add(callee_size);
-        if sum_size > tunables.inlining_sum_size_threshold {
-            log::trace!(
-                "  --> not inlining: the sum of the caller's and callee's sizes is greater than \
-                 the inlining-sum-size threshold: {callee_size} + {caller_size} > {}",
-                tunables.inlining_sum_size_threshold
-            );
-            return false;
-        }
-
         log::trace!("  --> inlining: did not find a reason we should not");
         true
     }