feat: add typed memory accessors to Wasmtime::Memory#601
Open
takahashim wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, to retrieve an integer value from linear memory, we need to write something like
memory.read(out_p, 4).unpack1("l<").This approach is verbose, difficult to understand, and prone to errors.
Therefore, we want to enable writing
memory.read_i32(out_p)instead.Changes
Introduce paired read/write methods for the WebAssembly numeric types (little-endian):
#read_i32/#write_i32#read_u32/#write_u32#read_i64/#write_i64#read_u64/#write_u64#read_f32/#write_f32#read_f64/#write_f64Out-of-bounds access raises
Wasmtime::Error, consistent with#read/#write.