Skip to content

Commit 566b6a0

Browse files
committed
Update shared.bash
1 parent a888f06 commit 566b6a0

1 file changed

Lines changed: 12 additions & 7 deletions

File tree

lib/shared.bash

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -300,10 +300,15 @@ function run_docker_compose() {
300300
export TRACEPARENT="$BUILDKITE_TRACING_TRACEPARENT"
301301
fi
302302

303-
# Set OTEL_SERVICE_NAME to match the agent's service name so docker-compose
303+
# Set OTEL service name to match the agent's service name so docker-compose
304304
# spans appear under buildkite-agent service instead of separate "compose" service
305-
if [[ -z "${OTEL_SERVICE_NAME:-}" ]] && [[ -n "${BUILDKITE_TRACING_SERVICE_NAME:-}" ]]; then
306-
export OTEL_SERVICE_NAME="$BUILDKITE_TRACING_SERVICE_NAME"
305+
# Use OTEL_RESOURCE_ATTRIBUTES which is the standard way to set service name
306+
if [[ -n "${BUILDKITE_TRACING_SERVICE_NAME:-}" ]]; then
307+
if [[ -z "${OTEL_RESOURCE_ATTRIBUTES:-}" ]]; then
308+
export OTEL_RESOURCE_ATTRIBUTES="service.name=${BUILDKITE_TRACING_SERVICE_NAME}"
309+
elif [[ ! "${OTEL_RESOURCE_ATTRIBUTES}" =~ service\.name ]]; then
310+
export OTEL_RESOURCE_ATTRIBUTES="${OTEL_RESOURCE_ATTRIBUTES},service.name=${BUILDKITE_TRACING_SERVICE_NAME}"
311+
fi
307312
fi
308313

309314
if [[ "$disable_otel_config" == "true" ]]; then
@@ -324,13 +329,13 @@ function run_docker_compose() {
324329
plugin_prompt_and_run "${command[@]}" "$@"
325330
)
326331
else
327-
# Enable docker-compose OTEL tracing (requires explicit flag)
328-
echo "DEBUG: Enabling docker-compose OTEL tracing"
332+
# Docker Compose will auto-detect OTEL configuration from environment variables
333+
# Don't explicitly set COMPOSE_EXPERIMENTAL_OTEL=1 as it might conflict
334+
echo "DEBUG: Docker Compose OTEL auto-detection enabled via environment variables"
329335
echo "DEBUG: TRACEPARENT=${TRACEPARENT:-NOT SET}"
330336
echo "DEBUG: OTEL_SERVICE_NAME=${OTEL_SERVICE_NAME:-NOT SET}"
337+
echo "DEBUG: OTEL_RESOURCE_ATTRIBUTES=${OTEL_RESOURCE_ATTRIBUTES:-NOT SET}"
331338
echo "DEBUG: OTEL_EXPORTER_OTLP_ENDPOINT=${OTEL_EXPORTER_OTLP_ENDPOINT:-NOT SET}"
332-
echo "DEBUG: COMPOSE_EXPERIMENTAL_OTEL will be set to 1"
333-
export COMPOSE_EXPERIMENTAL_OTEL=1
334339
plugin_prompt_and_run "${command[@]}" "$@"
335340
fi
336341
}

0 commit comments

Comments
 (0)