Skip to content

Commit 1adacb1

Browse files
author
Jarryd Tilbrook
authored
Merge pull request #444 from buildkite-plugins/mount-job-socket
Mount agent job socket/token
2 parents 4151607 + 52fd24d commit 1adacb1

3 files changed

Lines changed: 12 additions & 4 deletions

File tree

commands/run.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,13 @@ if [[ -n "${BUILDKITE_AGENT_BINARY_PATH:-}" ]] ; then
311311
"-e" "BUILDKITE_AGENT_ACCESS_TOKEN"
312312
"-v" "$BUILDKITE_AGENT_BINARY_PATH:/usr/bin/buildkite-agent"
313313
)
314+
if [[ -n "${BUILDKITE_AGENT_JOB_API_SOCKET:-}" ]] ; then
315+
run_params+=(
316+
"-e" "BUILDKITE_AGENT_JOB_API_SOCKET"
317+
"-e" "BUILDKITE_AGENT_JOB_API_TOKEN"
318+
"-v" "$BUILDKITE_AGENT_JOB_API_SOCKET:$BUILDKITE_AGENT_JOB_API_SOCKET"
319+
)
320+
fi
314321
fi
315322

316323
# Optionally expose service ports

tests/run.bats

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -866,10 +866,11 @@ cmd3"
866866
export BUILDKITE_PLUGIN_DOCKER_COMPOSE_CHECK_LINKED_CONTAINERS=false
867867
export BUILDKITE_PLUGIN_DOCKER_COMPOSE_CLEANUP=false
868868
export BUILDKITE_PLUGIN_DOCKER_COMPOSE_MOUNT_BUILDKITE_AGENT=true
869+
export BUILDKITE_AGENT_JOB_API_SOCKET=$BATS_MOCK_TMPDIR/agent.sock
869870

870871
stub docker \
871872
"compose -f docker-compose.yml -p buildkite1111 up -d --scale myservice=0 myservice : echo ran myservice dependencies" \
872-
"compose -f docker-compose.yml -p buildkite1111 run --name buildkite1111_myservice_build_1 -T --rm -e BUILDKITE_JOB_ID -e BUILDKITE_BUILD_ID -e BUILDKITE_AGENT_ACCESS_TOKEN -v $BATS_MOCK_TMPDIR/bin/buildkite-agent:/usr/bin/buildkite-agent myservice : echo ran myservice"
873+
"compose -f docker-compose.yml -p buildkite1111 run --name buildkite1111_myservice_build_1 -T --rm -e BUILDKITE_JOB_ID -e BUILDKITE_BUILD_ID -e BUILDKITE_AGENT_ACCESS_TOKEN -v $BATS_MOCK_TMPDIR/bin/buildkite-agent:/usr/bin/buildkite-agent -e BUILDKITE_AGENT_JOB_API_SOCKET -e BUILDKITE_AGENT_JOB_API_TOKEN -v $BUILDKITE_AGENT_JOB_API_SOCKET:$BATS_MOCK_TMPDIR/agent.sock myservice : echo ran myservice"
873874

874875
stub buildkite-agent \
875876
"meta-data exists docker-compose-plugin-built-image-tag-myservice : exit 1"
@@ -1219,7 +1220,7 @@ cmd3"
12191220

12201221
@test "Run with --quiet-pull" {
12211222
export BUILDKITE_COMMAND="echo hello world"
1222-
1223+
12231224
export BUILDKITE_PLUGIN_DOCKER_COMPOSE_RUN=myservice
12241225
export BUILDKITE_PLUGIN_DOCKER_COMPOSE_CHECK_LINKED_CONTAINERS=false
12251226
export BUILDKITE_PLUGIN_DOCKER_COMPOSE_QUIET_PULL=true

tests/v1/run.bats

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ cmd3"
513513
assert_success
514514
assert_output --partial "Running /bin/sh -e -c 'pwd' in service myservice"
515515
assert_output --partial "ran myservice without pull"
516-
516+
517517
unstub docker-compose
518518
unstub buildkite-agent
519519
}
@@ -1246,7 +1246,7 @@ cmd3"
12461246

12471247
@test "Run waiting for dependencies" {
12481248
export BUILDKITE_COMMAND="echo hello world"
1249-
1249+
12501250
export BUILDKITE_PLUGIN_DOCKER_COMPOSE_RUN=myservice
12511251
export BUILDKITE_PLUGIN_DOCKER_COMPOSE_CHECK_LINKED_CONTAINERS=false
12521252
export BUILDKITE_PLUGIN_DOCKER_COMPOSE_WAIT=true

0 commit comments

Comments
 (0)