style: refactor imports to separate lines#555
Draft
Lang-Qiu wants to merge 1 commit into
Draft
Conversation
Owner
|
Hi @Lang-Qiu, thanks for the contribution! We appreciate you taking the time to open this. The import cleanup makes sense, but the current diff rewrites the entire file (410 lines removed, 417 added) rather than just changing the import block. This can happen with line-ending or whitespace differences. It would wipe out Could you redo the change so only the import lines are modified? That way we can merge it cleanly. Happy to help if you have any questions! 你好 @Lang-Qiu,感谢你的贡献!非常感谢你花时间提交这个 PR。 import 的整理是有意义的,但目前的 diff 重写了整个文件(删除了 410 行,新增了 417 行),而不是只修改了 import 部分。这种情况通常是由于换行符或空白字符的差异导致的。这样会导致整个文件的 你能否重新提交一下,只修改 import 那几行?这样我们就可以顺利合并了。如果有任何问题,随时可以问我们! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题背景
这个 PR 解决了代码风格问题,将多个导入语句写在一行中,这违反了 PEP 8 的 E401 规则(多个导入在一行)。通过将导入拆分成单独的行,提高了代码的可读性和一致性。
修改内容
benchmarks/beam/bench_truememory_pro_beam10m.py中,将import ast, json, modal, os, re, sys, time, tempfile拆分为每个库单独一行。验证方式
其他信息