Skip to content

Commit 0aedfdc

Browse files
committed
refactoring
1 parent 92b1504 commit 0aedfdc

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

app/messages/messages.controller.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
this.messageService = messageService;
55
this.logger = logger;
66

7-
this.init();
7+
this.activate();
88
}
99

10-
init() {
11-
this.loadMessages().then(()=> {
10+
activate() {
11+
return this.loadMessages().then(()=> {
1212
this.logger.info('init Home View');
1313
});
1414
}
@@ -17,6 +17,8 @@
1717
loadMessages() {
1818
return this.messageService.findAll().then(response=> {
1919
this.messages = response;
20+
21+
return this.messages;
2022
});
2123
}
2224
}

tests/messages/messages-controller.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@
2727
});
2828
});
2929

30-
describe('#init', ()=> {
30+
describe('#activate', ()=> {
3131

3232
beforeEach(()=> {
3333
_inject();
3434
});
3535

3636
it('should be defined', ()=> {
3737
homeCtrl = controllerFactory('MessagesCtrl', mock);
38-
expect(typeof homeCtrl.init).toBe('function');
38+
expect(typeof homeCtrl.activate).toBe('function');
3939
});
4040

4141
it('should set messages property', () => {

0 commit comments

Comments
 (0)