Skip to content

Commit b4b54b5

Browse files
committed
Handle unknown[] LogEntry.text
1 parent 8c9ba22 commit b4b54b5

5 files changed

Lines changed: 188 additions & 125 deletions

File tree

example/ios/Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ PODS:
367367
- React-logger (= 0.68.2)
368368
- React-perflogger (= 0.68.2)
369369
- RnBugfender (2.1.1):
370-
- BugfenderSDK (~> 1.10.6)
370+
- BugfenderSDK (~> 1.10)
371371
- React-Core
372372
- SocketRocket (0.6.0)
373373
- Yoga (1.14.0)
@@ -570,7 +570,7 @@ SPEC CHECKSUMS:
570570
React-RCTVibration: 79040b92bfa9c3c2d2cb4f57e981164ec7ab9374
571571
React-runtimeexecutor: b960b687d2dfef0d3761fbb187e01812ebab8b23
572572
ReactCommon: 095366164a276d91ea704ce53cb03825c487a3f2
573-
RnBugfender: ea7b1c9c4949caa998e6ab637a7f74a9887d9410
573+
RnBugfender: ae54be1a04268922c094f8bc9453f269c83aef09
574574
SocketRocket: fccef3f9c5cedea1353a9ef6ada904fde10d6608
575575
Yoga: 99652481fcd320aefa4a7ef90095b95acd181952
576576
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

example/src/App.tsx

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,12 @@ export default function App() {
6565
title="Generate JS crash"
6666
/>
6767
</View>
68+
<View style={styles.button}>
69+
<Button
70+
onPress={_sendLogConsoleStyle}
71+
title="`console.*` compatible log entry"
72+
/>
73+
</View>
6874
<View style={styles.button}>
6975
<Button
7076
onPress={_onPressShowUserFeedback}
@@ -95,6 +101,16 @@ export default function App() {
95101
throw new Error('Force crash' + 'Time: ' + hours + ':' + min + ':' + sec);
96102
}
97103

104+
function _sendLogConsoleStyle(): void {
105+
Bugfender.sendLog({
106+
text: ['This is a console.* template: %s', 'value']
107+
});
108+
109+
Bugfender.sendLog({
110+
text: ['Just handles array of mixed values', true, 42, { foo: 'bar' }]
111+
});
112+
}
113+
98114
async function _onPressButton(): Promise<void> {
99115

100116
Bugfender.sendLog({

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@
157157
]
158158
},
159159
"dependencies": {
160-
"@bugfender/common": "1.0.0",
160+
"@bugfender/common": "^1.0.0",
161161
"@bugfender/sdk": "^2.1.0"
162162
}
163163
}

src/bugfender.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { NativeModules, Platform } from 'react-native';
2-
import { BugfenderFacade, DeviceKeyValue, LogEntry, LogLevel, PrintToConsole, UserFeedbackResult, format } from '@bugfender/common';
2+
import { BugfenderFacade, DeviceKeyValue, LogEntry, LogLevel, PrintToConsole, UserFeedbackResult, format, formatLogEntryText } from '@bugfender/common';
33
import type { ISDKOptions } from './types/sdk-options';
44
import type { UserFeedbackOptions } from './user-feedback';
55
import { DefaultUserFeedbackOptions } from './user-feedback';
@@ -278,7 +278,7 @@ class BugfenderClass implements BugfenderFacade {
278278
log.file ?? '',
279279
log.level ?? LogLevel.Debug,
280280
log.tag ?? '',
281-
log.text ?? ''
281+
formatLogEntryText(log.text ?? '')
282282
);
283283
}
284284

0 commit comments

Comments
 (0)