feat:otp for my_secrets

Author: theborch

src/pybritive/britive_cli.py

@@ -915,18 +915,20 @@ def configure_tenant(self, tenant, alias, output_format):
     def configure_global(self, default_tenant_name, output_format, backend):
         self.config.save_global(default_tenant_name=default_tenant_name, output_format=output_format, backend=backend)
 
-    def viewsecret(self, path, blocktime, justification, maxpolltime):
+    def viewsecret(self, path, blocktime, justification, otp, maxpolltime):
         self._validate_justification(justification)
         self.login()
 
         try:
             value = self.b.my_secrets.view(
-                path=path, justification=justification, wait_time=blocktime, max_wait_time=maxpolltime
+                path=path, justification=justification, otp=otp, wait_time=blocktime, max_wait_time=maxpolltime
             )
         except exceptions.AccessDenied as e:
             raise click.ClickException('user does not have access to the secret.') from e
         except exceptions.ApprovalRequiredButNoJustificationProvided as e:
             raise click.ClickException('approval required and no justification provided.') from e
+        except exceptions.StepUpAuthRequiredButNotProvided as e:
+            raise click.ClickException('Step Up Authentication required and no OTP provided.') from e
 
         # handle the generic note template type for a better UX
         if len(value) == 1 and 'Note' in value:
@@ -943,18 +945,20 @@ def viewsecret(self, path, blocktime, justification, maxpolltime):
         # and finally print the secret data
         self.print(value, ignore_silent=True)
 
-    def downloadsecret(self, path, blocktime, justification, maxpolltime, file):
+    def downloadsecret(self, path, blocktime, justification, otp, maxpolltime, file):
         self._validate_justification(justification)
         self.login()
 
         try:
             response = self.b.my_secrets.download(
-                path=path, justification=justification, wait_time=blocktime, max_wait_time=maxpolltime
+                path=path, justification=justification, otp=otp, wait_time=blocktime, max_wait_time=maxpolltime
             )
         except exceptions.AccessDenied as e:
             raise click.ClickException('user does not have access to the secret.') from e
         except exceptions.ApprovalRequiredButNoJustificationProvided as e:
             raise click.ClickException('approval required and no justification provided.') from e
+        except exceptions.StepUpAuthRequiredButNotProvided as e:
+            raise click.ClickException('Step Up Authentication required and no OTP provided.') from e
 
         filename_from_secret = response['filename']
         content = response['content_bytes']

src/pybritive/commands/secret.py

@@ -12,12 +12,15 @@ def secret():
 
 @secret.command()
 @build_britive
-@britive_options(names='blocktime,justification,maxpolltime,format,tenant,token,silent,passphrase,federation_provider')
+@britive_options(
+    names='blocktime,justification,otp,maxpolltime,format,tenant,token,silent,passphrase,federation_provider'
+)
 @click.argument('path')
 def view(
     ctx,
     blocktime,
     justification,
+    otp,
     maxpolltime,
     output_format,
     tenant,
@@ -35,20 +38,23 @@ def view(
     if not path.startswith('/'):
         path = f'/{path}'
 
-    ctx.obj.britive.viewsecret(path=path, blocktime=blocktime, justification=justification, maxpolltime=maxpolltime)
+    ctx.obj.britive.viewsecret(
+        path=path, blocktime=blocktime, justification=justification, otp=otp, maxpolltime=maxpolltime
+    )
 
 
 @secret.command()
 @build_britive
 @britive_options(
-    names='file,blocktime,justification,maxpolltime,format,silent,tenant,token,' 'passphrase,federation_provider'
+    names='file,blocktime,justification,otp,maxpolltime,format,silent,tenant,token,passphrase,federation_provider'
 )
 @click.argument('path')
 def download(
     ctx,
     file,
     blocktime,
     justification,
+    otp,
     maxpolltime,
     output_format,
     silent,
@@ -67,5 +73,5 @@ def download(
         path = f'/{path}'
 
     ctx.obj.britive.downloadsecret(
-        path=path, blocktime=blocktime, justification=justification, maxpolltime=maxpolltime, file=file
+        path=path, blocktime=blocktime, justification=justification, otp=otp, maxpolltime=maxpolltime, file=file
     )

src/pybritive/options/justification.py

@@ -5,5 +5,5 @@
     '-j',
     default=None,
     show_default=True,
-    help='Justification for the checkout approval process, if the profile checkout requires approval.',
+    help='Justification for the approval process, if a profile checkout or secret access requires approval.',
 )

src/pybritive/options/otp.py

@@ -5,5 +5,5 @@
     '-o',
     default=None,
     show_default=False,
-    help='OTP to checkout a profile, if the profile checkout requires MFA.',
+    help='OTP to checkout a profile, download a secret, or view a secret, if MFA is required.',
 )