Check typecast in array parameters

Checks a function with array parameters is being called correctly.
Also test updated.

Author: boriel

symbols/typecast.py

@@ -13,6 +13,7 @@
 from .type_ import SymbolTYPE
 from .type_ import Type as TYPE
 from .number import SymbolNUMBER
+from .vararray import SymbolVARARRAY
 
 from api.errmsg import syntax_error
 from api import errmsg
@@ -60,6 +61,11 @@ def make_node(cls, new_type, node, lineno):
         if new_type == node.type_:
             return node  # Do nothing. Return as is
 
+        # TODO: Create a base scalar type
+        if isinstance(node, SymbolVARARRAY):
+            syntax_error(lineno, "Array {} type does not match parameter type".format(node.name))
+            return None
+
         STRTYPE = TYPE.string
         # Typecasting, at the moment, only for number
         if node.type_ == STRTYPE:

tests/functional/pararray2.bas

@@ -0,0 +1,9 @@
+
+FUNCTION test(q() as UInteger) as Byte
+   DIM i as Ubyte = 3
+   q(i) = 7
+END FUNCTION
+
+DIM q(10) as UByte
+test(q)
+

tests/functional/test_errmsg.txt

@@ -41,9 +41,9 @@ mcleod3.bas:3: 'GenerateSpaces' is neither an array nor a function.
 mcleod3.bas:1: warning: Parameter 'path' is never used
 mcleod3.bas:6: warning: Parameter 'n' is never used
 >>> process_file('poke3.bas')
-poke3.bas:4: Variable 'a' is an array and cannot be used in this context
+poke3.bas:4: Syntax Error. Unexpected token ',' <COMMA>
 >>> process_file('poke5.bas')
-poke5.bas:4: Variable 'a' is an array and cannot be used in this context
+poke5.bas:4: Syntax Error. Unexpected token ',' <COMMA>
 >>> process_file('arrlabels10.bas')
 arrlabels10.bas:3: warning: Using default implicit type 'float' for 'a'
 arrlabels10.bas:3: Can't convert non-numeric value to float at compile time
@@ -84,7 +84,7 @@ errletfunc.bas:5: Cannot assign a value to 'x'. It's not a variable
 >>> process_file('read0.bas')
 read0.bas:12: 'x' is SUBROUTINE not a FUNCTION
 >>> process_file('read1.bas')
-read1.bas:11: Variable 'x' is an array and cannot be used in this context
+read1.bas:11: Cannot read 'x'. It's an array
 >>> process_file('read3.bas')
 read3.bas:9: 'x' is neither an array nor a function.
 >>> process_file('read6.bas')
@@ -141,4 +141,6 @@ params_implicit.bas:2: warning: Parameter 'y' is never used
 array_err.bas:2: Mismatched vector size. Expected 11 elements, got 1.
 >>> process_file('arrbase1.bas')
 >>> process_file('param_byref_warn.bas')
+>>> process_file('pararray2.bas')
+pararray2.bas:8: Array q type does not match parameter type