Merge pull request #521 from boriel/bugfix/do_not_allow_string_arrays_initialization

Do not allow initialization of arrays of strings

Author: boriel

src/api/errmsg.py

@@ -307,4 +307,12 @@ def syntax_error_cannot_pass_array_by_value(lineno: int, id_: str):
 def syntax_error_no_data_defined(lineno: int):
     error(lineno, "No DATA defined")
 
+
+# ----------------------------------------
+#  Cannot pass an array by value
+# ----------------------------------------
+def syntax_error_cannot_initialize_array_of_type(lineno: int, type_name: str):
+    error(lineno, f"Cannot initialize array of type {type_name}")
+
+
 # endregion

src/zxbc/zxbparser.py

@@ -848,12 +848,22 @@ def check_bound(boundlist, remaining):
         return True
 
     p[0] = None
-    if p[8] is None:
+    if p[4] is None or p[6] is None or p[8] is None:
         return
 
-    if check_bound(p[4].children, p[8]):
-        id_, lineno = p[2][0]
-        SYMBOL_TABLE.declare_array(id_, lineno, p[6], p[4], default_value=p[8])
+    if not check_bound(p[4].children, p[8]):
+        return
+
+    id_, lineno = p[2][0]
+    SYMBOL_TABLE.declare_array(id_, lineno, p[6], p[4], default_value=p[8])
+
+    entry = SYMBOL_TABLE.get_entry(id_)
+    if entry is None:
+        return
+
+    if p[6] == TYPE.string or entry.type_ == TYPE.string:
+        src.api.errmsg.syntax_error_cannot_initialize_array_of_type(p.lineno(1), TYPE.string)
+        return
 
 
 def p_bound_list(p):

tests/functional/dim_str_error0.bas

@@ -0,0 +1,4 @@
+
+
+DIM a(2) as String => {0, 1, 2}
+

tests/functional/dim_str_error1.bas

@@ -0,0 +1,4 @@
+
+
+DIM a$(2) => {0, 1, 2}
+

tests/functional/test_errmsg.txt

@@ -52,7 +52,7 @@ poke5.bas:4: error: Syntax Error. Unexpected token ',' <COMMA>
 arrlabels10.bas:3: warning: Using default implicit type 'float' for 'a'
 arrlabels10.bas:3: error: Can't convert non-numeric value to float at compile time
 >>> process_file('arrlabels10c.bas')
-arrlabels10c.bas:3: error: Can't convert non-numeric value to string at compile time
+arrlabels10c.bas:3: error: Cannot initialize array of type string
 >>> process_file('arrlabels10d.bas')
 arrlabels10d.bas:3: error: Undeclared array "a"
 >>> process_file('arrlabels11.bas')
@@ -201,6 +201,10 @@ bad_pragma.bas:6: warning: Ignoring unknown pragma 'BAD_PRAGMA'
 >>> process_file('opt2_global_array2.bas')
 opt2_global_array2.bas:1: warning: Variable 'myArray' is never used
 >>> process_file('end.bas')
+>>> process_file('dim_str_error0.bas')
+dim_str_error0.bas:3: error: Cannot initialize array of type string
+>>> process_file('dim_str_error1.bas')
+dim_str_error1.bas:3: error: Cannot initialize array of type string
 
 # Test warning silencing
 >>> process_file('mcleod3.bas', ['-S', '-q', '-O --expect-warnings=2'])