Skip to content

--diff_json_path is an INPUT (JSONL difficulty labels), not an output; a missing file crashes after the full evaluation has run #44

Description

@christian-gheorghe

The flag name reads like a diff report the evaluator will write. It is the opposite: compute_acc_by_diff() calls load_jsonl(diff_json_path) to read each question's difficulty. A path that does not exist raises FileNotFoundError only after all queries have executed, and dev.json (a JSON array) cannot be used directly because the loader expects JSONL.

Suggested fix: rename to --difficulty_jsonl_path, validate it before running, and accept dev.json.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions