Skip to content

Commit 881da26

Browse files
fix: code review improvements
1 parent 6a4d2c8 commit 881da26

3 files changed

Lines changed: 9 additions & 12 deletions

File tree

src/design-system/bottomSheets/BottomSheetScrollables.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,14 @@
22
// Could be connected to this: https://github.com/gorhom/react-native-bottom-sheet/issues/1524
33
// Could be connected to this: https://github.com/gorhom/react-native-bottom-sheet/issues/1760
44
// After upgrading bottom sheet library try changing the imports, maybe it will work as expected
5-
// import { BottomSheetScrollView as ScrollView, BottomSheetFlashList as FlashList, BottomSheetSectionList as SectionList } from "@gorhom/bottom-sheet";
6-
import { FlatList as RNFlatList, Platform, SectionList } from 'react-native'
5+
import {
6+
// BottomSheetScrollView as ScrollView,
7+
// BottomSheetFlashList as FlashList,
8+
BottomSheetSectionList as SectionList,
9+
} from '@gorhom/bottom-sheet'
10+
// import { SectionList } from 'react-native'
711
import { ScrollView, FlatList } from 'react-native-gesture-handler'
812

913
export const BottomSheetScrollView = ScrollView
10-
export const BottomSheetFlatList = Platform.OS === 'web' ? RNFlatList : FlatList
14+
export const BottomSheetFlatList = FlatList
1115
export const BottomSheetSectionList = SectionList

src/design-system/components/Select.tsx

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,6 @@ const SelectItem = <T extends SelectKey>({
7373
isChecked={selected}
7474
size="md"
7575
pb={4}
76-
// isDisabled={disabled}
77-
// isError={false}
78-
// isSelected={selected}
79-
// label={item.labelInDropdown ?? item.label}
80-
// onChange={onItemSelect}
81-
// size="md"
82-
// pb={4}
8376
/>
8477
)
8578
}
@@ -178,7 +171,7 @@ export const Select = <T extends SelectKey>({
178171
styles.bottomSheetContentFlatList,
179172
{ paddingBottom: flatListPaddingBottom },
180173
]}
181-
data={items}
174+
data={[...items, ...items]}
182175
keyExtractor={keyExtractor}
183176
renderItem={renderItem}
184177
getItemLayout={getItemLayout}

src/design-system/modals/FullScreenModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Box } from '@baca/design-system'
1+
import { Box } from '@baca/design-system/components/Box'
22
import { useBoolean, useImperativeHandle } from '@baca/hooks'
33
import { RefObject } from 'react'
44
import { Modal, ModalProps } from 'react-native'

0 commit comments

Comments
 (0)