From 5760cd237f59c1e091fa231d89fb19a78b3e8956 Mon Sep 17 00:00:00 2001 From: Niraj Raut <84171890+rautniraj@users.noreply.github.com> Date: Tue, 18 Mar 2025 14:41:37 +0530 Subject: [PATCH 1/3] Removed extra checks from isAdmin variable We dont need these two checks : currentUser && currentUser.role We are already handling this very safe : currentUser?.role.name === 'Administrator'; --- app/javascript/components/shared_components/Footer.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/javascript/components/shared_components/Footer.jsx b/app/javascript/components/shared_components/Footer.jsx index 2b30506e3c..4201809c52 100644 --- a/app/javascript/components/shared_components/Footer.jsx +++ b/app/javascript/components/shared_components/Footer.jsx @@ -26,7 +26,7 @@ export default function Footer() { const { data: env } = useEnv(); const { data: links } = useSiteSetting(['Terms', 'PrivacyPolicy']); const currentUser = useAuth(); - const isAdmin = currentUser && currentUser.role && currentUser?.role.name === 'Administrator'; + const isAdmin = currentUser?.role.name === 'Administrator'; return (