example first_person_view_model broken by Minimal unstyled Text Input with Parley

[mockersf]

Bevy version and features

• main since Minimal unstyled Text Input with Parley #23282

What you did

Run the example first_person_view_model

What went wrong

If I remove the text, it renders as expected

Additional information

#23282 is surprising, it could be random, but I bisected to it and reproduced reliably by spawning text or not in the example

[ickshonpe]

I don't think this has anything to do with the editable_text PR directly, it's an existing bug with cameras and camera ordering and rendering passes or whatever. Something somewhere is nondeterministic and the new systems and components in the editable_text PR muddled things up.

[ickshonpe]

Not at my computer but as evidence I'd expect that you'll see the same artifacts if you just draw a button or something instead of text.

[ickshonpe]

Yep with:

fn spawn_text(mut commands: Commands) {
    commands
        .spawn(Node {
            position_type: PositionType::Absolute,
            bottom: px(12),
            left: px(12),
            ..default()
        })
        .with_child((
            Node {
                width: px(100),
                height: px(100),
                ..default()
            },
            BackgroundColor(bevy::color::palettes::css::GREEN.into()),
        ));
}

same thing:

[kfc35]

I decided to re-check this recently while inspecting the milestone, and the shadow does not look as broken anymore (it’s one contiguous shadow as opposed to being weirdly broken off at the end of the arm). Removing the spawned text does not affect the appearance of the shadow as well.

I actually wonder if that shadow was supposed to be there the whole time as opposed to there not being a shadow before the text input PR. This cube material in the example is floating above the player iiuc

    commands.spawn((
        Mesh3d(cube),
        MeshMaterial3d(material),
        Transform::from_xyz(0.75, 1.75, 0.0),
    ));

and the light, iiuc, is situated above it (a higher y coordinate)

commands.spawn((
        PointLight {
            color: Color::from(tailwind::ROSE_300),
            shadow_maps_enabled: true,
            ..default()
        },
        ShowLightGizmo::default(),
        Transform::from_xyz(-2.0, 4.0, -0.75),
        // The light source illuminates both the world model and the view model.
        RenderLayers::from_layers(&[DEFAULT_RENDER_LAYER, VIEW_MODEL_RENDER_LAYER]),
    ));

So I’d expect there to be a shadow from the light to be cast from the cube above the player downwards onto the player / arm.

In the commit before the minimal text PR merge, there also isn’t a shadow next to the pink box in front of the player from the light source. After the text PR merge, and on main now, there is a shadow next to the pink box that is consistently there no matter if the text node has been spawned or not afaict