Allow users to set the window's icon

[Azales94500]

Hello,

I just started using Bevy and I wanted to start experimenting a bit with a small project, I wanted to put an image as an icon in the game window, but I couldn't find how to do it, even searching in the documentation, I specify that I'm using version 0.3.0 of Bevy, is it me who missed something? Or is this feature not yet implemented?

If it is not implemented, would it be possible to just add a field to the WindowDescriptor resource to specify this icon as it is possible to do it for the window title ?

Thank you in advance for the answers

[mockersf]

hello and welcome!

It has not yet been implemented, but it should be possible using winit with_window_icon when building the window.

If you're interested in doing the PR, you could add a field to WindowDescriptor for the icon, with a type copying the Icon type from winit (there shouldn't be a dependency in bevy_windows to winit, so the type has to be copied there). And then when executing create_window , check if an icon has been set in the WindowDescriptor and call with_window_icon from winit on the builder.

Ideally it should be available only when running on windows or with X11 as it won't do anything otherwise, but I'm not sure it's possible to select X11 with a config. You could at least only enable it on windows and linux.

[Azales94500]

Thanks for the explanation, I'm not sure I have the skills to add it myself, I think it would be better if someone more experienced would do it

[smokku]

This is a good first-time-issue for Bevy development.

[goodbadwolf]

Is anyone working on this? If not, I would like to take a stab at this.

[Azales94500]

Is anyone working on this? If not, I would like to take a stab at this.

Sorry for the late answer, no one claims it, so i think you can work on it ^^

[alice-i-cecile]

Will be closed by #2268.

[Azales94500]

Oh, should i close this issue then ?

[NiklasEi]

Oh, should i close this issue then ?

You can leave it open. Posting the PR number just creates a link between the issue and the PR. When it gets merged the issue will probably be closed 🙂

[Azales94500]

Thank you, i didn't know that 👍

[alice-i-cecile]

This is still incomplete. The work done in #2268 was good, but ended up abandoned without relicensing. When tackling this, you cannot directly reuse that code.