You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue #101 claims alloc/__main__.py has zero test coverage. This is no
longer true: __main__ is exercised by two test classes, and a third
was added this cycle. The issue should be closed and the duplicate coverage
consolidated.
Evidence
tests/test_cli.py::TestMainModule (line ~803) — 2 tests (import, has main).
Consolidate the __main__ tests into a single tests/test_main.py
(or keep them in test_cli.py since __main__ delegates to cli.main),
removing the duplicates in test_actor_critic.py and test_portfolio.py.
Keep the strongest assertions: delegation identity
(alloc.__main__.main is alloc.cli.main), exit-code propagation, and the
runpy python -m alloc --help invocation.
Summary
Issue #101 claims
alloc/__main__.pyhas zero test coverage. This is nolonger true:
__main__is exercised by two test classes, and a thirdwas added this cycle. The issue should be closed and the duplicate coverage
consolidated.
Evidence
tests/test_cli.py::TestMainModule(line ~803) — 2 tests (import, has main).tests/test_actor_critic.py::TestMainModule(line ~505, tagged TICKET-034)— 7 tests (import, delegation, callable, exit code, invalid args, AST
guard check, runpy invocation).
tests/test_portfolio.py::TestMainEntryPoint(added this cycle) — 2 tests(delegation identity, exit-code propagation).
pytest tests/test_cli.py::TestMainModule tests/test_actor_critic.py::TestMainModule tests/test_portfolio.py::TestMainEntryPoint→ 11 passed.
Impact
alloc.__main__module entry point #101 is misleading; a newcomer would believe the entry point isuntested and may add redundant tests.
TestMainModule/TestMainEntryPointclasses scatterthe same concerns across three files.
Suggestion (implementation plan)
alloc.__main__module entry point #101 with a note that coverage now exists (cite the threeclasses).
__main__tests into a singletests/test_main.py(or keep them in
test_cli.pysince__main__delegates tocli.main),removing the duplicates in
test_actor_critic.pyandtest_portfolio.py.(
alloc.__main__.main is alloc.cli.main), exit-code propagation, and therunpy
python -m alloc --helpinvocation.Acceptance criteria
alloc.__main__module entry point #101 closed.alloc.__main__.