From c28a11d797435e998adfe213742d85490d9d9c55 Mon Sep 17 00:00:00 2001 From: Zoey Rose Date: Sat, 14 Nov 2026 21:13:24 -0600 Subject: [PATCH 1/2] fix(governance): name the read-only settings check Route settings, ruleset, Actions policy and required-check work to check_settings.py in atrinik/github-settings: run it before and after a change, stop on differences the task did not cause, and record the change in a baseline pull request there. Pin the new wording in the contract test. Co-Authored-By: Claude --- .../skills/atrinik-github-governance/SKILL.md | 40 ++++++++++++------- tests/test_imported_skill_contracts.py | 12 +++++- 2 files changed, 36 insertions(+), 16 deletions(-) diff --git a/plugins/atrinik-development/skills/atrinik-github-governance/SKILL.md b/plugins/atrinik-development/skills/atrinik-github-governance/SKILL.md index c0a5c17..b17f8bd 100644 --- a/plugins/atrinik-development/skills/atrinik-github-governance/SKILL.md +++ b/plugins/atrinik-development/skills/atrinik-github-governance/SKILL.md @@ -12,20 +12,29 @@ description: Publish Atrinik PRs, govern GitHub policy, or review and explicitly Review-only work is read-only and never grants merge authority. 2. For PR-only work, read its repository's `AGENTS.md`, use **Publish pull requests**, and skip steps 3–5. -3. For policy, settings, Actions, checks, or release governance, read the - workspace guide and the current `README.md` and `AGENTS.md` of - `atrinik/github-settings`, then compare them with the live GitHub API. - Its publisher, audit and Project sync are retired. Never run its `bin/` - scripts (`publish*`, `audit`, `sync-project` and the rest), with or without - `--apply`, from its current tree, an old checkout or a release, even where - its `README.md` or `AGENTS.md` still describes them. +3. For policy, settings, rulesets, Actions policy, required checks, or release + governance, read the workspace guide and the current `README.md` and + `AGENTS.md` of `atrinik/github-settings`. Its publisher, audit and Project + sync are retired. Never run its `bin/` scripts (`publish*`, `audit`, + `sync-project` and the rest), with or without `--apply`, from its current + tree, an old checkout or a release, even where its `README.md` or + `AGENTS.md` still describes them. 4. Organization-wide rules live in organization rulesets aimed at all repositories, not lists of names; a required-check ruleset targets its one - repository. Change a setting by hand under the owner's login only when the - current task asks for that change; workflow dispatch also needs explicit - authorization. Export each object before the change, re-read it live - afterwards, and record the change in the same task where that `README.md` - says records live. Never record a setting for later application. + repository. Before and after any settings change, run the read-only + settings check from a checkout of `atrinik/github-settings`: + `python3 check_settings.py baselines/atrinik.json` (exit 0 match, 1 + differences, 2 only "could not verify", 3 could not run; see its + `README.md`). Report any difference the task did not cause and ask the + owner before you go on. Change a setting by hand under the owner's login + only when the current task asks for that change; workflow dispatch also + needs explicit authorization. The check never runs a fix; run a printed + fix command only when the task authorizes that exact change. Export each + object the change touches before you change it. Then record the change in + the same task: update `baselines/atrinik.json` for it and open a pull + request in `atrinik/github-settings` that quotes the check output and + explains each remaining line. Never record a setting for later + application. 5. Keep controls Team-plan compatible; document and review Enterprise-only migrations. @@ -66,11 +75,12 @@ validation sections. ## Validate and hand off -For settings changes, check each changed object against a fresh live read. +For settings changes, rerun the check after the change and after the baseline +update; the baseline pull request quotes its final output. For workflow changes, run actionlint, ShellCheck where shell changed, and `git diff --check`. For PR-only work, run repository validation and the rendered-view check. For policy, document affected repositories, required checks, the pre-change -export used for rollback, and unchanged live state. For PRs, record remote -render verification. Use Conventional Commits. +export used for rollback, the baseline pull request, and unchanged live state. +For PRs, record remote render verification. Use Conventional Commits. diff --git a/tests/test_imported_skill_contracts.py b/tests/test_imported_skill_contracts.py index 1d6f575..114b8fa 100644 --- a/tests/test_imported_skill_contracts.py +++ b/tests/test_imported_skill_contracts.py @@ -279,12 +279,22 @@ def test_native_pr_stack_governance_is_guarded_and_complete(self) -> None: "organization rulesets aimed at all repositories", "only when the current task asks for that change", "record the change in the same task", + # The read-only settings check replaces ad hoc live comparison. + "run the read-only settings check from a checkout of `atrinik/github-settings`", + "`python3 check_settings.py baselines/atrinik.json`", + "Before and after any settings change", + "Report any difference the task did not cause", + "only when the task authorizes that exact change", + "update `baselines/atrinik.json` for it and open a pull request in `atrinik/github-settings`", + "quotes the check output and explains each remaining line", + "rerun the check after the change and after the baseline update", }: with self.subTest(marker=marker): self.assertIn(marker, normalized_body) for stale in {"publisher plan", "github-settings/AGENTS.md", "before `--apply`", "tools its current `README.md` documents", - "update the Actions allowlist"}: + "update the Actions allowlist", "compare them with the live GitHub API", + "against a fresh live read"}: with self.subTest(stale=stale): self.assertNotIn(stale, normalized_body) for name in ("atrinik-issue-delivery/references/preparation.md", From cd7979d6d84f85c3e6bd41e9ecc1e8bc6fa0ece7 Mon Sep 17 00:00:00 2001 From: Zoey Rose Date: Sat, 14 Nov 2026 21:14:02 -0600 Subject: [PATCH 2/2] chore(provenance): record the settings check skill update Move the governance skill record to the new source commit with the current main as its baseline, approve that pair in CI, the tests and PROVENANCE.md, and bump the plugin to 1.0.3. Co-Authored-By: Claude --- .github/workflows/validate.yml | 4 ++-- PROVENANCE.md | 2 +- .../.codex-plugin/plugin.json | 2 +- plugins/atrinik-development/plugin.json | 2 +- plugins/atrinik-development/provenance.json | 18 +++++++++--------- tests/test_package.py | 6 +++--- 6 files changed, 17 insertions(+), 17 deletions(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index 4cc99fa..ac82295 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -44,8 +44,8 @@ jobs: 'https://github.com/atrinik/agent-integrations.git': { 'f723d04a095e8e8d44d54b5ca6a85475f2713912', '0401a87fe0e8f87bf7783e9d040d717d28afff23', - '86ea8241c54d13cad38a5eb0928770e4c97156ab', - '98196a538e77622ee2aa804b3d90c053d52a11d3', + 'c28a11d797435e998adfe213742d85490d9d9c55', + '692c9a5e09b3b4be697fad500af6b7596913b078', '38a3f01939c67e5172e4a7eedd8f6330e9339bbd', }, 'https://github.com/atrinik/atrinik.git': { diff --git a/PROVENANCE.md b/PROVENANCE.md index e9fc486..ae7b013 100644 --- a/PROVENANCE.md +++ b/PROVENANCE.md @@ -55,7 +55,7 @@ alternates, so a cached local commit cannot mask an unavailable remote object. Remote availability alone does not establish reviewed history. Source-controlled policy admits only the independently reviewed immutable provider source/baseline pairs `f723d04`/`0401a87` (Linux qualification and workspace guidance) and -`86ea824`/`98196a5` (GitHub governance guidance), anchor `38a3f01`, and wrapper +`c28a11d`/`692c9a5` (GitHub governance guidance), anchor `38a3f01`, and wrapper updates `a9661a2` and `8b00b5b`; the executable policy uses full commit IDs. CI rejects other IDs before fetching. Offline validation additionally restricts each approved ID to its reviewed role and source paths. Adding an ID or changing its role requires an independently diff --git a/plugins/atrinik-development/.codex-plugin/plugin.json b/plugins/atrinik-development/.codex-plugin/plugin.json index 010ba11..95c0cd2 100644 --- a/plugins/atrinik-development/.codex-plugin/plugin.json +++ b/plugins/atrinik-development/.codex-plugin/plugin.json @@ -1,6 +1,6 @@ { "name": "atrinik-development", - "version": "1.0.2", + "version": "1.0.3", "description": "Reusable Atrinik development skills with portable public references.", "author": { "name": "Atrinik contributors", diff --git a/plugins/atrinik-development/plugin.json b/plugins/atrinik-development/plugin.json index aeb83ef..9985a39 100644 --- a/plugins/atrinik-development/plugin.json +++ b/plugins/atrinik-development/plugin.json @@ -1,7 +1,7 @@ { "$schema": "https://agent-plugins.org/schemas/1.0.0/plugin.schema.json", "name": "atrinik-development", - "version": "1.0.2", + "version": "1.0.3", "description": "Reusable Atrinik development skills with portable public references.", "author": { "name": "Atrinik contributors", diff --git a/plugins/atrinik-development/provenance.json b/plugins/atrinik-development/provenance.json index 934af53..d8fb995 100644 --- a/plugins/atrinik-development/provenance.json +++ b/plugins/atrinik-development/provenance.json @@ -344,26 +344,26 @@ }, { "repository": "https://github.com/atrinik/agent-integrations.git", - "revision": "86ea8241c54d13cad38a5eb0928770e4c97156ab", + "revision": "c28a11d797435e998adfe213742d85490d9d9c55", "source_path": "plugins/atrinik-development/skills/atrinik-github-governance/SKILL.md", - "source_url": "https://github.com/atrinik/agent-integrations/blob/86ea8241c54d13cad38a5eb0928770e4c97156ab/plugins/atrinik-development/skills/atrinik-github-governance/SKILL.md", - "source_blob": "c0a5c1798ebe690cb779ac2d3c5796f2523ddf8c", + "source_url": "https://github.com/atrinik/agent-integrations/blob/c28a11d797435e998adfe213742d85490d9d9c55/plugins/atrinik-development/skills/atrinik-github-governance/SKILL.md", + "source_blob": "b17f8bd77718cee6d30e14a736b18a81f0127959", "destination_path": "plugins/atrinik-development/skills/atrinik-github-governance/SKILL.md", - "destination_blob": "c0a5c1798ebe690cb779ac2d3c5796f2523ddf8c", + "destination_blob": "b17f8bd77718cee6d30e14a736b18a81f0127959", "baseline": { - "revision": "98196a538e77622ee2aa804b3d90c053d52a11d3", + "revision": "692c9a5e09b3b4be697fad500af6b7596913b078", "path": "plugins/atrinik-development/skills/atrinik-github-governance/SKILL.md", - "blob": "95cf8844f7e0770c3db68d0e25c4039270d37802" + "blob": "c0a5c1798ebe690cb779ac2d3c5796f2523ddf8c" }, "license": { "spdx": "MIT", "path": "LICENSE", "blob": "ae279af2f927edd5ab41f7fa95c72d2d99010de2", - "source_url": "https://github.com/atrinik/agent-integrations/blob/86ea8241c54d13cad38a5eb0928770e4c97156ab/LICENSE" + "source_url": "https://github.com/atrinik/agent-integrations/blob/c28a11d797435e998adfe213742d85490d9d9c55/LICENSE" }, "transformations": [ - "Locally authored update from the recorded baseline: the atrinik/github-settings publisher, audit and Project sync are retired; route settings work to that repository's current README.md and AGENTS.md, forbid its bin/ scripts from the current tree, old checkouts or releases, and describe task-authorized hand changes that are exported first, re-read live and recorded in the same task.", - "Corrected the PR-only step range to 3-5; made allowlist and ruleset changes from workflow edits task-authorized only; retained the stack contract, PR publication contract, links and authority boundaries." + "Locally authored update from the recorded baseline, which carries the earlier update that retired the atrinik/github-settings publisher, audit and Project sync and banned its bin/ scripts from the current tree, old checkouts or releases.", + "Named the read-only check_settings.py in atrinik/github-settings for settings, ruleset, Actions policy and required-check work: its command, exit codes, running it before and after a change, stopping on differences the task did not cause, running a printed fix only when the task authorizes that exact change, and recording the change in a baseline pull request there; removed the vague live GitHub API comparison and retained the stack contract, PR publication contract, links and authority boundaries." ] } ] diff --git a/tests/test_package.py b/tests/test_package.py index 445c329..08fbba6 100644 --- a/tests/test_package.py +++ b/tests/test_package.py @@ -48,8 +48,8 @@ PROVENANCE_PATH = "plugins/atrinik-development/provenance.json" LOCAL_SOURCE_REVISION = "f723d04a095e8e8d44d54b5ca6a85475f2713912" LOCAL_BASELINE_REVISION = "0401a87fe0e8f87bf7783e9d040d717d28afff23" -GOVERNANCE_SOURCE_REVISION = "86ea8241c54d13cad38a5eb0928770e4c97156ab" -GOVERNANCE_BASELINE_REVISION = "98196a538e77622ee2aa804b3d90c053d52a11d3" +GOVERNANCE_SOURCE_REVISION = "c28a11d797435e998adfe213742d85490d9d9c55" +GOVERNANCE_BASELINE_REVISION = "692c9a5e09b3b4be697fad500af6b7596913b078" # Each locally authored path admits exactly one reviewed (source, baseline) role pair. LOCAL_UPDATE_ROLES = { "plugins/atrinik-development/skills/atrinik-linux-gpu-qualification/references/linux-vulkan.md": @@ -278,7 +278,7 @@ def test_marketplace_and_plugin_manifests_are_consistent(self) -> None: self.assertEqual(codex["name"], entry["name"]) self.assertEqual(plugin["version"], codex["version"]) self.assertEqual(codex["skills"], "./skills/") - self.assertEqual(plugin["version"], "1.0.2") + self.assertEqual(plugin["version"], "1.0.3") self.assertEqual( plugin["repository"], "https://github.com/atrinik/agent-integrations",