From 12a4bb08dcd689f676092fe3bded19e74fc69bab Mon Sep 17 00:00:00 2001
From: "[._.]/ Adam Eivy" <atomantic@gmail.com>
Date: Wed, 9 Sep 2026 02:10:25 +0000
Subject: [PATCH 1/2] fix: bind restores to previewed scope (#6670)

---
 client/src/components/BackupWidget.jsx      | 63 +++++++++----
 client/src/components/BackupWidget.test.jsx | 97 +++++++++++++++++++++
 2 files changed, 144 insertions(+), 16 deletions(-)

diff --git a/client/src/components/BackupWidget.jsx b/client/src/components/BackupWidget.jsx
index 095cea943c..6b00a6054a 100644
--- a/client/src/components/BackupWidget.jsx
+++ b/client/src/components/BackupWidget.jsx
@@ -1,4 +1,4 @@
-import { useState, memo, useCallback, useId } from 'react';
+import { useState, memo, useCallback, useId, useRef } from 'react';
 import { Link } from 'react-router';
 import {HardDrive,
   ChevronDown,
@@ -62,31 +62,59 @@ const HEALTH_STYLES = {
 function RestorePanel({ snapshot, onClose }) {
   const filterId = useId();
   const [filter, setFilter] = useState('');
-  const [preview, setPreview] = useState(null);
+  const [acceptedPreview, setAcceptedPreview] = useState(null);
   const [previewing, setPreviewing] = useState(false);
   const [restoring, setRestoring] = useState(false);
+  const previewGenerationRef = useRef(0);
+
+  const currentRequest = {
+    snapshotId: snapshot.id,
+    subdirFilter: filter.trim() || null,
+  };
+  const previewMatchesCurrentRequest = acceptedPreview
+    && acceptedPreview.request.snapshotId === currentRequest.snapshotId
+    && acceptedPreview.request.subdirFilter === currentRequest.subdirFilter;
+
+  const handleFilterChange = useCallback((event) => {
+    previewGenerationRef.current += 1;
+    setFilter(event.target.value);
+    setAcceptedPreview(null);
+    setPreviewing(false);
+  }, []);
 
   const handlePreview = useCallback(async () => {
-    setPreviewing(true);
-    setPreview(null);
-    const result = await api.restoreBackup({
+    const generation = previewGenerationRef.current + 1;
+    previewGenerationRef.current = generation;
+    const request = {
       snapshotId: snapshot.id,
+      subdirFilter: filter.trim() || null,
+    };
+    setPreviewing(true);
+    setAcceptedPreview(null);
+    const outcome = await api.restoreBackup({
+      ...request,
       dryRun: true,
-      subdirFilter: filter.trim() || null
-    }, { silent: true }).catch(err => {
-      toast.error(`Preview failed: ${err.message}`);
-      return null;
-    });
+    }, { silent: true }).then(
+      previewResult => ({ previewResult }),
+      previewError => ({ previewError }),
+    );
+
+    if (previewGenerationRef.current !== generation) return;
     setPreviewing(false);
-    if (result) setPreview(result);
+    if (outcome.previewError) {
+      toast.error(`Preview failed: ${outcome.previewError.message}`);
+      return;
+    }
+    if (outcome.previewResult) setAcceptedPreview({ request, result: outcome.previewResult });
   }, [snapshot.id, filter]);
 
   const handleRestore = useCallback(async () => {
+    if (!previewMatchesCurrentRequest || restoring) return;
+
     setRestoring(true);
     const result = await api.restoreBackup({
-      snapshotId: snapshot.id,
+      ...acceptedPreview.request,
       dryRun: false,
-      subdirFilter: filter.trim() || null
     }, { silent: true }).catch(err => {
       toast.error(`Restore failed: ${err.message}`);
       return null;
@@ -96,7 +124,9 @@ function RestorePanel({ snapshot, onClose }) {
       toast.success(`Restore complete — ${result.changedFiles?.length ?? 0} file(s) restored`);
       onClose();
     }
-  }, [snapshot.id, filter, onClose]);
+  }, [acceptedPreview, onClose, previewMatchesCurrentRequest, restoring]);
+
+  const preview = previewMatchesCurrentRequest ? acceptedPreview.result : null;
 
   return (
     <div className="mt-3 p-3 bg-port-bg rounded-lg border border-port-border space-y-3">
@@ -121,7 +151,8 @@ function RestorePanel({ snapshot, onClose }) {
           id={filterId}
           type="text"
           value={filter}
-          onChange={e => setFilter(e.target.value)}
+          onChange={handleFilterChange}
+          disabled={restoring}
           placeholder="e.g., brain"
           className="w-full bg-port-card border border-port-border rounded px-3 py-1.5 text-sm text-white placeholder-gray-600 focus:outline-hidden focus:border-port-accent"
         />
@@ -133,7 +164,7 @@ function RestorePanel({ snapshot, onClose }) {
       {/* Preview button */}
       <button
         onClick={handlePreview}
-        disabled={previewing}
+        disabled={previewing || restoring}
         className="flex items-center gap-2 px-3 py-1.5 bg-port-border hover:bg-port-border/70 text-gray-300 rounded text-sm transition-colors disabled:opacity-50 disabled:cursor-not-allowed min-h-[36px]"
       >
         {previewing ? (
diff --git a/client/src/components/BackupWidget.test.jsx b/client/src/components/BackupWidget.test.jsx
index cb1bb8eba2..71bb7587b4 100644
--- a/client/src/components/BackupWidget.test.jsx
+++ b/client/src/components/BackupWidget.test.jsx
@@ -6,12 +6,14 @@ const {
   mockGetBackupStatus,
   mockGetBackupSnapshots,
   mockDownloadBackupSnapshot,
+  mockRestoreBackup,
   mockTriggerBackup,
   mockToast,
 } = vi.hoisted(() => ({
   mockGetBackupStatus: vi.fn(),
   mockGetBackupSnapshots: vi.fn(),
   mockDownloadBackupSnapshot: vi.fn(),
+  mockRestoreBackup: vi.fn(),
   mockTriggerBackup: vi.fn(),
   mockToast: Object.assign(vi.fn(), { success: vi.fn(), error: vi.fn() }),
 }));
@@ -20,6 +22,7 @@ vi.mock('../services/api', () => ({
   getBackupStatus: (...args) => mockGetBackupStatus(...args),
   getBackupSnapshots: (...args) => mockGetBackupSnapshots(...args),
   downloadBackupSnapshot: (...args) => mockDownloadBackupSnapshot(...args),
+  restoreBackup: (...args) => mockRestoreBackup(...args),
   triggerBackup: (...args) => mockTriggerBackup(...args),
 }));
 
@@ -33,6 +36,12 @@ const renderWidget = () => render(
   </MemoryRouter>,
 );
 
+const openRestorePanel = async () => {
+  fireEvent.click(await screen.findByRole('button', { name: 'Snapshots' }));
+  fireEvent.click(await screen.findByRole('button', { name: 'Restore' }));
+  return screen.findByRole('textbox', { name: 'Selective restore (optional)' });
+};
+
 beforeEach(() => {
   vi.clearAllMocks();
   mockGetBackupStatus.mockResolvedValue({
@@ -94,6 +103,94 @@ describe('BackupWidget snapshots', () => {
 
     await waitFor(() => expect(mockToast.error).toHaveBeenCalledWith('Download failed: Connection lost'));
   });
+
+  it('restores exactly the selective scope accepted by the preview', async () => {
+    let finishRestore;
+    mockRestoreBackup
+      .mockResolvedValueOnce({
+        dryRun: true,
+        snapshotId: '2026-08-25T11-00-00',
+        subdirFilter: 'brain',
+        changedFiles: ['brain/example.json'],
+      })
+      .mockReturnValueOnce(new Promise(resolve => { finishRestore = resolve; }));
+    renderWidget();
+
+    const filter = await openRestorePanel();
+    fireEvent.change(filter, { target: { value: ' brain ' } });
+    fireEvent.click(screen.getByRole('button', { name: 'Preview changes' }));
+
+    expect(await screen.findByText('brain/example.json')).toBeInTheDocument();
+    expect(mockRestoreBackup).toHaveBeenNthCalledWith(1, {
+      snapshotId: '2026-08-25T11-00-00',
+      subdirFilter: 'brain',
+      dryRun: true,
+    }, { silent: true });
+
+    fireEvent.click(screen.getByRole('button', { name: 'Restore 1 file(s)' }));
+    expect(mockRestoreBackup).toHaveBeenNthCalledWith(2, {
+      snapshotId: '2026-08-25T11-00-00',
+      subdirFilter: 'brain',
+      dryRun: false,
+    }, { silent: true });
+    expect(filter).toBeDisabled();
+    expect(screen.getByRole('button', { name: 'Preview changes' })).toBeDisabled();
+
+    await act(async () => {
+      finishRestore({ changedFiles: ['brain/example.json'] });
+    });
+    expect(mockToast.success).toHaveBeenCalledWith('Restore complete — 1 file(s) restored');
+  });
+
+  it('invalidates a selective preview when the filter is cleared', async () => {
+    mockRestoreBackup
+      .mockResolvedValueOnce({ changedFiles: ['brain/example.json'] })
+      .mockResolvedValueOnce({ changedFiles: ['brain/example.json', 'media/example.json'] })
+      .mockResolvedValueOnce({ changedFiles: ['brain/example.json', 'media/example.json'] });
+    renderWidget();
+
+    const filter = await openRestorePanel();
+    fireEvent.change(filter, { target: { value: 'brain' } });
+    fireEvent.click(screen.getByRole('button', { name: 'Preview changes' }));
+    expect(await screen.findByRole('button', { name: 'Restore 1 file(s)' })).toBeEnabled();
+
+    fireEvent.change(filter, { target: { value: '' } });
+    expect(screen.queryByText('brain/example.json')).not.toBeInTheDocument();
+    expect(screen.queryByRole('button', { name: /Restore \d+ file/ })).not.toBeInTheDocument();
+
+    fireEvent.click(screen.getByRole('button', { name: 'Preview changes' }));
+    expect(await screen.findByRole('button', { name: 'Restore 2 file(s)' })).toBeEnabled();
+    expect(mockRestoreBackup).toHaveBeenNthCalledWith(2, {
+      snapshotId: '2026-08-25T11-00-00',
+      subdirFilter: null,
+      dryRun: true,
+    }, { silent: true });
+
+    fireEvent.click(screen.getByRole('button', { name: 'Restore 2 file(s)' }));
+    await waitFor(() => expect(mockRestoreBackup).toHaveBeenNthCalledWith(3, {
+      snapshotId: '2026-08-25T11-00-00',
+      subdirFilter: null,
+      dryRun: false,
+    }, { silent: true }));
+  });
+
+  it('ignores a late preview response after the filter changes', async () => {
+    let finishPreview;
+    mockRestoreBackup.mockReturnValue(new Promise(resolve => { finishPreview = resolve; }));
+    renderWidget();
+
+    const filter = await openRestorePanel();
+    fireEvent.change(filter, { target: { value: 'brain' } });
+    fireEvent.click(screen.getByRole('button', { name: 'Preview changes' }));
+    fireEvent.change(filter, { target: { value: 'media' } });
+
+    await act(async () => {
+      finishPreview({ changedFiles: ['brain/example.json'] });
+    });
+    expect(screen.queryByText('brain/example.json')).not.toBeInTheDocument();
+    expect(screen.queryByRole('button', { name: /Restore \d+ file/ })).not.toBeInTheDocument();
+    expect(screen.getByRole('button', { name: 'Preview changes' })).toBeEnabled();
+  });
 });
 
 describe('BackupWidget manual backup', () => {

From 9d641edc0ae5e2fba374f249f25e56d96a1cbb00 Mon Sep 17 00:00:00 2001
From: "[._.]/ Adam Eivy" <atomantic@gmail.com>
Date: Wed, 9 Sep 2026 02:17:51 +0000
Subject: [PATCH 2/2] address review (claude): lock live restore controls

---
 client/src/components/BackupWidget.jsx      | 27 +++++++++++-------
 client/src/components/BackupWidget.test.jsx | 31 +++++++++++++++++++++
 2 files changed, 48 insertions(+), 10 deletions(-)

diff --git a/client/src/components/BackupWidget.jsx b/client/src/components/BackupWidget.jsx
index 6b00a6054a..f7e6f2288c 100644
--- a/client/src/components/BackupWidget.jsx
+++ b/client/src/components/BackupWidget.jsx
@@ -59,12 +59,11 @@ const HEALTH_STYLES = {
 // RestorePanel
 // ---------------------------------------------------------------------------
 
-function RestorePanel({ snapshot, onClose }) {
+function RestorePanel({ snapshot, onClose, restoring, onRestoreStateChange }) {
   const filterId = useId();
   const [filter, setFilter] = useState('');
   const [acceptedPreview, setAcceptedPreview] = useState(null);
   const [previewing, setPreviewing] = useState(false);
-  const [restoring, setRestoring] = useState(false);
   const previewGenerationRef = useRef(0);
 
   const currentRequest = {
@@ -111,7 +110,7 @@ function RestorePanel({ snapshot, onClose }) {
   const handleRestore = useCallback(async () => {
     if (!previewMatchesCurrentRequest || restoring) return;
 
-    setRestoring(true);
+    onRestoreStateChange(snapshot.id);
     const result = await api.restoreBackup({
       ...acceptedPreview.request,
       dryRun: false,
@@ -119,12 +118,12 @@ function RestorePanel({ snapshot, onClose }) {
       toast.error(`Restore failed: ${err.message}`);
       return null;
     });
-    setRestoring(false);
+    onRestoreStateChange(null);
     if (result) {
       toast.success(`Restore complete — ${result.changedFiles?.length ?? 0} file(s) restored`);
       onClose();
     }
-  }, [acceptedPreview, onClose, previewMatchesCurrentRequest, restoring]);
+  }, [acceptedPreview, onClose, onRestoreStateChange, previewMatchesCurrentRequest, restoring, snapshot.id]);
 
   const preview = previewMatchesCurrentRequest ? acceptedPreview.result : null;
 
@@ -136,7 +135,8 @@ function RestorePanel({ snapshot, onClose }) {
         </span>
         <button
           onClick={onClose}
-          className="text-gray-500 hover:text-gray-300 transition-colors text-xs min-h-[32px] px-1"
+          disabled={restoring}
+          className="text-gray-500 hover:text-gray-300 transition-colors text-xs min-h-[32px] px-1 disabled:opacity-50 disabled:cursor-not-allowed"
         >
           Cancel
         </button>
@@ -218,7 +218,7 @@ function RestorePanel({ snapshot, onClose }) {
 // SnapshotList
 // ---------------------------------------------------------------------------
 
-function SnapshotList() {
+function SnapshotList({ restoringSnapshotId, onRestoreStateChange }) {
   // Let errors throw — `useAutoRefetch` preserves the last-good data on
   // transient failures. A `.catch(() => null)` here would wipe the snapshot
   // list on every blip per the hook's documented gotcha.
@@ -285,7 +285,7 @@ function SnapshotList() {
               </button>
               <button
                 onClick={() => setSelectedId(selectedId === snap.id ? null : snap.id)}
-                disabled={snap.incomplete}
+                disabled={snap.incomplete || restoringSnapshotId !== null}
                 className="flex items-center gap-1 px-2 py-1 text-xs text-port-accent hover:text-port-accent/80 transition-colors disabled:opacity-50 disabled:cursor-not-allowed min-h-[32px]"
               >
                 <RotateCcw size={12} />
@@ -297,6 +297,8 @@ function SnapshotList() {
             <RestorePanel
               snapshot={snap}
               onClose={() => setSelectedId(null)}
+              restoring={restoringSnapshotId === snap.id}
+              onRestoreStateChange={onRestoreStateChange}
             />
           )}
         </div>
@@ -327,6 +329,7 @@ const BackupWidget = memo(function BackupWidget() {
   );
   const [handleBackupNow, triggering] = useBackupRun();
   const [snapshotsOpen, setSnapshotsOpen] = useState(false);
+  const [restoringSnapshotId, setRestoringSnapshotId] = useState(null);
   // Tick every minute so the dedup-skipped widget still recomputes
   // `relativeTime(lastRun/nextRun)` labels and the `computeHealth` 25h/49h
   // thresholds when wall-clock time crosses a boundary even though the poll
@@ -438,7 +441,8 @@ const BackupWidget = memo(function BackupWidget() {
         {/* Toggle snapshots */}
         <button
           onClick={() => setSnapshotsOpen(prev => !prev)}
-          className="flex items-center gap-1.5 px-3 py-2 bg-port-border/50 hover:bg-port-border text-gray-300 rounded-lg text-sm transition-colors min-h-[40px]"
+          disabled={restoringSnapshotId !== null}
+          className="flex items-center gap-1.5 px-3 py-2 bg-port-border/50 hover:bg-port-border text-gray-300 rounded-lg text-sm transition-colors disabled:opacity-50 disabled:cursor-not-allowed min-h-[40px]"
         >
           <ChevronDown
             size={14}
@@ -451,7 +455,10 @@ const BackupWidget = memo(function BackupWidget() {
       {/* Snapshots section */}
       {snapshotsOpen && (
         <div className="mt-4 pt-4 border-t border-port-border">
-          <SnapshotList />
+          <SnapshotList
+            restoringSnapshotId={restoringSnapshotId}
+            onRestoreStateChange={setRestoringSnapshotId}
+          />
         </div>
       )}
     </div>
diff --git a/client/src/components/BackupWidget.test.jsx b/client/src/components/BackupWidget.test.jsx
index 71bb7587b4..8379224fae 100644
--- a/client/src/components/BackupWidget.test.jsx
+++ b/client/src/components/BackupWidget.test.jsx
@@ -135,6 +135,9 @@ describe('BackupWidget snapshots', () => {
     }, { silent: true });
     expect(filter).toBeDisabled();
     expect(screen.getByRole('button', { name: 'Preview changes' })).toBeDisabled();
+    expect(screen.getByRole('button', { name: 'Cancel' })).toBeDisabled();
+    expect(screen.getByRole('button', { name: 'Restore' })).toBeDisabled();
+    expect(screen.getByRole('button', { name: 'Snapshots' })).toBeDisabled();
 
     await act(async () => {
       finishRestore({ changedFiles: ['brain/example.json'] });
@@ -191,6 +194,34 @@ describe('BackupWidget snapshots', () => {
     expect(screen.queryByRole('button', { name: /Restore \d+ file/ })).not.toBeInTheDocument();
     expect(screen.getByRole('button', { name: 'Preview changes' })).toBeEnabled();
   });
+
+  it('reports a current preview failure and re-enables previewing', async () => {
+    mockRestoreBackup.mockRejectedValueOnce(new Error('disk offline'));
+    renderWidget();
+
+    await openRestorePanel();
+    fireEvent.click(screen.getByRole('button', { name: 'Preview changes' }));
+
+    await waitFor(() => expect(mockToast.error).toHaveBeenCalledWith('Preview failed: disk offline'));
+    expect(screen.getByRole('button', { name: 'Preview changes' })).toBeEnabled();
+  });
+
+  it('suppresses a late preview failure after the filter changes', async () => {
+    let rejectPreview;
+    mockRestoreBackup.mockReturnValue(new Promise((_, reject) => { rejectPreview = reject; }));
+    renderWidget();
+
+    const filter = await openRestorePanel();
+    fireEvent.change(filter, { target: { value: 'brain' } });
+    fireEvent.click(screen.getByRole('button', { name: 'Preview changes' }));
+    fireEvent.change(filter, { target: { value: 'media' } });
+
+    await act(async () => {
+      rejectPreview(new Error('disk offline'));
+    });
+    expect(mockToast.error).not.toHaveBeenCalled();
+    expect(screen.getByRole('button', { name: 'Preview changes' })).toBeEnabled();
+  });
 });
 
 describe('BackupWidget manual backup', () => {