From 37ecb16e78874772f0e6cfb7baf292d78f3c17b6 Mon Sep 17 00:00:00 2001 From: Tamal Saha Date: Sat, 11 Jul 2026 17:56:12 +0600 Subject: [PATCH] Modernize golangci-lint config - Enable bodyclose and prealloc linters - Move exclude-files/exclude-dirs to linters.exclusions.paths (golangci-lint v2 location) and fix over-escaped regex generated.*\\.go -> generated.*\.go - Switch formatter from gofmt to gofumpt and drop the interface{} -> any rewrite rule (gofumpt is a stricter superset) - Apply resulting gofumpt formatting Signed-off-by: Tamal Saha --- .golangci.yml | 21 ++++++++------------- pkg/server/mail_deal_registration.go | 3 ++- pkg/server/mail_kubedb_inquiry.go | 3 ++- pkg/server/mail_kubedb_sales_qa.go | 3 ++- pkg/server/qa.go | 3 ++- pkg/server/server.go | 3 ++- 6 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index cdd2defc..1ebcfa46 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -2,27 +2,22 @@ version: "2" linters: default: standard enable: + - bodyclose + - prealloc - unparam + exclusions: + paths: + - generated.*\.go + - client + - vendor formatters: enable: - - gofmt + - gofumpt - goimports - settings: - gofmt: - rewrite-rules: - - pattern: 'interface{}' - replacement: 'any' issues: max-same-issues: 100 - exclude-files: - - generated.*\\.go - - exclude-dirs: - - client - - vendor - run: timeout: 10m diff --git a/pkg/server/mail_deal_registration.go b/pkg/server/mail_deal_registration.go index 723e6fe4..7fcb61ef 100644 --- a/pkg/server/mail_deal_registration.go +++ b/pkg/server/mail_deal_registration.go @@ -23,7 +23,8 @@ import ( ) func NewDealRegistrationMailer(info *DealRegistrationInfo) mailer.Mailer { - src := fmt.Sprintf(`Hi, + src := fmt.Sprintf( + `Hi, A new deal has been registered with the following details: ## Partner diff --git a/pkg/server/mail_kubedb_inquiry.go b/pkg/server/mail_kubedb_inquiry.go index d92cd366..3fedfc79 100644 --- a/pkg/server/mail_kubedb_inquiry.go +++ b/pkg/server/mail_kubedb_inquiry.go @@ -23,7 +23,8 @@ import ( ) func NewKubeDBInquiryMailer(info *KubeDBInquiryInfo) mailer.Mailer { - src := fmt.Sprintf(`Hi, + src := fmt.Sprintf( + `Hi, A new KubeDB inquiry has been submitted with the following details: ## Customer diff --git a/pkg/server/mail_kubedb_sales_qa.go b/pkg/server/mail_kubedb_sales_qa.go index 530ffed5..6e8d23a0 100644 --- a/pkg/server/mail_kubedb_sales_qa.go +++ b/pkg/server/mail_kubedb_sales_qa.go @@ -58,7 +58,8 @@ func NewKubeDBSalesQAMailer(info *KubeDBSalesQAInfo) mailer.Mailer { } } - src := fmt.Sprintf(`Hi, + src := fmt.Sprintf( + `Hi, A new KubeDB sales QA result has been submitted with the following details: ## Prospect diff --git a/pkg/server/qa.go b/pkg/server/qa.go index b0ef96c3..c8b47042 100644 --- a/pkg/server/qa.go +++ b/pkg/server/qa.go @@ -230,7 +230,8 @@ func (s *Server) startTest(c cache.Cache, ip string, configDocId, email string) } docId, err := gdrive.CopyDoc( - s.srvDrive, s.srvDoc, cfg.QuestionTemplateDocId, folderId, docName, replacements) + s.srvDrive, s.srvDoc, cfg.QuestionTemplateDocId, folderId, docName, replacements, + ) if err != nil { return err } diff --git a/pkg/server/server.go b/pkg/server/server.go index 83d3f3a8..7831ed60 100644 --- a/pkg/server/server.go +++ b/pkg/server/server.go @@ -428,7 +428,8 @@ func (s *Server) Run() error { if s.opts.EnableDripCampaign { go func() { - if err := mailer.RunCampaigns(context.TODO(), + if err := mailer.RunCampaigns( + context.TODO(), NewCommunitySignupCampaign(s.srvSheets, s.mg), NewEnterpriseSignupCampaign(s.srvSheets, s.mg), NewEnterpriseFirstTimeCampaign(s.srvSheets, s.mg),