Skip to content

Commit b23cb97

Browse files
committed
Cleaned up units code
1 parent 981e485 commit b23cb97

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

src/gcodeUnits.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,19 @@ import { ConfigurationChangeEvent, Disposable, TextDocumentChangeEvent, TextEdit
88
import { Control } from './control';
99
import { UtilCommands } from './util/commands/common';
1010
import { configuration } from './util/configuration/config';
11+
import { defaults } from './util/configuration/defaults';
1112
import { Logger } from './util/logger';
1213
import { StatusBar, StatusBarControl } from './util/statusBar';
1314

1415
export const enum GCodeUnits {
1516
Inch = 'Inch',
1617
MM = 'Metric',
1718
Auto = 'Auto',
18-
Default = 'Defautlt (Inch)',
19+
Default = 'Default (Inch)',
1920
}
2021

22+
const cfgUnits = 'general.units';
23+
2124
export class GCodeUnitsController implements Disposable {
2225
private readonly _disposable: Disposable | undefined;
2326
private _editor: TextEditor | undefined;
@@ -29,7 +32,7 @@ export class GCodeUnitsController implements Disposable {
2932
constructor() {
3033
this._statusbar = Control.statusBarController;
3134

32-
this._auto = (this._units = <GCodeUnits>configuration.getParam('general.units')) === GCodeUnits.Auto;
35+
this._auto = (this._units = configuration.getParam(cfgUnits) ?? defaults.general.units) === GCodeUnits.Auto;
3336

3437
this._statusbar.updateStatusBar(
3538
this._units,
@@ -49,8 +52,8 @@ export class GCodeUnitsController implements Disposable {
4952
}
5053

5154
private onConfigurationChanged(e: ConfigurationChangeEvent) {
52-
if (configuration.changed(e, 'general.units')) {
53-
if ((this._units = <GCodeUnits>configuration.getParam('general.units')) !== 'Auto') {
55+
if (configuration.changed(e, cfgUnits)) {
56+
if ((this._units = configuration.getParam(cfgUnits) ?? defaults.general.units) !== GCodeUnits.Auto) {
5457
Logger.log(`Units: ${this._units}`);
5558
this._auto = false;
5659
this._statusbar.updateStatusBar(

src/util/configuration/defaults.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
'use strict';
77

88
import { StatusBarAlignment } from 'vscode';
9+
import { GCodeUnits } from '../../gcodeUnits';
910
import { LineNumberFrequency } from '../lineNumberer';
1011
import { TraceLevel } from '../logger';
1112

@@ -22,7 +23,7 @@ interface GCodeConfiguration {
2223
alignment: StatusBarAlignment;
2324
};
2425

25-
units: 'Auto' | 'Inch' | 'Metric';
26+
units: GCodeUnits;
2627

2728
outputLevel: TraceLevel;
2829
};
@@ -61,7 +62,7 @@ export const defaults: GCodeConfiguration = {
6162
enabled: true,
6263
alignment: StatusBarAlignment.Left,
6364
},
64-
units: 'Auto',
65+
units: GCodeUnits.Auto,
6566
outputLevel: TraceLevel.Verbose,
6667
},
6768
lineNumberer: {

0 commit comments

Comments
 (0)