Generated ServiceMonitor scheme is not valid

[faandg]

Bug Report

What did you do?

Upgrade to 1.5.2 -> 1.6.2.
Apply RC with for example:

  monitoring:
    endpoints:
      - interval: 15s
        path: /some-path/actuator/prometheus
        port: management

After apply we see the following warning:

RC
saldochecker-uat
ServiceMonitor.monitoring.coreos.com "saldochecker-uat" is invalid: spec.endpoints[0].scheme: Unsupported value: "HTTPS": supported values: "http", "https"

The RC does not reconcile as the scheme of the ServiceMonitor only allows lower case value http/https.

What did you expect to see?

RC applied and reconciled with valid generated ServiceMonitor.

What did you see instead?

RC applied but not reconciled due to the scheme mismatch in ServiceMonitor.

Environment

OpenShift 4.20.24

Possible solution

Set correct scheme value (https instead of HTTPS) for the generated ServiceMonitor -> RC should then reconcile.

[TomVgw]

According to the OCP specs, scheme must be http or https, see https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/monitoring_apis/servicemonitor-monitoring-coreos-com-v1#spec-endpoints-2

Commit that changed the behaviour: b2aabc0#diff-0df82f8689d3e8d881be0653ab4e9f8221c5835ec95a14930d11669e9c7f07ef

@halim-lee Could you perhaps have a look at it?