From 5974bacd08d4d13ccc5700ace11b2ea53d344430 Mon Sep 17 00:00:00 2001 From: Daniel Alome Date: Tue, 27 Oct 2026 00:21:18 +0100 Subject: [PATCH] ADFA-6712: Say a full build is starting instead of asking for a tap When a change needs a full build, the session reducer emits RunProxyAppRebuild in the same transition, so the rebuild starts on its own. The status bar still said "Quick Build: tap again to rebuild" and Build Output said "Tap Quick Build to rebuild.", although a tap in that state only records the request. The status bar now reads "Quick Build: starting a full build..." (pt-BR updated to match) and Build Output ends with "Starting it now." QuickBuildOutputLinesTest asserted the old instruction; it now checks the new line and fails against the old one. --- .../itsaky/androidide/quickbuild/QuickBuildOutputLines.kt | 5 +---- .../androidide/quickbuild/QuickBuildOutputLinesTest.kt | 5 +++-- .../itsaky/androidide/quickbuild/QuickBuildStatusBarTest.kt | 2 +- resources/src/main/res/values-pt-rBR/strings.xml | 2 +- resources/src/main/res/values/strings.xml | 2 +- 5 files changed, 7 insertions(+), 9 deletions(-) diff --git a/app/src/main/java/com/itsaky/androidide/quickbuild/QuickBuildOutputLines.kt b/app/src/main/java/com/itsaky/androidide/quickbuild/QuickBuildOutputLines.kt index 5e73a46d98..3b8d9ef50a 100644 --- a/app/src/main/java/com/itsaky/androidide/quickbuild/QuickBuildOutputLines.kt +++ b/app/src/main/java/com/itsaky/androidide/quickbuild/QuickBuildOutputLines.kt @@ -83,10 +83,7 @@ fun quickBuildOutputLines( // of narrating upcoming work. listOf("the rebuild failed - save a fix to retry.") } else { - listOf( - "a full build is needed - ${describe(transition.reason)}. " + - "Tap Quick Build to rebuild.", - ) + listOf("a full build is needed - ${describe(transition.reason)}. Starting it now.") } } diff --git a/app/src/test/java/com/itsaky/androidide/quickbuild/QuickBuildOutputLinesTest.kt b/app/src/test/java/com/itsaky/androidide/quickbuild/QuickBuildOutputLinesTest.kt index 6d39ee6292..c39af803ad 100644 --- a/app/src/test/java/com/itsaky/androidide/quickbuild/QuickBuildOutputLinesTest.kt +++ b/app/src/test/java/com/itsaky/androidide/quickbuild/QuickBuildOutputLinesTest.kt @@ -251,7 +251,7 @@ class QuickBuildOutputLinesTest { } @Test - fun `invalidation reads as information and names a next step`() { + fun `invalidation reads as information and says the full build is starting`() { val emitted = lines( QuickBuildStatus.UpToDate(4L, buildDurationMillis = null), @@ -259,7 +259,8 @@ class QuickBuildOutputLinesTest { ).joinToString("") assertThat(emitted).contains("the manifest changed") - assertThat(emitted).contains("Tap Quick Build") + assertThat(emitted).contains("Starting it now") + assertThat(emitted).doesNotContain("Tap") // Not a failure - a full build is the normal answer to an unabsorbable edit. assertThat(emitted).doesNotContain("failed") } diff --git a/app/src/test/java/com/itsaky/androidide/quickbuild/QuickBuildStatusBarTest.kt b/app/src/test/java/com/itsaky/androidide/quickbuild/QuickBuildStatusBarTest.kt index 81a64d2a90..1bd4a2acc3 100644 --- a/app/src/test/java/com/itsaky/androidide/quickbuild/QuickBuildStatusBarTest.kt +++ b/app/src/test/java/com/itsaky/androidide/quickbuild/QuickBuildStatusBarTest.kt @@ -320,7 +320,7 @@ class QuickBuildStatusBarTest { } @Test - fun `an invalidation names the full-build ask`() { + fun `an invalidation says the full build is starting`() { val shown = update( QuickBuildStatus.UpToDate(4L, null), diff --git a/resources/src/main/res/values-pt-rBR/strings.xml b/resources/src/main/res/values-pt-rBR/strings.xml index 9583e1bb2e..e63c4edbe2 100644 --- a/resources/src/main/res/values-pt-rBR/strings.xml +++ b/resources/src/main/res/values-pt-rBR/strings.xml @@ -1061,7 +1061,7 @@ A Compilação rápida falhou; veja a Saída da compilação Compilação rápida: falha na entrega; veja a Saída da compilação Compilação rápida: compilado; toque para iniciar o aplicativo - Compilação rápida: toque novamente para recompilar + Compilação rápida: iniciando uma compilação completa… A Compilação rápida falhou; veja a Saída da compilação Compilação rápida: falha na configuração; toque para tentar novamente A Compilação rápida falhou. Consulte o painel Saída da compilação para mais detalhes. diff --git a/resources/src/main/res/values/strings.xml b/resources/src/main/res/values/strings.xml index 4d9ebea983..7e02da3138 100644 --- a/resources/src/main/res/values/strings.xml +++ b/resources/src/main/res/values/strings.xml @@ -1195,7 +1195,7 @@ Quick Build failed - see Build Output Quick Build: delivery failed - see Build Output Quick Build: built - tap to start app - Quick Build: tap again to rebuild + Quick Build: starting a full build… Quick Build failed - see Build Output Quick Build: setup failed - tap to retry Quick Build failed. See the Build Output panel for more details.