Input DTOs are not being passed through the name converter

[mbeccati]

API Platform version(s) affected: 4.2.x-dev (since #7691)

Description
API platform isn't using the name converter on input DTOs

How to reproduce
Set name converter according to the documentation in api_platform.yaml
Run test suite

Additional Context
Manually setting the name converter also on the symfony side (framework.yaml) fixes the issue, so it seems that decoding the input JSON is happening via the default Symfony serializer, whose name converter is not automatically configured any more.

api_platform:
    name_converter: 'serializer.name_converter.camel_case_to_snake_case'

framework:
    serializer:
#        name_converter: 'serializer.name_converter.camel_case_to_snake_case'

        named_serializers:
            foo:
                name_converter: null
                default_context:
                    skip_null_values: true

[VincentLanglet]

Thanks @mbeccati for the report. (cc @soyuka, I think this is a blocker for a release or will need the revert of the previous bugfix)

When looking at some ApiPlatform Normalizer, the name converter seems correctly injected

core/src/Symfony/Bundle/Resources/config/api.php

Line 91 in fa3b696

service('api_platform.name_converter')->ignoreOnInvalid(),

But on the other side, seems like some of other Normalizer are just decorator of Symfony one

core/src/Symfony/Bundle/Resources/config/jsonapi.php

Line 70 in fa3b696

service('serializer.normalizer.object'),

so I wonder if in such case it rely on the default serializer and then the default name converter maybe ?

If so, the following occurences 'serializer.normalizer. should maybe be updated (?)
https://github.com/search?q=repo%3Aapi-platform%2Fcore%20%27serializer.normalizer.&type=code

• defining an dedicated ObjectSerializer similar to the symfony definition

        ->set('api_platform.normalizer.object', ObjectNormalizer::class)
            ->args([
                service('serializer.mapping.class_metadata_factory'),
                service('serializer.name_converter.metadata_aware'),
                service('serializer.property_accessor'),
                service('property_info')->ignoreOnInvalid(),
                service('serializer.mapping.class_discriminator_resolver')->ignoreOnInvalid(),
                null,
                abstract_arg('default context, set in the SerializerPass'),
                service('property_info')->ignoreOnInvalid(),
            ])
            ->tag('serializer.normalizer', ['built_in' => true, 'priority' => -1000])

but with the Api platform service instead

• then decorating 'api_platform.normalizer.object' instead of 'serializer.normalizer.object'

But I dunno if it's the issue, and I'm also unaware about the impact...

[soyuka]

This would be the right fix imo! Not sure when I'll be able to do that but I'll try to fix this before releasing the patch.

[soyuka]

Could you give a shot at #7717 ?

[mbeccati]

@soyuka I've finally been able to test again with latest 4.2. Test suite still fails badly, unless I configure the name serializer in both AP and SF, which makes no sense to me.

[saulius-cepauskas-vg]

Is anyone looking after this? Have exactly same issue - AP and SF both needs to be configured. v4.2.15

[mbeccati]

Luckily I knew how to solve the issue when a composr update brought my project to 4.2.15.

[soyuka]

Is there still an issue with this @mbeccati ?

[mbeccati]

Yes, the very same issue I reported is in 4.2.15