diff --git a/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/cache/JmhPageEvictionBenchmark.java b/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/cache/JmhPageEvictionBenchmark.java
new file mode 100644
index 0000000000000..29145f07d4ea5
--- /dev/null
+++ b/modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/cache/JmhPageEvictionBenchmark.java
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.benchmarks.jmh.cache;
+
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.IgniteDataStreamer;
+import org.apache.ignite.Ignition;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.DataPageEvictionMode;
+import org.apache.ignite.configuration.DataRegionConfiguration;
+import org.apache.ignite.configuration.DataStorageConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.benchmarks.jmh.runner.JmhIdeBenchmarkRunner;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Param;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.TearDown;
+import org.openjdk.jmh.annotations.Threads;
+import org.openjdk.jmh.annotations.Warmup;
+
+/**
+ * Measures the impact of size-aware page eviction on an in-memory (non-persistent) data region.
+ *
+ * Two benchmark methods:
+ *
+ *
{@link #putSmall()} - puts of small values (well below the empty-pages pool, so the size-aware reserve
+ * in {@code RowStore.addRow} hits its fast path) within a bounded key range that keeps the region below the
+ * eviction threshold. This is the hot path whose per-operation cost the patch adds on every put, and is the
+ * primary A/B metric for detecting a performance regression between the unpatched baseline and this branch.
+ *
{@link #putLarge()} - puts of large values (larger than the empty-pages pool) against a region that has
+ * been pre-filled to near capacity, so that each large put must actually run the size-aware eviction loop.
+ * This exercises the new eviction behavior; on an unpatched build such a put fails with an out-of-memory
+ * error, so this benchmark only runs meaningfully on the patched build.
+ *
+ */
+@State(Scope.Benchmark)
+@Fork(1)
+@Threads(4)
+@BenchmarkMode(Mode.Throughput)
+@OutputTimeUnit(TimeUnit.MILLISECONDS)
+@Warmup(iterations = 3, time = 5)
+@Measurement(iterations = 5, time = 10)
+public class JmhPageEvictionBenchmark {
+ /** Default cache name. */
+ private static final String CACHE_NAME = "default";
+
+ /** Empty pages pool size (kept low so that the LARGE scenario reliably exceeds it). */
+ private static final int POOL_SIZE = 100;
+
+ /** Small value size (bytes): a single data page, far below the empty-pages pool. */
+ private static final int SMALL_VALUE_SIZE = 1024;
+
+ /** Large value size (bytes): larger than the empty-pages pool in page terms. */
+ private static final int LARGE_VALUE_SIZE = 2 * 1024 * 1024;
+
+ /**
+ * Number of pre-fill small entries for the LARGE scenario. Chosen so that the total written data
+ * (400k x 1 KiB) far exceeds the region capacity: threshold eviction then pins the region at the eviction
+ * threshold (default ~90% of {@code maxSize}), leaving the free list with only its empty-pages pool. At that
+ * point a {@link #LARGE_VALUE_SIZE} put cannot take the fast path and must actually run the size-aware eviction
+ * loop. (A modest pre-fill such as 48k x 1 KiB would leave the region only ~19% full and let every large put
+ * fit into the headroom via the fast path, so it would never exercise the code under measurement.)
+ */
+ private static final int PRE_FILL_ENTRIES = 400_000;
+
+ /**
+ * Bounded key range for {@link #putSmall()}. Each {@link #SMALL_VALUE_SIZE} value occupies one data page, so a
+ * working set of this many resident keys (~32k x 4 KiB ~ 128 MiB) stays comfortably below the eviction
+ * threshold (~90% of the 256 MiB region). Overwriting within this bounded range (instead of append-style fresh
+ * keys) keeps the region from filling up and drifting into steady-state threshold eviction during measurement,
+ * so the run isolates the per-put cost of the size-aware-reserve fast path.
+ */
+ private static final int SMALL_KEY_RANGE = 32_000;
+
+ /** Benchmark scenario: selects the value size and the pre-fill strategy. */
+ @Param({"SMALL", "LARGE"})
+ private String scenario;
+
+ /** Ignite cache. */
+ private IgniteCache cache;
+
+ /** Pre-allocated small value (reused to avoid allocation noise in the hot path). */
+ private final byte[] smallVal = new byte[SMALL_VALUE_SIZE];
+
+ /** Pre-allocated large value (reused to avoid allocation noise in the hot path). */
+ private final byte[] largeVal = new byte[LARGE_VALUE_SIZE];
+
+ /** Monotonic key source: bounded (mod {@link #SMALL_KEY_RANGE}) for {@link #putSmall()} to keep the region below
+ * the eviction threshold, and unbounded (append-style) for {@link #putLarge()} to avoid overwriting entries. */
+ private final AtomicInteger keyGen = new AtomicInteger();
+
+ /** Page eviction mode used for the data region. */
+ @Param("RANDOM_LRU")
+ private String evictionMode;
+
+ /** Put of a small value (hot path, size-aware reserve takes its fast path). Keys are wrapped within a bounded
+ * range ({@link #SMALL_KEY_RANGE}) so the resident working set stays below the eviction threshold and the run
+ * isolates the fast-path cost instead of drifting into steady-state threshold eviction. */
+ @Benchmark
+ public void putSmall() {
+ int key = keyGen.incrementAndGet() % SMALL_KEY_RANGE;
+
+ cache.put(key, smallVal);
+ }
+
+ /**
+ * Put of a large value against a nearly-full region (runs the size-aware eviction loop).
+ *
+ * Pinned to a single thread: the size-aware reserve accumulates {@code requiredPages} real empty pages
+ * in the shared free list before writing, and with multiple concurrent writers those free pages are consumed
+ * by rivals as fast as they are freed, so no thread ever accumulates enough and the loop exhausts its
+ * no-progress budget into an out-of-memory. At one thread the free-page count grows monotonically and the
+ * reserve completes, measuring the honest per-put cost of eviction.
+ */
+ @Benchmark
+ @Threads(1)
+ public void putLarge() {
+ int key = keyGen.incrementAndGet();
+
+ cache.put(key, largeVal);
+ }
+
+ /** Starts Ignite with an in-memory, eviction-enabled data region and pre-fills it for the LARGE scenario. */
+ @Setup(Level.Trial)
+ public void setup() {
+ long regionSize = 256 * 1024L * 1024L;
+
+ DataStorageConfiguration dsCfg = new DataStorageConfiguration()
+ .setDefaultDataRegionConfiguration(new DataRegionConfiguration()
+ .setPersistenceEnabled(false)
+ .setMaxSize(regionSize)
+ .setEmptyPagesPoolSize(POOL_SIZE)
+ .setPageEvictionMode(DataPageEvictionMode.valueOf(evictionMode)));
+
+ IgniteConfiguration cfg = new IgniteConfiguration()
+ .setIgniteInstanceName("test")
+ .setLocalHost("127.0.0.1")
+ .setDataStorageConfiguration(dsCfg);
+
+ Ignite ignite = Ignition.start(cfg);
+
+ cache = ignite.getOrCreateCache(new CacheConfiguration(CACHE_NAME).setBackups(0));
+
+ // Pre-fill the region with small entries for the LARGE scenario until threshold eviction pins it at the
+ // eviction threshold, so that a large put has no headroom to grow into and must actually evict.
+ if ("LARGE".equalsIgnoreCase(scenario)) {
+ try (IgniteDataStreamer ldr = ignite.dataStreamer(CACHE_NAME)) {
+ ldr.perNodeBufferSize(1024);
+
+ for (int i = 0; i < PRE_FILL_ENTRIES; i++)
+ ldr.addData(i, smallVal);
+ }
+
+ // The pre-fill consumed keys [0, PRE_FILL_ENTRIES). Start large puts after that range so they write
+ // brand-new keys (true append), leaving the pre-filled small entries in place to be the eviction
+ // candidates, instead of overwriting them in place.
+ keyGen.set(PRE_FILL_ENTRIES);
+ }
+ }
+
+ /** @return Test data. */
+ @Override public String toString() {
+ return "JmhPageEvictionBenchmark[scenario=" + scenario + ", evictionMode=" + evictionMode + ']';
+ }
+
+ /** Stops all Ignite instances started by this benchmark. */
+ @TearDown
+ public void tearDown() {
+ Ignition.stopAll(true);
+ }
+
+ /**
+ * Runs this benchmark over both {@code SMALL} and {@code LARGE} scenarios (configured by {@code @Param}).
+ *
+ * @param args Ignored.
+ * @throws Exception If failed.
+ */
+ public static void main(String[] args) throws Exception {
+ JmhIdeBenchmarkRunner.create()
+ .benchmarks(JmhPageEvictionBenchmark.class.getSimpleName())
+ .run();
+ }
+}
diff --git a/modules/core/src/main/java/org/apache/ignite/configuration/DataRegionConfiguration.java b/modules/core/src/main/java/org/apache/ignite/configuration/DataRegionConfiguration.java
index 1293ed7989486..9666295a5203b 100644
--- a/modules/core/src/main/java/org/apache/ignite/configuration/DataRegionConfiguration.java
+++ b/modules/core/src/main/java/org/apache/ignite/configuration/DataRegionConfiguration.java
@@ -18,7 +18,6 @@
import java.io.Serializable;
import org.apache.ignite.DataRegionMetrics;
-import org.apache.ignite.internal.mem.IgniteOutOfMemoryException;
import org.apache.ignite.internal.util.typedef.internal.S;
import org.apache.ignite.mem.MemoryAllocator;
import org.apache.ignite.mxbean.MetricsMxBean;
@@ -346,9 +345,9 @@ public DataRegionConfiguration setEvictionThreshold(double evictionThreshold) {
* Specifies the minimal number of empty pages to be present in reuse lists for this data region.
* This parameter ensures that Ignite will be able to successfully evict old data entries when the size of
* (key, value) pair is slightly larger than page size / 2.
- * Increase this parameter if cache can contain very big entries (total size of pages in this pool should be enough
- * to contain largest cache entry).
- * Increase this parameter if {@link IgniteOutOfMemoryException} occurred with enabled page eviction.
+ * Since size-aware eviction automatically frees additional pages when the inserted row is larger than this pool,
+ * it is no longer required to increase this parameter up to the size of the largest cache entry;
+ * it may be kept at its default as the steady-state reserve of empty pages.
*
* @return Minimum number of empty pages in reuse list.
*/
@@ -360,9 +359,9 @@ public int getEmptyPagesPoolSize() {
* Specifies the minimal number of empty pages to be present in reuse lists for this data region.
* This parameter ensures that Ignite will be able to successfully evict old data entries when the size of
* (key, value) pair is slightly larger than page size / 2.
- * Increase this parameter if cache can contain very big entries (total size of pages in this pool should be enough
- * to contain largest cache entry).
- * Increase this parameter if {@link IgniteOutOfMemoryException} occurred with enabled page eviction.
+ * Since size-aware eviction automatically frees additional pages when the inserted row is larger than this pool,
+ * it is no longer required to increase this parameter up to the size of the largest cache entry;
+ * it may be kept at its default as the steady-state reserve of empty pages.
*
* @param emptyPagesPoolSize Empty pages pool size.
* @return {@code this} for chaining.
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheEntryEx.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheEntryEx.java
index bda9d3fbdc198..c0885b7803898 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheEntryEx.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheEntryEx.java
@@ -201,6 +201,30 @@ public interface GridCacheEntryEx {
public boolean evictInternal(GridCacheVersion obsoleteVer, @Nullable CacheEntryPredicate[] filter,
boolean evictOffheap) throws IgniteCheckedException;
+ /**
+ * Same as {@link #evictInternal(GridCacheVersion, CacheEntryPredicate[], boolean)}, but when {@code tryLock} is
+ * {@code true} the entry lock is acquired non-blockingly: the entry is skipped (this method returns {@code false})
+ * whenever its lock is contended or already held by the current thread (the self-hold case), instead of blocking.
+ * Used by size-aware page eviction which may run while the current thread already holds other entry locks, to
+ * avoid a lock-ordering deadlock. The default implementation ignores {@code tryLock} and uses the blocking
+ * variant.
+ *
+ * @param obsoleteVer Version for eviction.
+ * @param filter Optional filter.
+ * @param evictOffheap Evict offheap value flag.
+ * @param tryLock {@code true} to acquire the entry lock non-blockingly (skip contended or self-held entries).
+ * @return {@code True} if entry could be evicted.
+ * @throws IgniteCheckedException In case of error.
+ */
+ default boolean evictInternal(
+ GridCacheVersion obsoleteVer,
+ @Nullable CacheEntryPredicate[] filter,
+ boolean evictOffheap,
+ boolean tryLock
+ ) throws IgniteCheckedException {
+ return evictInternal(obsoleteVer, filter, evictOffheap);
+ }
+
/**
* This method should be called each time entry is marked obsolete
* other than by calling {@link #markObsolete(GridCacheVersion)}.
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java
index 021fdd0408d48..93bc2aacc303e 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java
@@ -3658,7 +3658,11 @@ protected void removeValue() throws IgniteCheckedException {
* Evicts necessary number of data pages if per-page eviction is configured in current {@link DataRegion}.
*/
private void ensureFreeSpace() throws IgniteCheckedException {
- // Deadlock alert: evicting data page causes removing (and locking) all entries on the page one by one.
+ // Deadlock alert: evicting a data page removes (and locks) all entries on the page one by one, so this
+ // entry-level eviction must only run while NOT holding this entry's lock (all call sites run before
+ // lockEntry()). The separate size-aware path (RowStore.addRow ->
+ // IgniteCacheDatabaseSharedManager#ensureFreeSpaceForInsert) runs under the lock and instead relies on
+ // the non-blocking tryLockEntry(0) inside evictInternal to avoid a lock-ordering deadlock.
assert !lock.isHeldByCurrentThread();
cctx.shared().database().ensureFreeSpace(cctx.dataRegion());
@@ -3687,11 +3691,26 @@ private CacheEntryImplEx wrapVersionedWithValue() {
boolean evictOffheap)
throws IgniteCheckedException {
+ return evictInternal(obsoleteVer, filter, evictOffheap, false);
+ }
+
+ /** {@inheritDoc} */
+ @Override public boolean evictInternal(
+ GridCacheVersion obsoleteVer,
+ @Nullable CacheEntryPredicate[] filter,
+ boolean evictOffheap,
+ boolean tryLock
+ ) throws IgniteCheckedException {
boolean marked = false;
try {
if (F.isEmptyOrNulls(filter)) {
- lockEntry();
+ // With tryLock=true (size-aware eviction running while the current thread already holds entry locks)
+ // the lock is taken non-blockingly and a contended entry is skipped (returns false) to avoid a
+ // lock-ordering deadlock; the tracker then picks another page. All other paths (tryLock=false) keep
+ // the original blocking lockEntry().
+ if (!lockEntry(tryLock))
+ return false;
try {
if (evictionDisabled()) {
@@ -3728,7 +3747,8 @@ private CacheEntryImplEx wrapVersionedWithValue() {
while (true) {
GridCacheVersion v;
- lockEntry();
+ if (!lockEntry(tryLock))
+ return false;
try {
v = ver;
@@ -3740,7 +3760,8 @@ private CacheEntryImplEx wrapVersionedWithValue() {
if (!cctx.isAll(/*version needed for sync evicts*/this, filter))
return false;
- lockEntry();
+ if (!lockEntry(tryLock))
+ return false;
try {
if (evictionDisabled()) {
@@ -4182,6 +4203,23 @@ private int extrasSize() {
lock.lock();
}
+ /**
+ * Acquires the entry lock either blocking ({@code tryLock == false}) or non-blockingly with an immediate
+ * {@code tryLock(0)} ({@code tryLock == true}). Used by {@link #evictInternal} to let size-aware
+ * eviction skip contended entries instead of blocking, avoiding a lock-ordering deadlock.
+ *
+ * @param tryLock {@code true} to acquire the lock non-blockingly.
+ * @return {@code true} if the lock was acquired (always {@code true} when {@code tryLock == false}).
+ */
+ private boolean lockEntry(boolean tryLock) {
+ if (tryLock)
+ return !lock.isHeldByCurrentThread() && tryLockEntry(0);
+
+ lockEntry();
+
+ return true;
+ }
+
/** {@inheritDoc} */
@Override public boolean tryLockEntry(long timeout) {
try {
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/IgniteCacheDatabaseSharedManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/IgniteCacheDatabaseSharedManager.java
index b22a6682957c4..d3e057992116a 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/IgniteCacheDatabaseSharedManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/IgniteCacheDatabaseSharedManager.java
@@ -26,6 +26,8 @@
import java.util.Map;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.locks.LockSupport;
import java.util.function.Function;
import java.util.function.Supplier;
import java.util.stream.Collectors;
@@ -63,6 +65,7 @@
import org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointProgress;
import org.apache.ignite.internal.processors.cache.persistence.evict.FairFifoPageEvictionTracker;
import org.apache.ignite.internal.processors.cache.persistence.evict.NoOpPageEvictionTracker;
+import org.apache.ignite.internal.processors.cache.persistence.evict.PageAbstractEvictionTracker;
import org.apache.ignite.internal.processors.cache.persistence.evict.PageEvictionTracker;
import org.apache.ignite.internal.processors.cache.persistence.evict.Random2LruPageEvictionTracker;
import org.apache.ignite.internal.processors.cache.persistence.evict.RandomLruPageEvictionTracker;
@@ -74,6 +77,7 @@
import org.apache.ignite.internal.processors.cache.persistence.metastorage.MetaStorage;
import org.apache.ignite.internal.processors.cache.persistence.metastorage.MetastorageLifecycleListener;
import org.apache.ignite.internal.processors.cache.persistence.pagemem.PageReadWriteManager;
+import org.apache.ignite.internal.processors.cache.persistence.tree.io.AbstractDataPageIO;
import org.apache.ignite.internal.processors.cache.persistence.tree.reuse.ReuseList;
import org.apache.ignite.internal.processors.cache.persistence.wal.WALPointer;
import org.apache.ignite.internal.processors.cache.warmup.WarmUpStrategy;
@@ -137,6 +141,26 @@ public class IgniteCacheDatabaseSharedManager extends GridCacheSharedManagerAdap
/** Maximum initial size on 32-bit JVM */
private static final long MAX_PAGE_MEMORY_INIT_SIZE_32_BIT = 2L * 1024 * 1024 * 1024;
+ /** Initial backoff (nanoseconds) between consecutive no-progress eviction attempts. */
+ private static final long EVICTION_BACKOFF_START_NANOS = 50_000L;
+
+ /** Upper bound (nanoseconds) for the backoff between no-progress eviction attempts. */
+ private static final long EVICTION_BACKOFF_MAX_NANOS = 1_000_000L;
+
+ /**
+ * Maximum time (milliseconds) the size-aware eviction guard is willing to wait without establishing a new
+ * highest number of empty pages before failing with an out-of-memory. Being time-based (measured from the last
+ * progress) rather than a fixed attempt count means a slow-but-progressing eviction is never torn down, while a
+ * genuinely stuck eviction (nothing evictable, or contenders that never release their locks) still terminates in
+ * bounded time instead of busy-spinning forever.
+ *
+ * This value also caps the worst-case time the size-aware reserve can hold the caller's entry lock: on the
+ * single-row path the eviction loop runs while the entry being written is locked, so in the pathological case
+ * (region under pressure and every evictable entry locked by a long-running transaction) a put can hold the
+ * entry lock for up to this duration before failing with an out-of-memory.
+ */
+ private static final long EVICTION_NO_PROGRESS_TIMEOUT_MILLIS = 1_000L;
+
/** {@code True} to reuse memory on deactive. */
protected final boolean reuseMemory = IgniteSystemProperties.getBoolean(IGNITE_REUSE_MEMORY_ON_DEACTIVATE);
@@ -1172,32 +1196,62 @@ public WALPointer latestWalPointerReservedForPreloading() {
}
/**
- * Checks that the given {@code region} has enough space for putting a new entry.
- *
- * This method makes sense then and only then
- * the data region is not persisted {@link DataRegionConfiguration#isPersistenceEnabled()}
- * and page eviction is disabled {@link DataPageEvictionMode#DISABLED}.
- *
- * The non-persistent region should reserve a number of pages to support a free list {@link AbstractFreeList}.
- * For example, removing a row from underlying store may require allocating a new data page
- * in order to move a tracked page from one bucket to another one which does not have a free space for a new stripe.
- * See {@link AbstractFreeList#removeDataRowByLink}.
- * Therefore, inserting a new entry should be prevented in case of some threshold is exceeded.
+ * Checks that the given {@code region} has enough space for putting a new entry of {@code dataRowSize} bytes.
+ *
+ * For a non-persistent region with page eviction disabled, verifies that the region reserves enough pages to
+ * support a free list {@link AbstractFreeList}. For example, removing a row from underlying store may require
+ * allocating a new data page in order to move a tracked page from one bucket to another one which does not have
+ * a free space for a new stripe. See {@link AbstractFreeList#removeDataRowByLink}. Therefore, inserting a new
+ * entry should be prevented in case of some threshold is exceeded.
+ *
+ * For a non-persistent region with page eviction enabled, additionally performs size-aware eviction: when the
+ * row does not fit into the currently available page space, data pages are evicted until either enough space is
+ * freed or it becomes clear that the goal is unreachable (in which case an
+ * {@link IgniteOutOfMemoryException} is thrown).
+ *
+ * The size-aware reserve is required because page eviction by itself only keeps a steady-state pool of empty pages
+ * ({@link DataRegionConfiguration#getEmptyPagesPoolSize()}) and does not guarantee enough space for a single row
+ * larger than this pool.
+ *
+ * Worst case: when called while the entry being written is locked (single-row insertion), the eviction loop can
+ * hold that lock for up to {@link #EVICTION_NO_PROGRESS_TIMEOUT_MILLIS} — only if no evictable entry releases
+ * its lock within that time (e.g. a long-running transaction holding all evictable entries), after which the
+ * call fails with {@link IgniteOutOfMemoryException} (reported as a critical failure to the configured failure
+ * handler).
*
* @param region Data region to be checked.
* @param dataRowSize Size of data row to be inserted.
- * @throws IgniteOutOfMemoryException In case of the given data region does not have enough free space
- * for putting a new entry.
+ * @throws IgniteOutOfMemoryException In case the given data region does not have enough free space
+ * for putting a new entry, even after eviction.
+ * @throws IgniteCheckedException If failed to evict data pages.
*/
- public void ensureFreeSpaceForInsert(DataRegion region, int dataRowSize) throws IgniteOutOfMemoryException {
+ public void ensureFreeSpaceForInsert(DataRegion region, int dataRowSize)
+ throws IgniteOutOfMemoryException, IgniteCheckedException {
if (region == null)
return;
DataRegionConfiguration regCfg = region.config();
- if (regCfg.getPageEvictionMode() != DataPageEvictionMode.DISABLED || regCfg.isPersistenceEnabled())
+ if (regCfg.isPersistenceEnabled())
return;
+ if (regCfg.getPageEvictionMode() == DataPageEvictionMode.DISABLED)
+ checkOomThreshold(region, regCfg, dataRowSize);
+ else
+ ensureFreeSpaceForEviction(region, regCfg, dataRowSize);
+ }
+
+ /**
+ * Checks that a non-persistent region with disabled page eviction has enough pages for a new row, taking into
+ * account the pages required to support the free list.
+ *
+ * @param region Data region.
+ * @param regCfg Data region configuration.
+ * @param dataRowSize Size of data row to be inserted.
+ * @throws IgniteOutOfMemoryException If the region does not have enough free space for the new entry.
+ */
+ private void checkOomThreshold(DataRegion region, DataRegionConfiguration regCfg, int dataRowSize)
+ throws IgniteOutOfMemoryException {
long memorySize = regCfg.getMaxSize();
PageMemory pageMem = region.pageMemory();
@@ -1216,24 +1270,170 @@ public void ensureFreeSpaceForInsert(DataRegion region, int dataRowSize) throws
boolean oomThreshold = (memorySize / pageMem.systemPageSize()) <
((double)dataRowSize / pageMem.pageSize() + nonEmptyPages * (8.0 * 1.5 / pageMem.pageSize() + 1) + 256 /*one page per bucket*/);
- if (oomThreshold) {
- IgniteOutOfMemoryException oom = new IgniteOutOfMemoryException("Out of memory in data region [" +
- "name=" + regCfg.getName() +
- ", initSize=" + U.readableSize(regCfg.getInitialSize(), false) +
- ", maxSize=" + U.readableSize(regCfg.getMaxSize(), false) +
- ", persistenceEnabled=" + regCfg.isPersistenceEnabled() + "] Try the following:" + U.nl() +
- " ^-- Increase maximum off-heap memory size (DataRegionConfiguration.maxSize)" + U.nl() +
- " ^-- Enable Ignite persistence (DataRegionConfiguration.persistenceEnabled)" + U.nl() +
- " ^-- Enable eviction or expiration policies"
- );
+ if (oomThreshold)
+ throw outOfMemory(regCfg);
+ }
+
+ /**
+ * Size-aware reserve for an eviction-enabled non-persistent region. Runs eviction until the free list holds
+ * enough real empty pages to accommodate the row, or throws {@link IgniteOutOfMemoryException} if the goal is
+ * unreachable / no progress can be made. Progress is measured against the number of empty pages in the free list
+ * (the only resource a subsequent fragmented write can reliably consume once the region is effectively full); the
+ * region's spare capacity (headroom) is only trusted in the fast path while the region is below the eviction
+ * threshold.
+ *
+ * @param region Data region.
+ * @param regCfg Data region configuration.
+ * @param dataRowSize Size of data row to be inserted.
+ * @throws IgniteOutOfMemoryException If the target cannot be reached (row too large for the region or eviction
+ * makes no progress).
+ * @throws IgniteCheckedException If failed to evict data pages.
+ */
+ private void ensureFreeSpaceForEviction(DataRegion region, DataRegionConfiguration regCfg, int dataRowSize)
+ throws IgniteOutOfMemoryException, IgniteCheckedException {
+ PageMemory pageMem = region.pageMemory();
+
+ long pageSize = pageMem.pageSize();
+
+ // Maximum payload bytes that a single data page can hold for a fragmented row.
+ long pagePayload = pageSize - AbstractDataPageIO.MIN_DATA_PAGE_OVERHEAD;
+
+ // A row that fits into the steady-state empty-pages pool is satisfied by normal threshold eviction, so the
+ // fast path is a single comparison (no page computation, free-list lookup or page-memory reads on the hot
+ // small-put path).
+ long maxFastRowBytes = regCfg.getEmptyPagesPoolSize() * pagePayload;
+
+ if (dataRowSize <= maxFastRowBytes)
+ return;
+
+ CacheFreeList freeList = freeListMap.get(regCfg.getName());
+
+ if (freeList == null)
+ return;
+
+ long totalPages = regCfg.getMaxSize() / pageMem.systemPageSize();
- if (cctx.kernalContext() != null)
- cctx.kernalContext().failure().process(new FailureContext(FailureType.CRITICAL_ERROR, oom));
+ // Pages the row will actually occupy once written, and which the free list must hand out on demand during
+ // the fragmented write.
+ long requiredPages = (dataRowSize + pagePayload - 1) / pagePayload;
- throw oom;
+ // The row fundamentally cannot fit into the whole region.
+ if (requiredPages > totalPages)
+ throw outOfMemory(regCfg);
+
+ // The reserve must guarantee that the free list holds `requiredPages` REAL empty pages, not merely that the
+ // region has apparent headroom. Apparent headroom (totalPages - loadedPages) is shared and non-exclusive:
+ // concurrent inserts can both count on it and then both run out of pages mid-write (TOCTOU / raw OOM), since
+ // a fresh allocation cannot grow the region beyond capacity. Once the region is effectively full, real empty
+ // pages already in the free list are the only resource the fragmented write can reliably consume, so the loop
+ // below accumulates them. (Headroom is trusted in the fast path only while the region is below the eviction
+ // threshold, i.e. where contention cannot exhaust the slack.)
+ long emptyPages = freeList.emptyDataPages();
+
+ long headroom = totalPages - pageMem.loadedPages();
+
+ // The region is "under pressure" once loaded pages reach the eviction threshold; below it a fresh allocation
+ // can safely grow the region, so a row that fits into the combined spare space is satisfied without eviction
+ // (which would otherwise destroy evictable, e.g. short-TTL, entries just to accumulate empty pages the slack
+ // could have absorbed).
+ long pagesThreshold = (long)(totalPages * regCfg.getEvictionThreshold());
+
+ boolean underPressure = pageMem.loadedPages() >= pagesThreshold;
+
+ // Fast path: the row is satisfiable without eviction when (a) the free list already holds enough real empty
+ // pages, or (b) the region is not under pressure and has enough spare space to grow into.
+ if (emptyPages >= requiredPages || (!underPressure && emptyPages + headroom >= requiredPages))
+ return;
+
+ PageEvictionTracker evictionTracker = region.evictionTracker();
+
+ // Evict data pages until the free list holds enough real empty pages. Progress is measured against the count
+ // of empty pages, so pages freed concurrently (e.g. by TTL cleanup) also count. Eviction may run while the
+ // current thread already holds entry locks (single-row insertion), so contended entries are skipped
+ // (non-blocking) rather than blocked on, avoiding a lock-ordering deadlock.
+ //
+ // The guard is time-based (no progress for EVICTION_NO_PROGRESS_TIMEOUT_MILLIS) rather than attempt-count:
+ // a fixed budget could exhaust in milliseconds under contention/lock-holders and turn a slow-but-progressing
+ // eviction into a premature OOM. On each stalled iteration the thread backs off (rather than busy-spinning)
+ // both to save CPU and to let a lock holder run and release it.
+ long bestEmptyPages = emptyPages;
+
+ long lastProgressNanos = System.nanoTime();
+
+ long backoffNanos = EVICTION_BACKOFF_START_NANOS;
+
+ while (bestEmptyPages < requiredPages) {
+ if (region.metrics().onPageEvictionsStarted())
+ U.warn(log, "Page-based evictions started." +
+ " Consider increasing 'maxSize' on Data Region configuration: " + regCfg.getName());
+
+ evictDataPageNonBlocking(evictionTracker);
+
+ region.metrics().updateEvictionRate();
+
+ long curEmptyPages = freeList.emptyDataPages();
+
+ // Only an iteration that establishes a new highest empty-pages count counts as progress (drops caused by
+ // concurrent inserts consuming pages do not). As long as there is progress the loop continues; on a
+ // stalled iteration it backs off rather than busy-spinning.
+ if (curEmptyPages > bestEmptyPages) {
+ bestEmptyPages = curEmptyPages;
+
+ lastProgressNanos = System.nanoTime();
+
+ backoffNanos = EVICTION_BACKOFF_START_NANOS;
+ }
+ else {
+ LockSupport.parkNanos(backoffNanos);
+
+ backoffNanos = Math.min(backoffNanos << 1, EVICTION_BACKOFF_MAX_NANOS);
+ }
+
+ // Fail with OOM only after a sustained period without any progress: this bounds a genuinely stuck eviction
+ // (nothing evictable, or contenders never releasing their locks) without tearing down a slow-but-
+ // progressing one. The region is already under pressure (fast path failed), so OOM is correct here.
+ if (System.nanoTime() - lastProgressNanos > TimeUnit.MILLISECONDS.toNanos(EVICTION_NO_PROGRESS_TIMEOUT_MILLIS))
+ throw outOfMemory(regCfg);
}
}
+ /**
+ * Invokes a single page eviction, acquiring entry locks non-blockingly so that contended entries are skipped.
+ * This is required when eviction runs while the current thread already holds entry locks (size-aware eviction
+ * from a single-row insertion) to avoid a lock-ordering deadlock. {@link NoOpPageEvictionTracker}
+ * (disabled eviction, never reaching this path) falls back to the plain {@code evictDataPage()}.
+ *
+ * @param evictionTracker Page eviction tracker.
+ * @throws IgniteCheckedException If failed to evict a data page.
+ */
+ private void evictDataPageNonBlocking(PageEvictionTracker evictionTracker) throws IgniteCheckedException {
+ if (evictionTracker instanceof PageAbstractEvictionTracker)
+ ((PageAbstractEvictionTracker)evictionTracker).evictDataPageNonBlocking();
+ else
+ evictionTracker.evictDataPage();
+ }
+
+ /**
+ * @param regCfg Data region configuration.
+ * @return New {@link IgniteOutOfMemoryException} (also reported as a critical failure) for the given region.
+ */
+ private IgniteOutOfMemoryException outOfMemory(DataRegionConfiguration regCfg) {
+ IgniteOutOfMemoryException oom = new IgniteOutOfMemoryException("Out of memory in data region [" +
+ "name=" + regCfg.getName() +
+ ", initSize=" + U.readableSize(regCfg.getInitialSize(), false) +
+ ", maxSize=" + U.readableSize(regCfg.getMaxSize(), false) +
+ ", persistenceEnabled=" + regCfg.isPersistenceEnabled() + "] Try the following:" + U.nl() +
+ " ^-- Increase maximum off-heap memory size (DataRegionConfiguration.maxSize)" + U.nl() +
+ " ^-- Enable Ignite persistence (DataRegionConfiguration.persistenceEnabled)" + U.nl() +
+ " ^-- Enable eviction or expiration policies"
+ );
+
+ if (cctx.kernalContext() != null)
+ cctx.kernalContext().failure().process(new FailureContext(FailureType.CRITICAL_ERROR, oom));
+
+ return oom;
+ }
+
/**
* See {@code GridCacheMapEntry#ensureFreeSpace()}
*
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/RowStore.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/RowStore.java
index cffcf9b1e5be0..e48bbb9bdfa32 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/RowStore.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/RowStore.java
@@ -20,6 +20,7 @@
import java.util.Collection;
import java.util.function.Supplier;
import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.configuration.DataPageEvictionMode;
import org.apache.ignite.internal.metric.IoStatisticsHolder;
import org.apache.ignite.internal.pagemem.PageIdUtils;
import org.apache.ignite.internal.pagemem.PageMemory;
@@ -132,8 +133,25 @@ public void addRow(CacheDataRow row, IoStatisticsHolder statHolder) throws Ignit
* @param statHolder Statistics holder to track IO operations.
* @throws IgniteCheckedException If failed.
*/
- public void addRows(Collection extends CacheDataRow> rows,
- IoStatisticsHolder statHolder) throws IgniteCheckedException {
+ public void addRows(Collection extends CacheDataRow> rows, IoStatisticsHolder statHolder) throws IgniteCheckedException {
+ if (!persistenceEnabled && grp.dataRegion().config().getPageEvictionMode() != DataPageEvictionMode.DISABLED) {
+ // Size-aware reserve for each row in the batch (reserving only the largest is insufficient: a later large
+ // row can still exhaust page memory mid-write). The reserve/consume TOCTOU race and the "second large row
+ // in a batch" case are both closed by the lazy re-reserve in AbstractFreeList#writeSinglePage, which
+ // re-runs the reserve on the row remainder when a fragmented write cannot take a page (a raw OOM there
+ // would otherwise be wrapped by insertDataRows into CorruptedFreeListException and reported as corruption).
+ //
+ // The reserve evicts non-blockingly even though the batch path holds no entry locks (so blocking would be
+ // deadlock-safe and more effective here): the same reserve path is shared with single-row insertion,
+ // which runs under an entry lock and must not block.
+ for (CacheDataRow row : rows) {
+ int rowSize = row.size();
+
+ if (rowSize > 0)
+ ctx.database().ensureFreeSpaceForInsert(grp.dataRegion(), rowSize);
+ }
+ }
+
assert ctx.database().checkpointLockIsHeldByThread();
freeList.insertDataRows(rows, statHolder);
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/evict/PageAbstractEvictionTracker.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/evict/PageAbstractEvictionTracker.java
index 2330c0942662d..6a038272c054a 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/evict/PageAbstractEvictionTracker.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/evict/PageAbstractEvictionTracker.java
@@ -41,6 +41,13 @@ public abstract class PageAbstractEvictionTracker implements PageEvictionTracker
/** Millis in day. */
private static final int DAY = 24 * 60 * 60 * 1000;
+ /**
+ * Thread-local marker that the current eviction is requested by size-aware eviction, which may run
+ * while the calling thread already holds entry locks. When set, entries whose locks are contended are skipped
+ * (via a non-blocking {@code evictInternal}) instead of blocking, avoiding a lock-ordering deadlock.
+ */
+ private static final ThreadLocal EVICT_NON_BLOCKING = new ThreadLocal<>();
+
/** Page memory. */
protected final PageMemoryNoStoreImpl pageMem;
@@ -87,6 +94,26 @@ public abstract class PageAbstractEvictionTracker implements PageEvictionTracker
return pageMem.loadedPages() > pagesThreshold && freeList.emptyDataPages() < regCfg.getEmptyPagesPoolSize();
}
+ /**
+ * Evicts a data page, acquiring entry locks in a non-blocking way so that contended entries are skipped instead
+ * of blocked upon. Used by size-aware eviction which may run while the calling thread already holds
+ * entry locks, to avoid a lock-ordering deadlock.
+ *
+ * @throws IgniteCheckedException If failed.
+ */
+ public void evictDataPageNonBlocking() throws IgniteCheckedException {
+ Boolean prev = EVICT_NON_BLOCKING.get();
+
+ EVICT_NON_BLOCKING.set(Boolean.TRUE);
+
+ try {
+ evictDataPage();
+ }
+ finally {
+ EVICT_NON_BLOCKING.set(prev);
+ }
+ }
+
/**
* @param pageIdx Page index.
* @return true if at least one data row has been evicted
@@ -135,6 +162,8 @@ final boolean evictDataPage(int pageIdx) throws IgniteCheckedException {
boolean evictionDone = false;
+ boolean nonBlocking = Boolean.TRUE.equals(EVICT_NON_BLOCKING.get());
+
for (CacheDataRowAdapter dataRow : rowsToEvict) {
GridCacheContext, ?> cacheCtx = sharedCtx.cacheContext(dataRow.cacheId());
@@ -144,7 +173,7 @@ final boolean evictDataPage(int pageIdx) throws IgniteCheckedException {
GridCacheEntryEx entryEx = cacheCtx.isNear() ? cacheCtx.near().dht().entryEx(dataRow.key()) :
cacheCtx.cache().entryEx(dataRow.key());
- evictionDone |= entryEx.evictInternal(GridCacheVersionManager.EVICT_VER, null, true);
+ evictionDone |= entryEx.evictInternal(GridCacheVersionManager.EVICT_VER, null, true, nonBlocking);
}
return evictionDone;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/freelist/AbstractFreeList.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/freelist/AbstractFreeList.java
index 62452095631cf..29ada4d8541a9 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/freelist/AbstractFreeList.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/freelist/AbstractFreeList.java
@@ -36,6 +36,7 @@
import org.apache.ignite.internal.pagemem.wal.record.delta.DataPageUpdateRecord;
import org.apache.ignite.internal.processors.cache.persistence.DataRegion;
import org.apache.ignite.internal.processors.cache.persistence.DataRegionMetricsImpl;
+import org.apache.ignite.internal.processors.cache.persistence.IgniteCacheDatabaseSharedManager;
import org.apache.ignite.internal.processors.cache.persistence.Storable;
import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageLockTrackerManager;
import org.apache.ignite.internal.processors.cache.persistence.evict.PageEvictionTracker;
@@ -98,6 +99,12 @@ public abstract class AbstractFreeList extends PagesList imp
/** */
private final PageEvictionTracker evictionTracker;
+ /** Data region this free list belongs to (used for lazy size-aware re-reserve on fragmented writes). */
+ private final DataRegion dataRegion;
+
+ /** Database shared manager (used for lazy size-aware re-reserve on fragmented writes). */
+ private final IgniteCacheDatabaseSharedManager dbMgr;
+
/** Page list cache limit. */
private final AtomicLong pageListCacheLimit;
@@ -462,6 +469,11 @@ public AbstractFreeList(
rmvRow = new RemoveRowHandler(cacheGrpId == 0);
this.evictionTracker = dataRegion.evictionTracker();
+ this.dataRegion = dataRegion;
+ // The database manager is only needed for the on-demand re-reserve (an eviction-enabled, in-memory region),
+ // and is looked up lazily/null-safely because free lists can be built in unit tests against a kernal context
+ // without a cache processor (in which case eviction is disabled and the re-reserve never fires).
+ dbMgr = ctx.cache() == null ? null : ctx.cache().context().database();
this.reuseList = reuseList == null ? this : reuseList;
int pageSize = pageMem.pageSize();
@@ -701,10 +713,29 @@ private int writeWholePages(T row, IoStatisticsHolder statHolder) throws IgniteC
* @throws IgniteCheckedException If failed.
*/
private int writeSinglePage(T row, int written, IoStatisticsHolder statHolder) throws IgniteCheckedException {
+ // TOCTOU closure: the size-aware reserve (ensureFreeSpaceForInsert, invoked from RowStore.addRow/addRows
+ // before this write) accumulates enough real empty pages but does not pin them to this thread - a concurrent
+ // writer can consume them between the reserve and this allocation. When the free list cannot hand out a page,
+ // re-reserve on the remaining size and retry before allocating a brand-new page; otherwise the race surfaces
+ // as a raw IgniteOutOfMemoryException (wrapped into CorruptedFreeListException in the batch path).
+ //
+ // The re-reserve is an inline demand-eviction: reached from the BPlusTree.invoke row-creation closure, it may
+ // re-entrantly remove other entries from the same data tree. That is safe because the closure runs with no
+ // data-tree page locks held (page read lock released before it runs, leaf write lock taken after), and the
+ // outer operation revalidates via the page tag / triangle / removeId protocols. The key being written is
+ // skipped (its entry lock is held, so tryLock fails for it), so there is no self-eviction or lock-ordering
+ // deadlock; like the initial reserve, the re-reserve throws OOM if the row genuinely cannot fit.
AbstractDataPageIO initIo = null;
long pageId = takePage(row.size() - written, row, statHolder);
+ if (pageId == 0L) {
+ if (dbMgr != null)
+ dbMgr.ensureFreeSpaceForInsert(dataRegion, row.size() - written);
+
+ pageId = takePage(row.size() - written, row, statHolder);
+ }
+
if (pageId == 0L) {
pageId = allocateDataPage(row.partition());
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionConcurrentWritesAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionConcurrentWritesAbstractTest.java
new file mode 100644
index 0000000000000..b25114b08dd2b
--- /dev/null
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionConcurrentWritesAbstractTest.java
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.eviction.paged;
+
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.atomic.AtomicReference;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.cache.affinity.rendezvous.RendezvousAffinityFunction;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.DataRegionConfiguration;
+import org.apache.ignite.configuration.DataStorageConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+import static org.apache.ignite.configuration.DataStorageConfiguration.DFLT_PAGE_SIZE;
+
+/**
+ * Concurrent deadlock test for size-aware page eviction.
+ *
+ * The region is first filled with a large number of small entries (so there is plenty of evictable page space), then
+ * several threads concurrently insert large rows (larger than the empty-pages pool). Each large insert goes through
+ * the size-aware reserve and, for the single-row path, eviction under the new entry lock with the non-blocking
+ * {@code tryLockEntry}. The average data volume is kept within the region capacity, so eviction frees already-stored
+ * small entries rather than overrunning the free list. The test asserts that no deadlock occurs (all threads finish
+ * within a global deadline).
+ */
+public abstract class PageEvictionConcurrentWritesAbstractTest extends GridCommonAbstractTest {
+ /** Off-heap region size. */
+ private static final int SIZE = 256 * 1024 * 1024;
+
+ /** Partition count (kept low so that index-tree structures do not exhaust the region). */
+ private static final int PARTITIONS = 32;
+
+ /** Large record size (larger than the empty-pages pool so that each write is size-aware). */
+ private static final int LARGE_RECORD_SIZE = 2 * 1024 * 1024;
+
+ /** Small record size used to pre-fill the region with evictable data. */
+ private static final int SMALL_RECORD_SIZE = 4096;
+
+ /** Empty pages pool size. */
+ private static final int POOL_SIZE = 100;
+
+ /** Number of small pre-fill entries, leaving a buffer that is exceeded by the total of the large writes, so that
+ * the last of them can only be stored by freeing pages via size-aware eviction. The large records are small
+ * enough that concurrent size-aware eviction reliably frees the required pages (no spurious guard OOM). */
+ private static final int SMALL_ENTRIES = 48_000;
+
+ /** Number of writer threads. */
+ private static final int THREADS = 2;
+
+ /** Large rows inserted per thread. Their total (threads x rows) exceeds the buffer left by the pre-fill, so the
+ * last large writes overflow the region and require size-aware eviction to free small entry pages. */
+ private static final int LARGE_ROWS_PER_THREAD = 20;
+
+ /** Global deadline for the whole test (protects against a deadlock/busy-spin hang). */
+ private static final long DEADLINE = TimeUnit.MINUTES.toMillis(3);
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String gridName) throws Exception {
+ return super.getConfiguration(gridName)
+ .setDataStorageConfiguration(new DataStorageConfiguration()
+ .setDefaultDataRegionConfiguration(new DataRegionConfiguration()
+ .setInitialSize(SIZE)
+ .setMaxSize(SIZE)
+ .setEmptyPagesPoolSize(POOL_SIZE))
+ .setPageSize(DFLT_PAGE_SIZE));
+ }
+
+ /** {@inheritDoc} */
+ @Override protected void afterTest() throws Exception {
+ stopAllGrids();
+ }
+
+ /**
+ * @param ignite Ignite node.
+ * @return Cache with a small partition count (reduces structural page overhead).
+ */
+ private IgniteCache createCache(IgniteEx ignite) {
+ return ignite.createCache(new CacheConfiguration(DEFAULT_CACHE_NAME)
+ .setAffinity(new RendezvousAffinityFunction(false, PARTITIONS)));
+ }
+
+ /**
+ * Concurrent large inserts into a region pre-filled with small entries must complete within the deadline without
+ * deadlock, and without corrupting the free list (eviction frees small entries rather than overrunning the region).
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ public void testConcurrentLargeWritesNoDeadlock() throws Exception {
+ IgniteEx ignite = startGrid(1);
+
+ IgniteCache cache = createCache(ignite);
+
+ // Pre-fill the region with many small entries so that eviction always has evictable pages to free.
+ for (int i = 0; i < SMALL_ENTRIES; i++)
+ cache.put(i, new byte[SMALL_RECORD_SIZE]);
+
+ byte[] largeVal = new byte[LARGE_RECORD_SIZE];
+
+ AtomicLong errors = new AtomicLong();
+
+ AtomicReference firstErr = new AtomicReference<>();
+
+ CountDownLatch startLatch = new CountDownLatch(1);
+
+ long deadline = System.currentTimeMillis() + DEADLINE;
+
+ Thread[] threads = new Thread[THREADS];
+
+ for (int i = 0; i < THREADS; i++) {
+ final int threadIdx = i;
+
+ threads[i] = new Thread(() -> {
+ try {
+ startLatch.await();
+
+ for (int k = 0; k < LARGE_ROWS_PER_THREAD; k++)
+ cache.put(SMALL_ENTRIES + threadIdx * LARGE_ROWS_PER_THREAD + k, largeVal);
+ }
+ catch (Throwable e) {
+ errors.incrementAndGet();
+
+ firstErr.compareAndSet(null, e);
+
+ log.error("Unexpected error in writer thread", e);
+ }
+ }, "paged-writer-" + i);
+
+ threads[i].start();
+ }
+
+ startLatch.countDown();
+
+ long start = System.currentTimeMillis();
+
+ for (Thread t : threads)
+ t.join(Math.max(1, deadline - System.currentTimeMillis()));
+
+ // The core assertion of this deadlock test: every writer must have completed (no thread is stuck waiting on
+ // an entry lock held by size-aware eviction running under another entry lock).
+ for (Thread t : threads) {
+ if (t.isAlive()) {
+ log.error("Writer thread " + t.getName() + " is still alive after " +
+ (System.currentTimeMillis() - start) + "ms, state=" + t.getState());
+
+ for (StackTraceElement frame : t.getStackTrace())
+ log.error(" at " + frame);
+ }
+ }
+
+ for (Thread t : threads)
+ assertFalse("Writer thread " + t.getName() + " did not finish (possible deadlock)", t.isAlive());
+
+ assertEquals("Writer threads reported errors, reason: " + firstErr.get(), 0, errors.get());
+ }
+}
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionGuardOomTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionGuardOomTest.java
new file mode 100644
index 0000000000000..4c706d7347f2b
--- /dev/null
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionGuardOomTest.java
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.eviction.paged;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.concurrent.locks.Lock;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.cache.CacheAtomicityMode;
+import org.apache.ignite.cache.affinity.rendezvous.RendezvousAffinityFunction;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.configuration.DataPageEvictionMode;
+import org.apache.ignite.configuration.DataRegionConfiguration;
+import org.apache.ignite.configuration.DataStorageConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.junit.Test;
+
+import static org.apache.ignite.configuration.DataStorageConfiguration.DFLT_PAGE_SIZE;
+import static org.apache.ignite.internal.processors.cache.eviction.paged.PageEvictionSizeAwareAbstractTest.isOutOfMemory;
+
+/**
+ * Negative test for the size-aware eviction progress guard.
+ *
+ * When every resident entry is locked by another thread/transaction, page eviction cannot free any page: the guarded
+ * {@code tryLockEntry(0)} in {@code evictInternal} fails for every candidate, so {@code ensureFreeSpaceForEviction}
+ * makes no progress and must fail with an
+ * {@code IgniteOutOfMemoryException} within bounded time instead of busy-spinning forever (deadlock).
+ *
+ * The test is self-guarded by {@code @Test(timeout = ...)}: a deadlock or unbounded busy-spin would fail the
+ * deadline.
+ */
+public class PageEvictionGuardOomTest extends GridCommonAbstractTest {
+ /** Off-heap region size. */
+ private static final int SIZE = 12 * 1024 * 1024;
+
+ /** Partition count (kept low so that index-tree structures do not exhaust the region). */
+ private static final int PARTITIONS = 32;
+
+ /** Empty pages pool size. */
+ private static final int POOL_SIZE = 100;
+
+ /** Small record size chosen to occupy roughly one data page ({@link DFLT_PAGE_SIZE}) each. */
+ private static final int FILL_VALUE_SIZE = 3_800;
+
+ /**
+ * Number of resident entries (each ~one page) filling the region to ~55% of its capacity. This keeps the region
+ * comfortably below the eviction threshold (so the ordinary threshold-based {@code ensureFreeSpace} path is a
+ * no-op) while leaving less free space than a single large record needs, so the size-aware eviction guard is
+ * exercised.
+ */
+ private static final int FILL_ENTRIES = 1_600;
+
+ /** Large record size that does not fit into the remaining free space (requires eviction to be stored). */
+ private static final int LARGE_RECORD_SIZE = 8 * 1024 * 1024;
+
+ /** {@inheritDoc} */
+ @Override protected IgniteConfiguration getConfiguration(String gridName) throws Exception {
+ return super.getConfiguration(gridName)
+ .setDataStorageConfiguration(new DataStorageConfiguration()
+ .setDefaultDataRegionConfiguration(new DataRegionConfiguration()
+ .setInitialSize(SIZE)
+ .setMaxSize(SIZE)
+ .setEmptyPagesPoolSize(POOL_SIZE)
+ .setPageEvictionMode(DataPageEvictionMode.RANDOM_LRU))
+ .setPageSize(DFLT_PAGE_SIZE));
+ }
+
+ /** {@inheritDoc} */
+ @Override protected void afterTest() throws Exception {
+ stopAllGrids();
+ }
+
+ /**
+ * @param ignite Ignite node.
+ * @return Cache with a small partition count (reduces structural page overhead).
+ */
+ private IgniteCache createCache(IgniteEx ignite) {
+ // TRANSACTIONAL is required so that cache.lockAll(...) can hold entry locks (the root cause of the
+ // "no evictable page" scenario this test exercises).
+ return ignite.createCache(new CacheConfiguration(DEFAULT_CACHE_NAME)
+ .setAffinity(new RendezvousAffinityFunction(false, PARTITIONS))
+ .setAtomicityMode(CacheAtomicityMode.TRANSACTIONAL));
+ }
+
+ /**
+ * Filling the region with locked entries and then writing a row that needs more free pages than remain must fail
+ * with OOM (bounded time), not hang: eviction cannot free any page because every candidate entry is locked.
+ *
+ * @throws Exception If failed.
+ */
+ @Test(timeout = 180_000)
+ public void testGuardOomWhenAllEntriesLocked() throws Exception {
+ IgniteEx ignite = startGrid(1);
+
+ IgniteCache cache = createCache(ignite);
+
+ // Pre-fill the region so that less than one large record of free space remains, without overflowing it.
+ byte[] fillVal = new byte[FILL_VALUE_SIZE];
+
+ for (int i = 1; i <= FILL_ENTRIES; i++)
+ cache.put(i, fillVal);
+
+ Collection keys = new ArrayList<>(FILL_ENTRIES);
+
+ for (int i = 1; i <= FILL_ENTRIES; i++)
+ keys.add(i);
+
+ CountDownLatch ready = new CountDownLatch(1);
+
+ CountDownLatch release = new CountDownLatch(1);
+
+ AtomicReference lockerErr = new AtomicReference<>();
+
+ // Hold entry locks on every resident key from a background thread so that eviction has no evictable page.
+ Thread locker = new Thread(() -> {
+ try {
+ Lock lock = cache.lockAll(keys);
+
+ lock.lock();
+
+ ready.countDown();
+
+ release.await();
+
+ lock.unlock();
+ }
+ catch (Throwable e) {
+ lockerErr.set(e);
+
+ ready.countDown();
+ }
+ }, "size-aware-guard-locker");
+
+ locker.start();
+
+ try {
+ assertTrue("Timed out waiting for entries to be locked", ready.await(60, TimeUnit.SECONDS));
+
+ assertNull("Unexpected error while locking entries: " + lockerErr.get(), lockerErr.get());
+
+ try {
+ cache.put(FILL_ENTRIES + 1, new byte[LARGE_RECORD_SIZE]);
+
+ fail("Expected out-of-memory because all resident entries are locked, but put succeeded");
+ }
+ catch (Exception e) {
+ assertTrue("Expected an out-of-memory (progress guard) failure, but got: " + e, isOutOfMemory(e));
+ }
+ }
+ finally {
+ release.countDown();
+
+ locker.join(TimeUnit.SECONDS.toMillis(10));
+ }
+ }
+}
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionMetricTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionMetricTest.java
index 9f40cf4958431..6efd5b6bffbd0 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionMetricTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionMetricTest.java
@@ -49,6 +49,36 @@ public void testPageEvictionMetric() throws Exception {
checkPageEvictionMetric(CacheAtomicityMode.ATOMIC);
}
+ /**
+ * Regression: ordinary small records that keep the region below the eviction threshold must not trigger page
+ * eviction at all (eviction is not started, eviction rate stays zero).
+ *
+ * @throws Exception If failed.
+ */
+ @Test
+ public void testNoEvictionBelowThreshold() throws Exception {
+ IgniteEx ignite = startGrid(0);
+
+ DataRegionMetricsImpl metrics = ignite.context().cache().context().database().dataRegion(null).metrics();
+
+ metrics.enableMetrics();
+
+ CacheConfiguration