Fixed a bug in tests

Author: vinjai

pyiceberg/table/update/__init__.py

@@ -609,7 +609,6 @@ class AssertRefSnapshotId(ValidatableTableRequirement):
 
     type: Literal["assert-ref-snapshot-id"] = Field(default="assert-ref-snapshot-id")
     ref: str = Field(...)
-    # ref_type: SnapshotRefType = Field(...)
     snapshot_id: Optional[int] = Field(default=None, alias="snapshot-id")
 
     def validate(self, base_metadata: Optional[TableMetadata]) -> None:
@@ -624,11 +623,11 @@ def validate(self, base_metadata: Optional[TableMetadata]) -> None:
             if self.snapshot_id is None:
                 raise CommitFailedException(f"Requirement failed: {ref_type} {self.ref} was created concurrently")
             elif self.snapshot_id != snapshot_ref.snapshot_id:
+                if ref_type == SnapshotRefType.TAG:
+                    raise CommitFailedException(f"Requirement failed: TAG {self.ref} can't be updated once created")
                 raise CommitFailedException(
                     f"Requirement failed: {ref_type} {self.ref} has changed: expected id {self.snapshot_id}, found {snapshot_ref.snapshot_id}"
                 )
-            elif ref_type == SnapshotRefType.TAG:
-                raise CommitFailedException(f"Requirement failed: TAG {self.ref} can't be updated once created")
         elif self.snapshot_id is not None:
             raise CommitFailedException(f"Requirement failed: branch or tag {self.ref} is missing, expected {self.snapshot_id}")
 

tests/table/test_init.py

@@ -1017,7 +1017,7 @@ def test_assert_ref_snapshot_id(table_v2: Table) -> None:
         CommitFailedException,
         match="Requirement failed: TAG test can't be updated once created",
     ):
-        AssertRefSnapshotId(ref="test", snapshot_id=3051729675574597004).validate(base_metadata)
+        AssertRefSnapshotId(ref="test", snapshot_id=3055729675574597004).validate(base_metadata)
 
 
 def test_assert_last_assigned_field_id(table_v2: Table) -> None: