Skip to content

Commit d6cb2e2

Browse files
committed
Add deprecation message for source-id
1 parent cbbffc5 commit d6cb2e2

2 files changed

Lines changed: 17 additions & 0 deletions

File tree

pyiceberg/partitioning.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
UUIDType,
6060
)
6161
from pyiceberg.utils.datetime import date_to_days, datetime_to_micros, time_to_micros
62+
from pyiceberg.utils.deprecated import deprecation_message
6263

6364
INITIAL_PARTITION_SPEC_ID = 0
6465
PARTITION_FIELD_ID_START: int = 1000
@@ -101,6 +102,13 @@ def __init__(
101102
if name is not None:
102103
data["name"] = name
103104

105+
if data["source-id"]:
106+
deprecation_message(
107+
deprecated_in="0.10.0",
108+
removed_in="0.11.0",
109+
help_message="source-id is not allowed for Iceberg v3. Please use source-ids instead.",
110+
)
111+
104112
super().__init__(**data)
105113

106114
@model_validator(mode="before")

pyiceberg/table/sorting.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
from pyiceberg.transforms import IdentityTransform, Transform, parse_transform
3131
from pyiceberg.typedef import IcebergBaseModel
3232
from pyiceberg.types import IcebergType
33+
from pyiceberg.utils.deprecated import deprecation_message
3334

3435

3536
class SortDirection(Enum):
@@ -85,6 +86,14 @@ def __init__(
8586
data["direction"] = direction
8687
if null_order is not None:
8788
data["null-order"] = null_order
89+
90+
if data["source-id"]:
91+
deprecation_message(
92+
deprecated_in="0.10.0",
93+
removed_in="0.11.0",
94+
help_message="source-id is not allowed for Iceberg v3. Please use source-ids instead.",
95+
)
96+
8897
super().__init__(**data)
8998

9099
@model_validator(mode="before")

0 commit comments

Comments
 (0)