address feedback

Author: geruh

pyiceberg/table/__init__.py

@@ -275,13 +275,20 @@ def __exit__(self, exctype: type[BaseException] | None, excinst: BaseException |
         if exctype is None and excinst is None and exctb is None:
             self.commit_transaction()
 
-    def _apply(
+    def _stage(
         self,
         updates: tuple[TableUpdate, ...],
         requirements: tuple[TableRequirement, ...] = (),
-        commit_transaction_if_autocommit: bool = True,
     ) -> Transaction:
-        """Check if the requirements are met, and applies the updates to the metadata."""
+        """Stage updates to the transaction state without committing to the catalog.
+
+        Args:
+            updates: The updates to stage.
+            requirements: The requirements that must be met.
+
+        Returns:
+            This transaction for method chaining.
+        """
         for requirement in requirements:
             requirement.validate(self.table_metadata)
 
@@ -294,7 +301,17 @@ def _apply(
             if type(new_requirement) not in existing_requirements:
                 self._requirements = self._requirements + (new_requirement,)
 
-        if self._autocommit and commit_transaction_if_autocommit:
+        return self
+
+    def _apply(
+        self,
+        updates: tuple[TableUpdate, ...],
+        requirements: tuple[TableRequirement, ...] = (),
+    ) -> Transaction:
+        """Check if the requirements are met, and applies the updates to the metadata."""
+        self._stage(updates, requirements)
+
+        if self._autocommit:
             self.commit_transaction()
 
         return self

pyiceberg/table/update/snapshot.py

@@ -844,9 +844,9 @@ def _commit(self) -> UpdatesAndRequirements:
         return self._updates, self._requirements
 
     def _commit_if_ref_updates_exist(self) -> None:
-        """Commit any pending ref updates to the transaction."""
+        """Stage any pending ref updates to the transaction state."""
         if self._updates:
-            self._transaction._apply(*self._commit(), commit_transaction_if_autocommit=False)
+            self._transaction._stage(*self._commit())
             self._updates = ()
             self._requirements = ()
 
@@ -980,10 +980,9 @@ def set_current_snapshot(self, snapshot_id: int | None = None, ref_name: str | N
         update, requirement = self._transaction._set_ref_snapshot(
             snapshot_id=target_snapshot_id,
             ref_name=MAIN_BRANCH,
-            type="branch",
+            type=SnapshotRefType.BRANCH,
         )
-        self._updates += update
-        self._requirements += requirement
+        self._transaction._stage(update, requirement)
         return self