lint

Author: sungwy

pyiceberg/catalog/rest/auth.py

@@ -15,24 +15,24 @@
 # specific language governing permissions and limitations
 # under the License.
 
+import base64
 from abc import ABC, abstractmethod
 from typing import Optional
+
 from requests import PreparedRequest
 from requests.auth import AuthBase
 
-import base64
 
 class AuthManager(ABC):
     """
-    Abstract base class for Authentication Managers used to supply authorization headers
-    to HTTP clients (e.g. requests.Session).
-    
+    Abstract base class for Authentication Managers used to supply authorization headers to HTTP clients (e.g. requests.Session).
+
     Subclasses must implement the `auth_header` method to return an Authorization header value.
     """
+
     @abstractmethod
     def auth_header(self) -> Optional[str]:
         """Return the Authorization header value, or None if not applicable."""
-        pass
 
 
 class NoopAuthManager(AuthManager):
@@ -41,7 +41,7 @@ def auth_header(self) -> Optional[str]:
 
 
 class BasicAuthManager(AuthManager):
-    def __init__(self, username: str, password: str):        
+    def __init__(self, username: str, password: str):
         credentials = f"{username}:{password}"
         self._token = base64.b64encode(credentials.encode()).decode()
 
@@ -50,24 +50,24 @@ def auth_header(self) -> str:
 
 
 class AuthManagerAdapter(AuthBase):
-    """
-    A `requests.auth.AuthBase` adapter that integrates an `AuthManager`
-    into a `requests.Session` to automatically attach the appropriate
-    Authorization header to every request.
+    """A `requests.auth.AuthBase` adapter that integrates an `AuthManager` into a `requests.Session` to automatically attach the appropriate Authorization header to every request.
 
     This adapter is useful when working with `requests.Session.auth`
     and allows reuse of authentication strategies defined by `AuthManager`.
     """
+
     def __init__(self, auth_manager: AuthManager):
         """
-            Args:
-                auth_manager (AuthManager): An instance of an AuthManager subclass.
+        Initialize AuthManagerAdapter.
+
+        Args:
+            auth_manager (AuthManager): An instance of an AuthManager subclass.
         """
         self.auth_manager = auth_manager
 
     def __call__(self, r: PreparedRequest) -> PreparedRequest:
         """
-        Modifies the outgoing request to include the Authorization header.
+        Modify the outgoing request to include the Authorization header.
 
         Args:
             r (requests.PreparedRequest): The HTTP request being prepared.
@@ -77,5 +77,5 @@ def __call__(self, r: PreparedRequest) -> PreparedRequest:
         """
         auth_header = self.auth_manager.auth_header()
         if auth_header:
-            r.headers['Authorization'] = auth_header
+            r.headers["Authorization"] = auth_header
         return r

tests/catalog/test_rest_auth.py

@@ -15,15 +15,17 @@
 #  specific language governing permissions and limitations
 #  under the License.
 
-from pyiceberg.catalog.rest.auth import AuthManagerAdapter, NoopAuthManager, BasicAuthManager
-
 import base64
+
 import pytest
 import requests
 from requests_mock import Mocker
 
+from pyiceberg.catalog.rest.auth import AuthManagerAdapter, BasicAuthManager, NoopAuthManager
+
 TEST_URI = "https://iceberg-test-catalog/"
 
+
 @pytest.fixture
 def rest_mock(requests_mock: Mocker) -> Mocker:
     requests_mock.get(
@@ -34,19 +36,19 @@ def rest_mock(requests_mock: Mocker) -> Mocker:
     return requests_mock
 
 
-def test_noop_auth_header(rest_mock: Mocker):
+def test_noop_auth_header(rest_mock: Mocker) -> None:
     auth_manager = NoopAuthManager()
     session = requests.Session()
     session.auth = AuthManagerAdapter(auth_manager)
 
-    response = session.get(TEST_URI)
+    session.get(TEST_URI)
     history = rest_mock.request_history
     assert len(history) == 1
     actual_headers = history[0].headers
     assert "Authorization" not in actual_headers
 
 
-def test_basic_auth_header(rest_mock: Mocker):
+def test_basic_auth_header(rest_mock: Mocker) -> None:
     username = "testuser"
     password = "testpassword"
     expected_token = base64.b64encode(f"{username}:{password}".encode()).decode()
@@ -56,7 +58,7 @@ def test_basic_auth_header(rest_mock: Mocker):
     session = requests.Session()
     session.auth = AuthManagerAdapter(auth_manager)
 
-    response = session.get(TEST_URI)
+    session.get(TEST_URI)
     history = rest_mock.request_history
     assert len(history) == 1
     actual_headers = history[0].headers