Nit improvements to tests

Author: Sreesh Maheshwar

dev/provision.py

@@ -457,7 +457,7 @@
     )
 
     # https://github.com/apache/iceberg/issues/1092#issuecomment-638432848 / https://github.com/apache/iceberg/issues/3747#issuecomment-1145419407
-    # REPLACE TABLE requires certain Hive server configuration
+    # Don't do replace for Hive catalog as REPLACE TABLE requires certain Hive server configuration
     if catalog_name != "hive":
         # Replace to break snapshot lineage:
         spark.sql(

tests/integration/test_reads.py

@@ -1159,7 +1159,7 @@ def test_incremental_append_scan_throws_on_missing_snapshot_ids(catalog: Catalog
         test_table.incremental_append_scan(
             to_snapshot_id_inclusive=test_table.snapshots()[0].snapshot_id,
         ).plan_files()
-    assert "Start snapshot of append scan unspecified, please set from_snapshot_id" in str(e.value)
+    assert "Start snapshot of append scan unspecified, please set from_snapshot_id_exclusive" in str(e.value)
 
     # from_snapshot_id missing from metadata
     with pytest.raises(ValueError) as e:

tests/table/test_snapshots.py

@@ -439,34 +439,33 @@ def test_ancestors_between(table_v2_with_extensive_snapshots: Table) -> None:
 
 
 def test_is_ancestor_of(table_v2: Table) -> None:
-    snapshot_id = 3055729675574597004
-    ancestor_snapshot_id = 3051729675574597004
+    snapshot_id, ancestor_snapshot_id = 3055729675574597004, 3051729675574597004
 
     assert is_ancestor_of(snapshot_id, ancestor_snapshot_id, table_v2.metadata)
     assert not is_ancestor_of(ancestor_snapshot_id, snapshot_id, table_v2.metadata)
 
 
 def test_ancestors_between_ids(table_v2: Table) -> None:
-    snapshot_id = 3055729675574597004
-    ancestor_snapshot_id = 3051729675574597004
+    snapshot_id, ancestor_snapshot_id = 3055729675574597004, 3051729675574597004
 
     result = list(ancestors_between_ids(ancestor_snapshot_id, snapshot_id, table_v2.metadata))
     ids = [ancestor.snapshot_id for ancestor in result]
 
-    # Exclusive-inclusive semantics mean just snapshot_id should be returned
+    # Exclusive-inclusive semantics means just 'snapshot_id' should be returned
     assert ids == [snapshot_id]
 
 
 def test_ancestors_between_equal_ids(table_v2: Table) -> None:
     snapshot_id = 3055729675574597004
 
     result = list(ancestors_between_ids(snapshot_id, snapshot_id, table_v2.metadata))
+
+    # Exclusive-inclusive semantics mean no ancestors should be returned
     assert result == []
 
 
 def test_ancestors_between_ids_missing_from_snapshot(table_v2: Table) -> None:
-    snapshot_id = 3055729675574597004
-    ancestor_snapshot_id = 3051729675574597004
+    snapshot_id, ancestor_snapshot_id = 3055729675574597004, 3051729675574597004
 
     result = list(
         ancestors_between_ids(