Skip to content

Commit 9819074

Browse files
committed
clean up type imports for glue and dynamo catalogs
1 parent cc28012 commit 9819074

4 files changed

Lines changed: 16 additions & 15 deletions

File tree

poetry.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyiceberg/catalog/dynamodb.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
)
2929

3030
import boto3
31-
from mypy_boto3_dynamodb.client import DynamoDBClient
3231

3332
from pyiceberg.catalog import (
3433
BOTOCORE_SESSION,
@@ -67,6 +66,8 @@
6766

6867
if TYPE_CHECKING:
6968
import pyarrow as pa
69+
from mypy_boto3_dynamodb.client import DynamoDBClient
70+
7071

7172
DYNAMODB_CLIENT = "dynamodb"
7273

pyiceberg/catalog/glue.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,6 @@
3030

3131
import boto3
3232
from botocore.config import Config
33-
from mypy_boto3_glue.client import GlueClient
34-
from mypy_boto3_glue.type_defs import (
35-
ColumnTypeDef,
36-
DatabaseInputTypeDef,
37-
DatabaseTypeDef,
38-
StorageDescriptorTypeDef,
39-
TableInputTypeDef,
40-
TableTypeDef,
41-
)
4233

4334
from pyiceberg.catalog import (
4435
BOTOCORE_SESSION,
@@ -101,6 +92,15 @@
10192

10293
if TYPE_CHECKING:
10394
import pyarrow as pa
95+
from mypy_boto3_glue.client import GlueClient
96+
from mypy_boto3_glue.type_defs import (
97+
ColumnTypeDef,
98+
DatabaseInputTypeDef,
99+
DatabaseTypeDef,
100+
StorageDescriptorTypeDef,
101+
TableInputTypeDef,
102+
TableTypeDef,
103+
)
104104

105105

106106
# There is a unique Glue metastore in each AWS account and each AWS region. By default, GlueCatalog chooses the Glue

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ cython = "3.1.1"
101101
deptry = ">=0.14,<0.24"
102102
datafusion = ">=44,<48"
103103
docutils = "!=0.21.post1" # https://github.com/python-poetry/poetry/issues/9248#issuecomment-2026240520
104-
mypy-boto3-glue = { version = ">=1.28.18", optional = true }
105-
mypy-boto3-dynamodb = { version = ">=1.28.18", optional = true }
104+
mypy-boto3-glue = ">=1.28.18"
105+
mypy-boto3-dynamodb = ">=1.28.18"
106106

107107
[tool.poetry.group.docs.dependencies]
108108
# for mkdocs

0 commit comments

Comments
 (0)