remove unused

Author: kevinjqliu

pyiceberg/io/pyarrow.py

@@ -426,32 +426,6 @@ def _initialize_fs(self, scheme: str, netloc: Optional[str] = None) -> FileSyste
         else:
             raise ValueError(f"Unrecognized filesystem type in URI: {scheme}")
 
-    def _process_basic_properties(
-        self, property_mapping: Dict[str, str], special_properties: Set[str], prefix: str
-    ) -> Dict[str, Any]:
-        """Process basic property mappings and prefix passthrough logic."""
-        client_kwargs: Dict[str, Any] = {}
-
-        for prop_name, prop_value in self.properties.items():
-            if prop_value is None:
-                continue
-
-            # Skip properties that need special handling
-            if prop_name in special_properties:
-                continue
-
-            # Map known property names to filesystem parameter names
-            if prop_name in property_mapping:
-                param_name = property_mapping[prop_name]
-                client_kwargs[param_name] = prop_value
-
-            # Pass through any other {prefix}.* properties
-            elif prop_name.startswith(f"{prefix}."):
-                param_name = prop_name.split(".", 1)[1]
-                client_kwargs[param_name] = prop_value
-
-        return client_kwargs
-
     def _get_first_property_value_with_tracking(self, props: Properties, used_keys: set[str], *keys: str) -> Optional[Any]:
         """Tracks all candidate keys and returns the first value found."""
         used_keys.update(keys)
@@ -676,9 +650,11 @@ def _initialize_gcs_fs(self) -> FileSystem:
             url_parts = urlparse(endpoint)
             client_kwargs["scheme"] = url_parts.scheme
             client_kwargs["endpoint_override"] = url_parts.netloc
-        if scheme := get("gcs.scheme") and "scheme" not in client_kwargs:
+        if scheme := get("gcs.scheme") and "scheme" not in client_kwargs:  # GCS_SERVICE_HOST takes precedence
             client_kwargs["scheme"] = scheme
-        if endpoint_override := get("gcs.endpoint_override") and "endpoint_override" not in client_kwargs:
+        if (
+            endpoint_override := get("gcs.endpoint_override") and "endpoint_override" not in client_kwargs
+        ):  # GCS_SERVICE_HOST takes precedence
             client_kwargs["endpoint_override"] = endpoint_override
 
         if project_id := get(GCS_PROJECT_ID, "gcs.project_id"):

pyiceberg/utils/properties.py

@@ -86,26 +86,6 @@ def get_header_properties(
     return {key[header_prefix_len:]: value for key, value in properties.items() if key.startswith(HEADER_PREFIX)}
 
 
-def properties_with_prefix(
-    properties: Properties,
-    prefix: str,
-) -> Properties:
-    """
-    Return subset of provided map with keys matching the provided prefix. Matching is case-sensitive and the matching prefix is removed from the keys in returned map.
-
-    Args:
-        properties: input map
-        prefix: prefix to choose keys from input map
-
-    Returns:
-        subset of input map with keys starting with provided prefix and prefix trimmed out
-    """
-    if not properties:
-        return {}
-
-    return {key[len(prefix) :]: value for key, value in properties.items() if key.startswith(prefix)}
-
-
 def filter_properties(
     properties: Properties,
     key_predicate: Callable[[str], bool],