WIP

Author: Fokko

poetry.lock

@@ -985,12 +985,12 @@ def _inherit_from_manifest(entry: ManifestEntry, manifest: ManifestFile) -> Mani
 
     # in v1 tables, the sequence number is not persisted and can be safely defaulted to 0
     # in v2 tables, the sequence number should be inherited iff the entry status is ADDED
-    if entry.sequence_number == 0 and (manifest.sequence_number == 0 or entry.status == ManifestEntryStatus.ADDED):
+    if entry.sequence_number is None and entry.status == ManifestEntryStatus.ADDED:
         entry.sequence_number = manifest.sequence_number
 
     # in v1 tables, the file sequence number is not persisted and can be safely defaulted to 0
     # in v2 tables, the file sequence number should be inherited iff the entry status is ADDED
-    if entry.file_sequence_number == 0 and (manifest.sequence_number == 0 or entry.status == ManifestEntryStatus.ADDED):
+    if entry.file_sequence_number is None and entry.status == ManifestEntryStatus.ADDED:
         # Only available in V2, always 0 in V1
         entry.file_sequence_number = manifest.sequence_number
 
@@ -1132,6 +1132,7 @@ def add_entry(self, entry: ManifestEntry) -> ManifestWriter:
             self._deleted_files += 1
             self._deleted_rows += entry.data_file.record_count
         else:
+            entry
             raise ValueError(f"Unknown entry: {entry.status}")
 
         self._partitions.append(entry.data_file.partition)
@@ -1150,7 +1151,7 @@ def add(self, entry: ManifestEntry) -> ManifestWriter:
         if entry.sequence_number is not None and entry.sequence_number >= 0:
             self.add_entry(
                 ManifestEntry.from_args(
-                    snapshot_id=self._snapshot_id, sequence_number=entry.sequence_number, data_file=entry.data_file
+                    status=ManifestEntryStatus.ADDED, snapshot_id=self._snapshot_id, sequence_number=entry.sequence_number, data_file=entry.data_file
                 )
             )
         else:

pyiceberg/manifest.py

@@ -219,11 +219,14 @@ def _write_delete_manifest() -> List[ManifestFile]:
 
         executor = ExecutorFactory.get_or_create()
 
-        added_manifests = executor.submit(_write_added_manifest)
-        delete_manifests = executor.submit(_write_delete_manifest)
-        existing_manifests = executor.submit(self._existing_manifests)
-
-        return self._process_manifests(added_manifests.result() + delete_manifests.result() + existing_manifests.result())
+        # added_manifests = executor.submit(_write_added_manifest)
+        # delete_manifests = executor.submit(_write_delete_manifest)
+        # existing_manifests = executor.submit(self._existing_manifests)
+        added_manifests = _write_added_manifest()
+        delete_manifests = _write_delete_manifest()
+        existing_manifests = self._existing_manifests()
+
+        return self._process_manifests(added_manifests + delete_manifests + existing_manifests)
 
     def _summary(self, snapshot_properties: Dict[str, str] = EMPTY_DICT) -> Summary:
         from pyiceberg.table import TableProperties

pyiceberg/table/update/snapshot.py

@@ -83,7 +83,7 @@ sqlalchemy = { version = "^2.0.18", optional = true }
 bodo = { version = ">=2025.7.4", optional = true }
 daft = { version = ">=0.5.0", optional = true }
 cachetools = ">=5.5,<7.0"
-pyiceberg-core = { file = "/Users/fokko.driesprong/work/iceberg-rust/bindings/python/dist/pyiceberg_core-0.6.1925555-cp39-abi3-macosx_11_0_arm64.whl" }
+pyiceberg-core = { file = "/Users/fokko.driesprong/work/iceberg-rust/bindings/python/dist/pyiceberg_core-0.22.22-cp39-abi3-macosx_11_0_arm64.whl" }
 polars = { version = "^1.21.0", optional = true }
 thrift-sasl = { version = ">=0.4.3", optional = true }
 kerberos = {version = "^1.3.1", optional = true}