add abstract methods to additional classes

Author: rambleraptor

pyiceberg/catalog/dynamodb.py

@@ -558,6 +558,9 @@ def drop_view(self, identifier: str | Identifier) -> None:
     def view_exists(self, identifier: str | Identifier) -> bool:
         raise NotImplementedError
 
+    def rename_view(self, from_identifier: str | Identifier, to_identifier: str | Identifier) -> None:
+        raise NotImplementedError
+
     def _get_iceberg_table_item(self, database_name: str, table_name: str) -> dict[str, Any]:
         try:
             return self._get_dynamo_item(identifier=f"{database_name}.{table_name}", namespace=database_name)

pyiceberg/catalog/glue.py

@@ -972,6 +972,9 @@ def drop_view(self, identifier: str | Identifier) -> None:
     def view_exists(self, identifier: str | Identifier) -> bool:
         raise NotImplementedError
 
+    def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
+        raise NotImplementedError
+
     @staticmethod
     def __is_iceberg_table(table: "TableTypeDef") -> bool:
         return table.get("Parameters", {}).get(TABLE_TYPE, "").lower() == ICEBERG

pyiceberg/catalog/hive.py

@@ -482,6 +482,9 @@ def list_views(self, namespace: str | Identifier) -> list[Identifier]:
     def view_exists(self, identifier: str | Identifier) -> bool:
         raise NotImplementedError
 
+    def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
+        raise NotImplementedError
+
     def _create_lock_request(self, database_name: str, table_name: str) -> LockRequest:
         lock_component: LockComponent = LockComponent(
             level=LockLevel.TABLE, type=LockType.EXCLUSIVE, dbname=database_name, tablename=table_name, isTransactional=True

pyiceberg/catalog/noop.py

@@ -143,3 +143,6 @@ def create_view(
         properties: Properties = EMPTY_DICT,
     ) -> View:
         raise NotImplementedError
+
+    def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
+        raise NotImplementedError

pyiceberg/catalog/sql.py

@@ -754,3 +754,6 @@ def close(self) -> None:
         """
         if hasattr(self, "engine"):
             self.engine.dispose()
+
+    def rename_view(self, from_identifier: Union[str, Identifier], to_identifier: Union[str, Identifier]) -> None:
+        raise NotImplementedError

tests/catalog/test_rest.py

@@ -2325,7 +2325,6 @@ def test_rest_catalog_context_manager_with_exception_sigv4(self, rest_mock: Mock
         assert catalog is not None and hasattr(catalog, "_session")
         assert len(catalog._session.adapters) == self.EXPECTED_ADAPTERS_SIGV4
 
-<<<<<<< HEAD
     def test_server_side_planning_disabled_by_default(self, rest_mock: Mocker) -> None:
         catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)