Deserialize expressions

Author: Fokko

pyiceberg/expressions/__init__.py

@@ -307,12 +307,10 @@ def __new__(cls, left: BooleanExpression, right: BooleanExpression, *rest: Boole
         elif right is AlwaysTrue():
             return left
         else:
-            return super().__new__(cls)
-
-    def __init__(self, left: BooleanExpression, right: BooleanExpression, *rest: BooleanExpression) -> None:
-        # Ignore rest if provided - __new__ should have handled it
-        if not rest:
-            super().__init__(left=left, right=right)
+            obj = super().__new__(cls)
+            obj.left = left
+            obj.right = right
+            return obj
 
     def __eq__(self, other: Any) -> bool:
         """Return the equality of two instances of the And class."""

tests/expressions/test_expressions.py

@@ -724,10 +724,6 @@ def test_and() -> None:
     with pytest.raises(ValueError, match="Expected BooleanExpression, got: abc"):
         null & "abc"
 
-    json_repr = '{"type": "and", "left": {"type": "is-null", "ref"}}'
-    assert and_.model_dump_json() == json_repr
-    assert BooleanExpression.model_validate_json(json_repr) == and_
-
 
 def test_or() -> None:
     null = IsNull(Reference("a"))