address feedback

Author: geruh

pyiceberg/catalog/rest/__init__.py

@@ -133,6 +133,7 @@ class IdentifierKind(Enum):
 AUTH = "auth"
 CUSTOM = "custom"
 REST_SCAN_PLANNING_ENABLED = "rest-scan-planning-enabled"
+REST_SCAN_PLANNING_ENABLED_DEFAULT = False
 
 NAMESPACE_SEPARATOR = b"\x1f".decode(UTF8)
 
@@ -272,13 +273,13 @@ def _create_session(self) -> Session:
 
         return session
 
-    def is_scan_planning_enabled(self) -> bool:
-        """Check if server-side scan planning is enabled.
+    def is_rest_scan_planning_enabled(self) -> bool:
+        """Check if rest server-side scan planning is enabled.
 
         Returns:
             True if enabled, False otherwise.
         """
-        return property_as_bool(self.properties, REST_SCAN_PLANNING_ENABLED, False)
+        return property_as_bool(self.properties, REST_SCAN_PLANNING_ENABLED, REST_SCAN_PLANNING_ENABLED_DEFAULT)
 
     def _create_legacy_oauth2_auth_manager(self, session: Session) -> AuthManager:
         """Create the LegacyOAuth2AuthManager by fetching required properties.

tests/catalog/test_rest.py

@@ -1994,17 +1994,17 @@ def test_rest_catalog_context_manager_with_exception_sigv4(self, rest_mock: Mock
         assert catalog is not None and hasattr(catalog, "_session")
         assert len(catalog._session.adapters) == self.EXPECTED_ADAPTERS_SIGV4
 
-    def test_scan_planning_disabled_by_default(self, rest_mock: Mocker) -> None:
+    def test_rest_scan_planning_disabled_by_default(self, rest_mock: Mocker) -> None:
         rest_mock.get(
             f"{TEST_URI}v1/config",
             json={"defaults": {}, "overrides": {}},
             status_code=200,
         )
         catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
 
-        assert catalog.is_scan_planning_enabled() is False
+        assert catalog.is_rest_scan_planning_enabled() is False
 
-    def test_scan_planning_enabled_by_property(self, rest_mock: Mocker) -> None:
+    def test_rest_scan_planning_enabled_by_property(self, rest_mock: Mocker) -> None:
         rest_mock.get(
             f"{TEST_URI}v1/config",
             json={"defaults": {}, "overrides": {}},
@@ -2017,9 +2017,9 @@ def test_scan_planning_enabled_by_property(self, rest_mock: Mocker) -> None:
             **{"rest-scan-planning-enabled": "true"},
         )
 
-        assert catalog.is_scan_planning_enabled() is True
+        assert catalog.is_rest_scan_planning_enabled() is True
 
-    def test_scan_planning_explicitly_disabled(self, rest_mock: Mocker) -> None:
+    def test_rest_scan_planning_explicitly_disabled(self, rest_mock: Mocker) -> None:
         rest_mock.get(
             f"{TEST_URI}v1/config",
             json={"defaults": {}, "overrides": {}},
@@ -2029,17 +2029,17 @@ def test_scan_planning_explicitly_disabled(self, rest_mock: Mocker) -> None:
             "rest",
             uri=TEST_URI,
             token=TEST_TOKEN,
-            **{"rest.scan-planning.enabled": "false"},
+            **{"rest-scan-planning-enabled": "false"},
         )
 
-        assert catalog.is_scan_planning_enabled() is False
+        assert catalog.is_rest_scan_planning_enabled() is False
 
-    def test_scan_planning_enabled_from_server_config(self, rest_mock: Mocker) -> None:
+    def test_rest_scan_planning_enabled_from_server_config(self, rest_mock: Mocker) -> None:
         rest_mock.get(
             f"{TEST_URI}v1/config",
             json={"defaults": {"rest-scan-planning-enabled": "true"}, "overrides": {}},
             status_code=200,
         )
         catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
 
-        assert catalog.is_scan_planning_enabled() is True
+        assert catalog.is_rest_scan_planning_enabled() is True