Cleanup

Author: Fokko

pyiceberg/manifest.py

@@ -1132,7 +1132,6 @@ def add_entry(self, entry: ManifestEntry) -> ManifestWriter:
             self._deleted_files += 1
             self._deleted_rows += entry.data_file.record_count
         else:
-            entry
             raise ValueError(f"Unknown entry: {entry.status}")
 
         self._partitions.append(entry.data_file.partition)

pyiceberg/table/update/snapshot.py

@@ -218,14 +218,11 @@ def _write_delete_manifest() -> List[ManifestFile]:
 
         executor = ExecutorFactory.get_or_create()
 
-        # added_manifests = executor.submit(_write_added_manifest)
-        # delete_manifests = executor.submit(_write_delete_manifest)
-        # existing_manifests = executor.submit(self._existing_manifests)
-        added_manifests = _write_added_manifest()
-        delete_manifests = _write_delete_manifest()
-        existing_manifests = self._existing_manifests()
-
-        return self._process_manifests(added_manifests + delete_manifests + existing_manifests)
+        added_manifests = executor.submit(_write_added_manifest)
+        delete_manifests = executor.submit(_write_delete_manifest)
+        existing_manifests = executor.submit(self._existing_manifests)
+
+        return self._process_manifests(added_manifests.result() + delete_manifests.result() + existing_manifests.result())
 
     def _summary(self, snapshot_properties: Dict[str, str] = EMPTY_DICT) -> Summary:
         from pyiceberg.table import TableProperties