update error handling for StatsAggregator

Author: james5418

pyiceberg/io/pyarrow.py

@@ -1982,13 +1982,11 @@ class StatsAggregator:
     current_min: Any
     current_max: Any
     trunc_length: Optional[int]
-    column_name: Optional[str]
 
-    def __init__(self, iceberg_type: PrimitiveType, physical_type_string: str, trunc_length: Optional[int] = None, column_name: Optional[str] = None) -> None:
+    def __init__(self, iceberg_type: PrimitiveType, physical_type_string: str, trunc_length: Optional[int] = None) -> None:
         self.current_min = None
         self.current_max = None
         self.trunc_length = trunc_length
-        self.column_name = column_name
 
         expected_physical_type = _primitive_to_physical(iceberg_type)
         if expected_physical_type != physical_type_string:
@@ -2000,7 +1998,7 @@ def __init__(self, iceberg_type: PrimitiveType, physical_type_string: str, trunc
                 pass
             else:
                 raise ValueError(
-                    f"Unexpected physical type {physical_type_string} for {self.column_name or '<unknown column>'} with iceberg type {iceberg_type}, expected {expected_physical_type}"
+                    f"Unexpected physical type {physical_type_string} for {iceberg_type}, expected {expected_physical_type}"
                 )
 
         self.primitive_type = iceberg_type
@@ -2406,9 +2404,12 @@ def data_file_statistics_from_parquet_metadata(
                         continue
 
                     if field_id not in col_aggs:
-                        col_aggs[field_id] = StatsAggregator(
-                            stats_col.iceberg_type, statistics.physical_type, stats_col.mode.length, stats_col.column_name
-                        )
+                        try:
+                            col_aggs[field_id] = StatsAggregator(
+                                stats_col.iceberg_type, statistics.physical_type, stats_col.mode.length
+                            )
+                        except ValueError as e:
+                            raise ValueError(f"{e} for column '{stats_col.column_name}'") from e
 
                     if isinstance(stats_col.iceberg_type, DecimalType) and statistics.physical_type != "FIXED_LEN_BYTE_ARRAY":
                         scale = stats_col.iceberg_type.scale

tests/io/test_pyarrow.py

@@ -2054,7 +2054,7 @@ def test_make_compatible_name() -> None:
     ],
 )
 def test_stats_aggregator_update_min(vals: List[Any], primitive_type: PrimitiveType, expected_result: Any) -> None:
-    stats = StatsAggregator(primitive_type, _primitive_to_physical(primitive_type), column_name="test_col")
+    stats = StatsAggregator(primitive_type, _primitive_to_physical(primitive_type))
 
     for val in vals:
         stats.update_min(val)
@@ -2074,7 +2074,7 @@ def test_stats_aggregator_update_min(vals: List[Any], primitive_type: PrimitiveT
     ],
 )
 def test_stats_aggregator_update_max(vals: List[Any], primitive_type: PrimitiveType, expected_result: Any) -> None:
-    stats = StatsAggregator(primitive_type, _primitive_to_physical(primitive_type), column_name="test_col")
+    stats = StatsAggregator(primitive_type, _primitive_to_physical(primitive_type))
 
     for val in vals:
         stats.update_max(val)