chore: lint

Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>

Author: Shreyas220

table/dv/roaring_bitmap.go

@@ -34,7 +34,7 @@ import (
 // deserialization. This prevents CPU/memory exhaustion from absurd counts
 // in malformed input. Derived from puffin.DefaultMaxBlobSize / 8 (minimum
 // per-bitmap overhead: 4-byte key + at least 4 bytes of roaring data).
-var maxBitmapCount = int64(puffin.DefaultMaxBlobSize / 8)
+var maxBitmapCount = uint64(puffin.DefaultMaxBlobSize / 8)
 
 // RoaringPositionBitmap supports 64-bit positions using a sparse map of
 // 32-bit Roaring bitmaps. Positions are split into a 32-bit key
@@ -53,9 +53,7 @@ func NewRoaringPositionBitmap() *RoaringPositionBitmap {
 }
 
 // Set marks a position in the bitmap.
-// Position must be non-negative.
 func (b *RoaringPositionBitmap) Set(pos uint64) {
-
 	key := uint32(pos >> 32)
 	low := uint32(pos)
 	bm, ok := b.bitmaps[key]
@@ -127,13 +125,10 @@ func (b *RoaringPositionBitmap) Serialize(w io.Writer) error {
 func DeserializeRoaringPositionBitmap(data []byte) (*RoaringPositionBitmap, error) {
 	r := bytes.NewReader(data)
 
-	var count int64
+	var count uint64
 	if err := binary.Read(r, binary.LittleEndian, &count); err != nil {
 		return nil, fmt.Errorf("read bitmap count: %w", err)
 	}
-	if count < 0 {
-		return nil, fmt.Errorf("invalid bitmap count: %d", count)
-	}
 	if count > maxBitmapCount {
 		return nil, fmt.Errorf("bitmap count %d exceeds maximum allowed %d", count, maxBitmapCount)
 	}

table/dv/roaring_bitmap_test.go

@@ -79,15 +79,17 @@ func TestDeserializeRoaringBitmapTruncatedInput(t *testing.T) {
 	assert.ErrorContains(t, err, "read bitmap count")
 }
 
-// Why: negative bitmap counts are invalid and should be rejected before any further decoding.
-// Condition: count field encoded as -1.
-// Assertion: returns an error containing "invalid bitmap count".
-func TestDeserializeRoaringBitmapNegativeCount(t *testing.T) {
+// Why: counts with the high bit set (e.g. an int64 -1 written to disk) decode
+// as a huge uint64 and must be rejected by the upper-bound check, not silently
+// accepted as a small value or panicked on by make(map, hugeHint).
+// Condition: count field encoded as int64(-1) (= 0xFFFF_FFFF_FFFF_FFFF on disk).
+// Assertion: returns an error containing "exceeds maximum".
+func TestDeserializeRoaringBitmapHighBitCount(t *testing.T) {
 	var buf bytes.Buffer
 	require.NoError(t, binary.Write(&buf, binary.LittleEndian, int64(-1)))
 
 	_, err := DeserializeRoaringPositionBitmap(buf.Bytes())
-	assert.ErrorContains(t, err, "invalid bitmap count")
+	assert.ErrorContains(t, err, "exceeds maximum")
 }
 
 // Why: absurdly large counts should be rejected to prevent CPU/memory exhaustion.