Skip to content

Commit a6e8bcc

Browse files
chore: minor cleanup - fix comment language and import order
* chore: translate Chinese comment to English in GraphApplications error handling * chore: reorder imports in service_provider_metadata.go
1 parent 2186028 commit a6e8bcc

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

pkg/console/service/application.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ func GraphApplications(ctx consolectx.Context, req *model.ApplicationGraphReq) (
216216
},
217217
)
218218
if err != nil {
219-
// manager.ListByIndexes 内部已经有合适的 error 返回,直接透传即可
219+
// manager.ListByIndexes An appropriate error has already been generated internally; simply pass it through directly.
220220
return nil, err
221221
}
222222

pkg/core/discovery/subscriber/service_provider_metadata.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ import (
2222
"sort"
2323
"strings"
2424

25+
"k8s.io/client-go/tools/cache"
26+
2527
meshproto "github.com/apache/dubbo-admin/api/mesh/v1alpha1"
2628
"github.com/apache/dubbo-admin/pkg/common/bizerror"
2729
"github.com/apache/dubbo-admin/pkg/core/events"
@@ -30,7 +32,6 @@ import (
3032
coremodel "github.com/apache/dubbo-admin/pkg/core/resource/model"
3133
"github.com/apache/dubbo-admin/pkg/core/store"
3234
"github.com/apache/dubbo-admin/pkg/core/store/index"
33-
"k8s.io/client-go/tools/cache"
3435
)
3536

3637
type ServiceProviderMetadataEventSubscriber struct {

0 commit comments

Comments
 (0)