[Improvement-18056] Clean up unused methods and classes in the dolphinschudler-dao module (#18153)

Author: njnu-seafish

dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DependentWorkflowDefinition.java

@@ -17,14 +17,6 @@
 
 package org.apache.dolphinscheduler.dao.entity;
 
-import org.apache.dolphinscheduler.common.enums.CycleEnum;
-import org.apache.dolphinscheduler.common.utils.JSONUtils;
-import org.apache.dolphinscheduler.plugin.task.api.model.DependentItem;
-import org.apache.dolphinscheduler.plugin.task.api.model.DependentTaskModel;
-import org.apache.dolphinscheduler.plugin.task.api.parameters.DependentParameters;
-
-import java.util.List;
-
 import lombok.Data;
 
 @Data
@@ -40,46 +32,4 @@ public class DependentWorkflowDefinition {
 
     private String workerGroup;
 
-    public CycleEnum getDependentCycle(long upstreamProcessDefinitionCode) {
-        DependentParameters dependentParameters = this.getDependentParameters();
-        List<DependentTaskModel> dependentTaskModelList = dependentParameters.getDependence().getDependTaskList();
-
-        for (DependentTaskModel dependentTaskModel : dependentTaskModelList) {
-            List<DependentItem> dependentItemList = dependentTaskModel.getDependItemList();
-            for (DependentItem dependentItem : dependentItemList) {
-                if (upstreamProcessDefinitionCode == dependentItem.getDefinitionCode()) {
-                    return cycle2CycleEnum(dependentItem.getCycle());
-                }
-            }
-        }
-
-        return CycleEnum.DAY;
-    }
-
-    public CycleEnum cycle2CycleEnum(String cycle) {
-        CycleEnum cycleEnum = null;
-
-        switch (cycle) {
-            case "day":
-                cycleEnum = CycleEnum.DAY;
-                break;
-            case "hour":
-                cycleEnum = CycleEnum.HOUR;
-                break;
-            case "week":
-                cycleEnum = CycleEnum.WEEK;
-                break;
-            case "month":
-                cycleEnum = CycleEnum.MONTH;
-                break;
-            default:
-                break;
-        }
-        return cycleEnum;
-    }
-
-    public DependentParameters getDependentParameters() {
-        return JSONUtils.parseObject(taskParams, DependentParameters.class);
-    }
-
 }

dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/AlertGroupMapper.java

@@ -81,15 +81,6 @@ IPage<AlertGroup> queryAlertGroupPage(Page page,
      */
     String queryAlertGroupInstanceIdsById(@Param("alertGroupId") int alertGroupId);
 
-    /**
-     * list authorized AlertGroup
-     * @param userId
-     * @param alertGroupsIds
-     * @return
-     */
-    <T> List<AlertGroup> listAuthorizedAlertGroupList(@Param("userId") int userId,
-                                                      @Param("alertGroupsIds") List<Integer> alertGroupsIds);
-
     /**
      * queryAlertGroupPageByIds
      * @param page

dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/DataSourceMapper.java

@@ -90,15 +90,6 @@ IPage<DataSource> selectPaging(IPage<DataSource> page,
     <T> List<DataSource> listAuthorizedDataSource(@Param("userId") int userId,
                                                   @Param("dataSourceIds") T[] dataSourceIds);
 
-    /**
-     * query datasource by name and user id
-     *
-     * @param userId userId
-     * @param name   datasource name
-     * @return If the name does not exist or the user does not have permission, it will return null
-     */
-    DataSource queryDataSourceByNameAndUserId(@Param("userId") int userId, @Param("name") String name);
-
     /**
      * selectPagingByIds
      * @param dataSourcePage

dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/K8sNamespaceMapper.java

@@ -50,14 +50,6 @@ IPage<K8sNamespace> queryK8sNamespacePaging(IPage<K8sNamespace> page,
      */
     Boolean existNamespace(@Param("namespace") String namespace, @Param("clusterCode") Long clusterCode);
 
-    /**
-     * query namespace except userId
-     *
-     * @param userId userId
-     * @return namespace list
-     */
-    List<K8sNamespace> queryNamespaceExceptUserId(@Param("userId") int userId);
-
     /**
      * query authed namespace list by userId
      *
@@ -66,11 +58,4 @@ IPage<K8sNamespace> queryK8sNamespacePaging(IPage<K8sNamespace> page,
      */
     List<K8sNamespace> queryAuthedNamespaceListByUserId(@Param("userId") Integer userId);
 
-    /**
-     * check the target namespace
-     *
-     * @param namespaceCode namespaceCode
-     * @return true if exist else return null
-     */
-    K8sNamespace queryByNamespaceCode(@Param("clusterCode") Long namespaceCode);
 }

dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/K8sNamespaceUserMapper.java

@@ -38,13 +38,4 @@ public interface K8sNamespaceUserMapper extends BaseMapper<K8sNamespaceUser> {
     int deleteNamespaceRelation(@Param("namespaceId") int namespaceId,
                                 @Param("userId") int userId);
 
-    /**
-     * query namespace relation
-     *
-     * @param namespaceId namespaceId
-     * @param userId      userId
-     * @return namespace user relation
-     */
-    K8sNamespaceUser queryNamespaceRelation(@Param("namespaceId") int namespaceId,
-                                            @Param("userId") int userId);
 }

dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProjectMapper.java

@@ -52,13 +52,6 @@ public interface ProjectMapper extends BaseMapper<Project> {
      */
     Project queryDetailById(@Param("projectId") int projectId);
 
-    /**
-     * query project detail by code
-     * @param projectCode projectCode
-     * @return project
-     */
-    Project queryDetailByCode(@Param("projectCode") long projectCode);
-
     /**
      * query project by name
      * @param projectName projectName
@@ -91,13 +84,6 @@ IPage<Project> queryProjectListPaging(IPage<Project> page,
      */
     List<Project> queryAuthedProjectListByUserId(@Param("userId") int userId);
 
-    /**
-     * query relation project list by userId
-     * @param userId userId
-     * @return project list
-     */
-    List<Project> queryRelationProjectListByUserId(@Param("userId") int userId);
-
     /**
      * query project except userId
      * @param userId userId
@@ -130,7 +116,6 @@ IPage<Project> queryProjectListPaging(IPage<Project> page,
      * list authorized Projects
      * @param userId
      * @param projectsIds
-     * @param <T>
      * @return
      */
     List<Project> listAuthorizedProjects(@Param("userId") int userId, @Param("projectsIds") List<Integer> projectsIds);
@@ -148,10 +133,4 @@ IPage<Project> queryProjectListPaging(IPage<Project> page,
      */
     Project queryProjectByTaskInstanceId(@Param("taskInstanceId") int taskInstanceId);
 
-    /**
-     * query all workflow count
-     * @param projectsCodes projectsCodes
-     * @return workflow count
-     */
-    int queryAllWorkflowCounts(@Param("projectsCodes") List<Long> projectsCodes);
 }

dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/RelationSubWorkflowMapper.java

@@ -32,6 +32,4 @@ public interface RelationSubWorkflowMapper extends BaseMapper<RelationSubWorkflo
     List<RelationSubWorkflow> queryAllSubWorkflowInstance(@Param("parentWorkflowInstanceId") Long parentWorkflowInstanceId,
                                                           @Param("parentTaskCode") Long parentTaskCode);
 
-    RelationSubWorkflow queryParentWorkflowInstance(@Param("subWorkflowInstanceId") Long subWorkflowInstanceId);
-
 }

dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ScheduleMapper.java

@@ -69,16 +69,6 @@ IPage<Schedule> queryByProjectAndWorkflowDefinitionCodePaging(IPage<Schedule> pa
                                                                   @Param("workflowDefinitionCode") long workflowDefinitionCode,
                                                                   @Param("searchVal") String searchVal);
 
-    /**
-     * Filter schedule
-     *
-     * @param page page
-     * @param schedule schedule
-     * @return schedule IPage
-     */
-    IPage<Schedule> filterSchedules(IPage<Schedule> page,
-                                    @Param("schedule") Schedule schedule);
-
     /**
      * query schedule list by project name
      *

dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskDefinitionMapper.java

@@ -19,7 +19,6 @@
 
 import org.apache.dolphinscheduler.dao.entity.TaskDefinition;
 import org.apache.dolphinscheduler.dao.entity.TaskDefinitionLog;
-import org.apache.dolphinscheduler.dao.entity.TaskMainInfo;
 import org.apache.dolphinscheduler.dao.model.WorkflowDefinitionCountDto;
 
 import org.apache.ibatis.annotations.Param;
@@ -28,7 +27,6 @@
 import java.util.List;
 
 import com.baomidou.mybatisplus.core.mapper.BaseMapper;
-import com.baomidou.mybatisplus.core.metadata.IPage;
 
 public interface TaskDefinitionMapper extends BaseMapper<TaskDefinition> {
 
@@ -84,15 +82,6 @@ TaskDefinition queryByName(@Param("projectCode") long projectCode,
      */
     int batchInsert(@Param("taskDefinitions") List<TaskDefinitionLog> taskDefinitions);
 
-    /**
-     * task main info
-     * @param projectCode project code
-     * @param codeList code list
-     * @return task main info
-     */
-    List<TaskMainInfo> queryDefineListByCodeList(@Param("projectCode") long projectCode,
-                                                 @Param("codeList") List<Long> codeList);
-
     /**
      * query task definition by code list
      *
@@ -101,16 +90,6 @@ List<TaskMainInfo> queryDefineListByCodeList(@Param("projectCode") long projectC
      */
     List<TaskDefinition> queryByCodeList(@Param("codes") Collection<Long> codes);
 
-    /**
-     * Filter task definition
-     *
-     * @param page page
-     * @param taskDefinition task definition
-     * @return task definition IPage
-     */
-    IPage<TaskDefinition> filterTaskDefinition(IPage<TaskDefinition> page,
-                                               @Param("task") TaskDefinition taskDefinition);
-
     /**
      * batch delete task by task code
      *

dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskGroupQueueMapper.java

@@ -36,18 +36,6 @@
  */
 public interface TaskGroupQueueMapper extends BaseMapper<TaskGroupQueue> {
 
-    /**
-     * select task group queues by some conditions
-     *
-     * @param page    page
-     * @param groupId group id
-     * @return task group queue list
-     */
-    IPage<TaskGroupQueue> queryTaskGroupQueuePaging(IPage<TaskGroupQueue> page,
-                                                    @Param("groupId") int groupId);
-
-    TaskGroupQueue queryByTaskId(@Param("taskId") int taskId);
-
     /**
      * query by status
      *
@@ -73,24 +61,6 @@ IPage<TaskGroupQueue> queryTaskGroupQueuePaging(IPage<TaskGroupQueue> page,
      */
     int updateStatusByTaskId(@Param("taskId") int taskId, @Param("status") int status);
 
-    /**
-     * Query the {@link TaskGroupQueue}, who's priority > the given <code>priority</code>
-     */
-    List<TaskGroupQueue> queryHighPriorityTasks(@Param("groupId") int groupId, @Param("priority") int priority,
-                                                @Param("status") int status);
-
-    TaskGroupQueue queryTheHighestPriorityTasks(@Param("groupId") int groupId, @Param("status") int status,
-                                                @Param("forceStart") int forceStart, @Param("inQueue") int inQueue);
-
-    void updateInQueue(@Param("inQueue") int inQueue, @Param("id") int id);
-
-    void updateForceStart(@Param("queueId") int queueId, @Param("forceStart") int forceStart);
-
-    int updateInQueueLimit1(@Param("oldValue") int oldValue, @Param("newValue") int newValue, @Param("groupId") int id,
-                            @Param("status") int status);
-
-    int updateInQueueCAS(@Param("oldValue") int oldValue, @Param("newValue") int newValue, @Param("id") int id);
-
     void modifyPriority(@Param("queueId") int queueId, @Param("priority") int priority);
 
     IPage<TaskGroupQueue> queryTaskGroupQueueByTaskGroupIdPaging(Page<TaskGroupQueue> page,
@@ -100,17 +70,12 @@ IPage<TaskGroupQueue> queryTaskGroupQueueByTaskGroupIdPaging(Page<TaskGroupQueue
                                                                  @Param("groupId") int groupId,
                                                                  @Param("projects") List<Project> projects);
 
-    void deleteByTaskInstanceIds(@Param("taskInstanceIds") List<Integer> taskInstanceIds);
-
     void deleteByWorkflowInstanceId(@Param("workflowInstanceId") Integer workflowInstanceId);
 
     void deleteByWorkflowInstanceIds(@Param("workflowInstanceIds") List<Integer> workflowInstanceIds);
 
     void deleteByTaskGroupIds(@Param("taskGroupIds") List<Integer> taskGroupIds);
 
-    void updateTaskGroupPriorityByTaskInstanceId(@Param("taskInstanceId") Integer taskInstanceId,
-                                                 @Param("priority") int taskGroupPriority);
-
     List<TaskGroupQueue> queryAllInQueueTaskGroupQueueByGroupId(@Param("taskGroupId") Integer taskGroupId,
                                                                 @Param("inQueue") int inQueue);