[Improvement-18056] Clean up unused methods and classes in the dolphinschudler-common module (#18147)

Author: njnu-seafish

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/CommandKeyConstants.java

@@ -31,22 +31,8 @@ public class CommandKeyConstants {
 
     public static final String CMD_PARAM_START_NODES = "StartNodeList";
 
-    public static final String CMD_PARAM_START_PARAMS = "StartParams";
-
-    public static final String CMD_PARAM_FATHER_PARAMS = "fatherParams";
-
     public static final String CMD_DYNAMIC_START_PARAMS = "dynamicParams";
 
-    /**
-     * complement data start date
-     */
-    public static final String CMD_PARAM_COMPLEMENT_DATA_START_DATE = "complementStartDate";
-
-    /**
-     * complement data end date
-     */
-    public static final String CMD_PARAM_COMPLEMENT_DATA_END_DATE = "complementEndDate";
-
     /**
      * complement data Schedule date
      */

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/Constants.java

@@ -120,9 +120,6 @@ public final class Constants {
      */
     public static final String SEMICOLON = ";";
 
-    public static final String ADDRESS = "address";
-    public static final String DATABASE = "database";
-
     public static final String IMPORT_SUFFIX = "_import_";
 
     public static final String COPY_SUFFIX = "_copy_";
@@ -209,8 +206,6 @@ public final class Constants {
     public static final String THREAD_NAME_WORKER_SERVER = "Worker-Server";
     public static final String THREAD_NAME_ALERT_SERVER = "Alert-Server";
 
-    // suffix of crc file
-
     /**
      * complement date default cron string
      */
@@ -466,8 +461,6 @@ public final class Constants {
 
     public static final String REMOTE_LOGGING_BASE_DIR = "remote.logging.base.dir";
 
-    public static final String REMOTE_LOGGING_THREAD_POOL_SIZE = "remote.logging.thread.pool.size";
-
     /**
      * remote logging for OSS
      */

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/DbConnectType.java

@@ -17,10 +17,6 @@
 
 package org.apache.dolphinscheduler.common.enums;
 
-import java.util.List;
-
-import com.google.common.collect.Lists;
-
 public enum ProfileType {
     ;
 
@@ -30,5 +26,4 @@ public enum ProfileType {
 
     public static final String POSTGRESQL = "postgresql";
 
-    public static final List<String> DATASOURCE_PROFILE = Lists.newArrayList(H2, MYSQL, POSTGRESQL);
 }

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ProfileType.java

@@ -496,15 +496,6 @@ private Map.Entry<Boolean, List<Node>> topologicalSortImpl() {
         return new AbstractMap.SimpleEntry<>(notZeroIndegreeNodeMap.size() == 0, topoResultList);
     }
 
-    /**
-     * Get all the nodes that are in the graph
-     *
-     * @return all nodes in the graph
-     */
-    public Set<Node> getAllNodesList() {
-        return nodesMap.keySet();
-    }
-
     @Override
     public String toString() {
         return "DAG{"

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/graph/DAG.java

@@ -23,7 +23,4 @@ public ServerLifeCycleException(String message) {
         super(message);
     }
 
-    public ServerLifeCycleException(String message, Throwable throwable) {
-        super(message, throwable);
-    }
 }

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/lifecycle/ServerLifeCycleException.java

@@ -36,10 +36,6 @@ public static void toRunning() {
         serverStatus = ServerStatus.RUNNING;
     }
 
-    public static boolean isRunning() {
-        return serverStatus == ServerStatus.RUNNING;
-    }
-
     public static boolean isStopped() {
         return serverStatus == ServerStatus.STOPPED;
     }
@@ -48,39 +44,6 @@ public static ServerStatus getServerStatus() {
         return serverStatus;
     }
 
-    /**
-     * Change the current server state to {@link ServerStatus#WAITING}, only {@link ServerStatus#RUNNING} can change to {@link ServerStatus#WAITING}.
-     *
-     * @throws ServerLifeCycleException if change failed.
-     */
-    public static synchronized void toWaiting() throws ServerLifeCycleException {
-        if (isStopped()) {
-            throw new ServerLifeCycleException("The current server is already stopped, cannot change to waiting");
-        }
-
-        if (serverStatus == ServerStatus.WAITING) {
-            log.warn("The current server is already at waiting status, cannot change to waiting");
-            return;
-        }
-        serverStatus = ServerStatus.WAITING;
-    }
-
-    /**
-     * Recover from {@link ServerStatus#WAITING} to {@link ServerStatus#RUNNING}.
-     */
-    public static synchronized void recoverFromWaiting() throws ServerLifeCycleException {
-        if (isStopped()) {
-            throw new ServerLifeCycleException("The current server is already stopped, cannot recovery");
-        }
-
-        if (serverStatus == ServerStatus.RUNNING) {
-            log.warn("The current server status is already running, cannot recover form waiting");
-            return;
-        }
-        serverStartupTime = System.currentTimeMillis();
-        serverStatus = ServerStatus.RUNNING;
-    }
-
     public static synchronized boolean toStopped() {
         if (serverStatus == ServerStatus.STOPPED) {
             return false;

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/lifecycle/ServerLifeCycleManager.java

@@ -23,7 +23,6 @@
 public enum ServerStatus {
 
     RUNNING(0, "The current server is running"),
-    WAITING(1, "The current server is waiting, this means it cannot work"),
     STOPPED(2, "The current server is stopped"),
     ;
 

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/lifecycle/ServerStatus.java

@@ -40,6 +40,7 @@ public class RemoteLogUtils {
 
     @Autowired
     private RemoteLogService autowiredRemoteLogService;
+
     @PostConstruct
     private void init() {
         remoteLogService = autowiredRemoteLogService;

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/log/remote/RemoteLogUtils.java

@@ -22,7 +22,6 @@
 import java.io.IOException;
 import java.io.InputStreamReader;
 import java.util.Map;
-import java.util.Set;
 import java.util.Timer;
 import java.util.TimerTask;
 import java.util.concurrent.ConcurrentHashMap;
@@ -44,6 +43,7 @@ public abstract class AbstractShell {
      * Time after which the executing script would be timedout
      */
     protected long timeOutInterval = 0L;
+
     /**
      * If or not script timed out
      */
@@ -63,12 +63,14 @@ public abstract class AbstractShell {
      * env for the command execution
      */
     private Map<String, String> environment;
+
     private File dir;
 
     /**
      * sub process used to execute the command
      */
     private Process process;
+
     private int exitCode;
 
     /**
@@ -251,13 +253,6 @@ public Process getProcess() {
         return process;
     }
 
-    /** get the exit code
-     * @return the exit code of the process
-     */
-    public int getExitCode() {
-        return exitCode;
-    }
-
     /**
      * Set if the command has timed out.
      *
@@ -306,9 +301,6 @@ public ExitCodeException(int exitCode, String message) {
             this.exitCode = exitCode;
         }
 
-        public int getExitCode() {
-            return exitCode;
-        }
     }
 
     /**
@@ -331,25 +323,9 @@ public static void putProcess(Process process) {
             getInstance().put(process.hashCode(), process);
         }
 
-        public static int processSize() {
-            return getInstance().size();
-        }
-
         public static void removeProcess(Process process) {
             getInstance().remove(process.hashCode());
         }
 
-        public static void destroyAllProcess() {
-            Set<Entry<Integer, Process>> set = getInstance().entrySet();
-            for (Entry<Integer, Process> entry : set) {
-                try {
-                    entry.getValue().destroy();
-                } catch (Exception e) {
-                    log.error("Destroy All Processes error", e);
-                }
-            }
-
-            log.info("close " + set.size() + " executing process tasks");
-        }
     }
 }