add test for replaceInNodeList

Author: 苏义超

dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImplTest.java

@@ -30,10 +30,15 @@
 
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Consumer;
+import java.util.function.Supplier;
 
 import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
@@ -186,7 +191,102 @@ void testReplaceTaskCodeForConditionTaskParams_throwsOnInvalidJson() {
                 .hasMessageContaining("Failed to parse Condition task params");
     }
 
-    // Reflection Helper
+    @Test
+    void testReplaceInNodeList_withNullList() throws Exception {
+        AtomicReference<List<Long>> stateRef = new AtomicReference<>(null);
+        Supplier<List<Long>> getter = stateRef::get;
+        Consumer<List<Long>> setter = stateRef::set;
+
+        invokeReplaceInNodeList(getter, setter, Collections.emptyMap());
+
+        assertThat(stateRef.get()).isNull();
+    }
+
+    @Test
+    void testReplaceInNodeList_withEmptyList() throws Exception {
+        AtomicReference<List<Long>> stateRef = new AtomicReference<>(new ArrayList<>());
+        Supplier<List<Long>> getter = stateRef::get;
+        Consumer<List<Long>> setter = stateRef::set;
+
+        invokeReplaceInNodeList(getter, setter, Collections.emptyMap());
+
+        assertThat(stateRef.get()).isEmpty();
+    }
+
+    @Test
+    void testReplaceInNodeList_replacesMappedCodes() throws Exception {
+        AtomicReference<List<Long>> stateRef = new AtomicReference<>(new ArrayList<>(Arrays.asList(1L, 2L, 3L)));
+        Supplier<List<Long>> getter = stateRef::get;
+        Consumer<List<Long>> setter = stateRef::set;
+
+        Map<Long, Long> codeMap = new HashMap<>();
+        codeMap.put(1L, 10L);
+        codeMap.put(3L, 30L);
+
+        invokeReplaceInNodeList(getter, setter, codeMap);
+
+        assertThat(stateRef.get()).containsExactly(10L, 2L, 30L);
+    }
+
+    @Test
+    void testReplaceInNodeList_preservesUnmappedAndNullElements() throws Exception {
+        AtomicReference<List<Long>> stateRef =
+                new AtomicReference<>(new ArrayList<>(Arrays.asList(null, 4L, 5L, null)));
+        Supplier<List<Long>> getter = stateRef::get;
+        Consumer<List<Long>> setter = stateRef::set;
+
+        Map<Long, Long> codeMap = new HashMap<>();
+        codeMap.put(4L, 40L);
+
+        invokeReplaceInNodeList(getter, setter, codeMap);
+
+        assertThat(stateRef.get()).containsExactly((Long) null, 40L, 5L, (Long) null);
+    }
+
+    @Test
+    void testReplaceInNodeList_noOpWhenCodeMapIsEmpty() throws Exception {
+        AtomicReference<List<Long>> stateRef = new AtomicReference<>(new ArrayList<>(Arrays.asList(6L, 7L)));
+        Supplier<List<Long>> getter = stateRef::get;
+        Consumer<List<Long>> setter = stateRef::set;
+
+        invokeReplaceInNodeList(getter, setter, Collections.emptyMap());
+
+        assertThat(stateRef.get()).containsExactly(6L, 7L);
+    }
+
+    @Test
+    void testReplaceInNodeList_createsNewListInstance() throws Exception {
+        List<Long> original = Arrays.asList(8L, 9L);
+        AtomicReference<List<Long>> stateRef = new AtomicReference<>(new ArrayList<>(original));
+        Supplier<List<Long>> getter = stateRef::get;
+        Consumer<List<Long>> setter = stateRef::set;
+
+        invokeReplaceInNodeList(getter, setter, Collections.emptyMap());
+
+        assertThat(stateRef.get()).isNotSameAs(original);
+        assertThat(stateRef.get()).isEqualTo(original);
+    }
+
+    // Reflection Helper to call private replaceInNodeList
+    private void invokeReplaceInNodeList(Supplier<List<Long>> getter,
+                                         Consumer<List<Long>> setter,
+                                         Map<Long, Long> codeMap) throws Exception {
+        Method method = WorkflowDefinitionServiceImpl.class
+                .getDeclaredMethod("replaceInNodeList", Supplier.class, Consumer.class, Map.class);
+        method.setAccessible(true);
+
+        try {
+            method.invoke(workflowDefinitionService, getter, setter, codeMap);
+        } catch (java.lang.reflect.InvocationTargetException e) {
+            Throwable cause = e.getCause();
+            if (cause instanceof RuntimeException) {
+                throw (RuntimeException) cause;
+            }
+            throw new RuntimeException("Exception in private method", cause);
+        }
+    }
+
+    // Reflection Helper to call private replaceTaskCodeForSwitchTaskParams and replaceTaskCodeForConditionTaskParams
     private void invokePrivateMethod(String methodName, Object... args) throws Exception {
         Class<?>[] argTypes = new Class[args.length];
         for (int i = 0; i < args.length; i++) {