Simplify the code with lombok annotations

Author: 苏义超

dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-oceanbase/src/main/java/org/apache/dolphinscheduler/plugin/datasource/oceanbase/param/OceanBaseDataSourceParamDTO.java

@@ -20,20 +20,18 @@
 import org.apache.dolphinscheduler.plugin.datasource.api.datasource.BaseDataSourceParamDTO;
 import org.apache.dolphinscheduler.spi.enums.DbType;
 
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
 public class OceanBaseDataSourceParamDTO extends BaseDataSourceParamDTO {
 
     protected String compatibleMode;
 
-    public String getCompatibleMode() {
-        return compatibleMode;
-    }
-
-    public void setCompatibleMode(String compatibleMode) {
-        this.compatibleMode = compatibleMode;
-    }
-
     @Override
     public DbType getType() {
         return DbType.OCEANBASE;
     }
+
 }

dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/future/ResponseFuture.java

@@ -23,13 +23,13 @@
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
 import lombok.ToString;
 import lombok.extern.slf4j.Slf4j;
 
 @ToString
 @Slf4j
+@Data
 public class ResponseFuture {
 
     private static final ConcurrentHashMap<Long, ResponseFuture> FUTURE_TABLE = new ConcurrentHashMap<>();
@@ -42,8 +42,6 @@ public class ResponseFuture {
 
     private final long beginTimestamp = System.currentTimeMillis();
 
-    @Getter
-    @Setter
     private IRpcResponse iRpcResponse;
 
     private volatile boolean sendOk = true;
@@ -92,16 +90,4 @@ public boolean isSendOK() {
         return sendOk;
     }
 
-    public void setSendOk(boolean sendOk) {
-        this.sendOk = sendOk;
-    }
-
-    public void setCause(Throwable cause) {
-        this.cause = cause;
-    }
-
-    public Throwable getCause() {
-        return cause;
-    }
-
 }

dolphinscheduler-registry/dolphinscheduler-registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/RegistryClient.java

@@ -41,6 +41,8 @@
 import java.util.Optional;
 import java.util.Set;
 
+import lombok.Getter;
+import lombok.Setter;
 import lombok.extern.slf4j.Slf4j;
 
 import org.springframework.stereotype.Component;
@@ -50,6 +52,9 @@
 public class RegistryClient {
 
     private static final String EMPTY = "";
+
+    @Setter
+    @Getter
     private IStoppable stoppable;
 
     private final Registry registry;
@@ -201,14 +206,6 @@ public boolean releaseLock(String key) {
         return registry.releaseLock(key);
     }
 
-    public void setStoppable(IStoppable stoppable) {
-        this.stoppable = stoppable;
-    }
-
-    public IStoppable getStoppable() {
-        return stoppable;
-    }
-
     public Collection<String> getChildrenKeys(final String key) {
         return registry.children(key);
     }

dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/model/TaskNode.java

@@ -17,20 +17,21 @@
 
 package org.apache.dolphinscheduler.service.model;
 
-import org.apache.dolphinscheduler.common.constants.Constants;
 import org.apache.dolphinscheduler.common.enums.Priority;
 import org.apache.dolphinscheduler.common.enums.TaskExecuteType;
 import org.apache.dolphinscheduler.common.utils.JSONUtils;
 
 import org.apache.commons.collections4.CollectionUtils;
-import org.apache.commons.lang3.StringUtils;
 
 import java.util.List;
 import java.util.Objects;
 
+import lombok.Data;
+
 import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
 import com.fasterxml.jackson.databind.annotation.JsonSerialize;
 
+@Data
 public class TaskNode {
 
     /**
@@ -142,98 +143,11 @@ public class TaskNode {
 
     private TaskExecuteType taskExecuteType;
 
-    public String getId() {
-        return id;
-    }
-
-    public void setId(String id) {
-        this.id = id;
-    }
-
-    public String getName() {
-        return name;
-    }
-
-    public void setName(String name) {
-        this.name = name;
-    }
-
-    public String getDesc() {
-        return desc;
-    }
-
-    public void setDesc(String desc) {
-        this.desc = desc;
-    }
-
-    public String getType() {
-        return type;
-    }
-
-    public void setType(String type) {
-        this.type = type;
-    }
-
-    public String getParams() {
-        return params;
-    }
-
-    public void setParams(String params) {
-        this.params = params;
-    }
-
-    public String getPreTasks() {
-        return preTasks;
-    }
-
     public void setPreTasks(String preTasks) {
         this.preTasks = preTasks;
         this.depList = JSONUtils.toList(preTasks, Long.class);
     }
 
-    public String getExtras() {
-        return extras;
-    }
-
-    public void setExtras(String extras) {
-        this.extras = extras;
-    }
-
-    public List<Long> getDepList() {
-        return depList;
-    }
-
-    public void setDepList(List<Long> depList) {
-        if (depList != null) {
-            this.depList = depList;
-            this.preTasks = JSONUtils.toJsonString(depList);
-        }
-    }
-
-    public String getLoc() {
-        return loc;
-    }
-
-    public void setLoc(String loc) {
-        this.loc = loc;
-    }
-
-    public String getRunFlag() {
-        return runFlag;
-    }
-
-    public void setRunFlag(String runFlag) {
-        this.runFlag = runFlag;
-    }
-
-    public boolean isForbidden() {
-        // skip stream task when run DAG
-        if (taskExecuteType == TaskExecuteType.STREAM) {
-            return true;
-        }
-        return StringUtils.isNotEmpty(this.runFlag) && this.runFlag.equals(Constants.FLOWNODE_RUN_FLAG_FORBIDDEN);
-    }
-
     @Override
     public boolean equals(Object o) {
         if (this == o) {
@@ -261,70 +175,6 @@ public int hashCode() {
         return Objects.hash(name, desc, type, params, preTasks, extras, depList, runFlag);
     }
 
-    public int getMaxRetryTimes() {
-        return maxRetryTimes;
-    }
-
-    public void setMaxRetryTimes(int maxRetryTimes) {
-        this.maxRetryTimes = maxRetryTimes;
-    }
-
-    public int getRetryInterval() {
-        return retryInterval;
-    }
-
-    public void setRetryInterval(int retryInterval) {
-        this.retryInterval = retryInterval;
-    }
-
-    public Priority getTaskInstancePriority() {
-        return taskInstancePriority;
-    }
-
-    public void setTaskInstancePriority(Priority taskInstancePriority) {
-        this.taskInstancePriority = taskInstancePriority;
-    }
-
-    public String getTimeout() {
-        return timeout;
-    }
-
-    public void setTimeout(String timeout) {
-        this.timeout = timeout;
-    }
-
-    public String getWorkerGroup() {
-        return workerGroup;
-    }
-
-    public void setWorkerGroup(String workerGroup) {
-        this.workerGroup = workerGroup;
-    }
-
-    public int getDelayTime() {
-        return delayTime;
-    }
-
-    public void setDelayTime(int delayTime) {
-        this.delayTime = delayTime;
-    }
-
-    public long getCode() {
-        return code;
-    }
-
-    public void setCode(long code) {
-        this.code = code;
-    }
-
-    public int getVersion() {
-        return version;
-    }
-
-    public void setVersion(int version) {
-        this.version = version;
-    }
-
     @Override
     public String toString() {
         return "TaskNode{"
@@ -351,51 +201,4 @@ public String toString() {
                 + '}';
     }
 
-    public void setEnvironmentCode(Long environmentCode) {
-        this.environmentCode = environmentCode;
-    }
-
-    public Long getEnvironmentCode() {
-        return this.environmentCode;
-    }
-
-    public int getTaskGroupId() {
-        return taskGroupId;
-    }
-
-    public void setTaskGroupId(int taskGroupId) {
-        this.taskGroupId = taskGroupId;
-    }
-
-    public int getTaskGroupPriority() {
-        return taskGroupPriority;
-    }
-
-    public void setTaskGroupPriority(int taskGroupPriority) {
-        this.taskGroupPriority = taskGroupPriority;
-    }
-
-    public Integer getCpuQuota() {
-        return cpuQuota == null ? -1 : cpuQuota;
-    }
-
-    public void setCpuQuota(Integer cpuQuota) {
-        this.cpuQuota = cpuQuota;
-    }
-
-    public Integer getMemoryMax() {
-        return memoryMax == null ? -1 : memoryMax;
-    }
-
-    public void setMemoryMax(Integer memoryMax) {
-        this.memoryMax = memoryMax;
-    }
-
-    public TaskExecuteType getTaskExecuteType() {
-        return taskExecuteType;
-    }
-
-    public void setTaskExecuteType(TaskExecuteType taskExecuteType) {
-        this.taskExecuteType = taskExecuteType;
-    }
 }