Skip to content

Commit 5a3563b

Browse files
authored
[Improvement-18056] Remove unused code in common module (#18104)
1 parent fbc2f3c commit 5a3563b

15 files changed

Lines changed: 0 additions & 593 deletions

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/CommandKeyConstants.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,6 @@ public class CommandKeyConstants {
2727
*/
2828
public static final String CMD_PARAM_RECOVER_WORKFLOW_ID_STRING = "ProcessInstanceId";
2929

30-
public static final String CMD_PARAM_RECOVERY_START_NODE_STRING = "StartNodeIdList";
31-
32-
public static final String CMD_PARAM_RECOVERY_WAITING_THREAD = "WaitingThreadInstanceId";
33-
34-
public static final String CMD_PARAM_SUB_WORKFLOW = "processInstanceId";
35-
36-
public static final String CMD_PARAM_EMPTY_SUB_PROCESS = "0";
37-
38-
public static final String CMD_PARAM_SUB_WORKFLOW_PARENT_INSTANCE_ID = "parentProcessInstanceId";
39-
4030
public static final String CMD_PARAM_SUB_WORKFLOW_DEFINITION_CODE = "workflowDefinitionCode";
4131

4232
public static final String CMD_PARAM_START_NODES = "StartNodeList";

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/Constants.java

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,6 @@ public final class Constants {
4545
*/
4646
public static final String FS_DEFAULT_FS = "resource.hdfs.fs.defaultFS";
4747

48-
/**
49-
* hdfs/s3 configuration
50-
* resource.storage.upload.base.path
51-
*/
52-
public static final String RESOURCE_UPLOAD_PATH = "resource.storage.upload.base.path";
53-
5448
/**
5549
* data basedir path
5650
*/
@@ -128,9 +122,6 @@ public final class Constants {
128122

129123
public static final String ADDRESS = "address";
130124
public static final String DATABASE = "database";
131-
public static final String OTHER = "other";
132-
public static final String USER = "user";
133-
public static final String JDBC_URL = "jdbcUrl";
134125

135126
public static final String IMPORT_SUFFIX = "_import_";
136127

@@ -219,7 +210,6 @@ public final class Constants {
219210
public static final String THREAD_NAME_ALERT_SERVER = "Alert-Server";
220211

221212
// suffix of crc file
222-
public static final String CRC_SUFFIX = ".crc";
223213

224214
/**
225215
* complement date default cron string
@@ -233,21 +223,6 @@ public final class Constants {
233223

234224
public static final Duration SERVER_CLOSE_WAIT_TIME = Duration.ofSeconds(3);
235225

236-
/**
237-
* jar
238-
*/
239-
public static final String JAR = "jar";
240-
241-
/**
242-
* hadoop
243-
*/
244-
public static final String HADOOP = "hadoop";
245-
246-
/**
247-
* -D <property>=<value>
248-
*/
249-
public static final String D = "-D";
250-
251226
/**
252227
* exit code success
253228
*/
@@ -263,27 +238,16 @@ public final class Constants {
263238
*/
264239
public static final int DEFINITION_FAILURE = -1;
265240

266-
public static final int OPPOSITE_VALUE = -1;
267-
268241
/**
269242
* workflow or task definition first version
270243
*/
271244
public static final int VERSION_FIRST = 1;
272245

273-
/**
274-
* FAILED
275-
*/
276-
public static final String FAILED = "FAILED";
277-
/**
278-
* RUNNING
279-
*/
280-
public static final String RUNNING = "RUNNING";
281246
/**
282247
* underline "_"
283248
*/
284249
public static final String UNDERLINE = "_";
285250

286-
public static final String STAR = "*";
287251
public static final String GLOBAL_PARAMS = "globalParams";
288252
public static final String LOCAL_PARAMS = "localParams";
289253
public static final String SUBWORKFLOW_INSTANCE_ID = "subWorkflowInstanceId";
@@ -345,8 +309,6 @@ public final class Constants {
345309
*/
346310
public static final String SSO_LOGIN_USER_STATE = "sso.login.user.state";
347311

348-
public static final String TASK_INSTANCE_ID_MDC_KEY = "taskInstanceId";
349-
350312
/**
351313
* status
352314
*/
@@ -401,8 +363,6 @@ public final class Constants {
401363
*/
402364
public static final int SESSION_TIME_OUT = 7200;
403365

404-
public static final String CLASS = "class";
405-
406366
/**
407367
* authorize writable perm
408368
*/
@@ -500,11 +460,6 @@ public final class Constants {
500460
/** string no */
501461
public static final String STRING_NO = "NO";
502462

503-
public static final Integer QUERY_ALL_ON_SYSTEM = 0;
504-
public static final Integer QUERY_ALL_ON_PROJECT = 1;
505-
public static final Integer QUERY_ALL_ON_WORKFLOW = 2;
506-
public static final Integer QUERY_ALL_ON_TASK = 3;
507-
508463
public static final String REMOTE_LOGGING_ENABLE = "remote.logging.enable";
509464

510465
public static final String REMOTE_LOGGING_TARGET = "remote.logging.target";

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/DateConstants.java

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@ public class DateConstants {
2929
*/
3030
public static final String YYYYMMDD = "yyyyMMdd";
3131

32-
/**
33-
* date format of yyyyMMddHHmmss
34-
*/
35-
public static final String YYYYMMDDHHMMSS = "yyyyMMddHHmmss";
36-
3732
/**
3833
* date format of yyyyMMddHHmmssSSS
3934
*/
@@ -63,29 +58,4 @@ public class DateConstants {
6358
* system date(yyyymmdd) yesterday
6459
*/
6560
public static final String PARAMETER_BUSINESS_DATE = "system.biz.date";
66-
67-
/**
68-
* month_begin
69-
*/
70-
public static final String MONTH_BEGIN = "month_begin";
71-
/**
72-
* add_months
73-
*/
74-
public static final String ADD_MONTHS = "add_months";
75-
/**
76-
* month_end
77-
*/
78-
public static final String MONTH_END = "month_end";
79-
/**
80-
* week_begin
81-
*/
82-
public static final String WEEK_BEGIN = "week_begin";
83-
/**
84-
* week_end
85-
*/
86-
public static final String WEEK_END = "week_end";
87-
/**
88-
* timestamp
89-
*/
90-
public static final String TIMESTAMP = "timestamp";
9161
}

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ApiTriggerType.java

Lines changed: 0 additions & 47 deletions
This file was deleted.

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/CacheType.java

Lines changed: 0 additions & 40 deletions
This file was deleted.

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ProgramType.java

Lines changed: 0 additions & 31 deletions
This file was deleted.

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/SlotCheckState.java

Lines changed: 0 additions & 23 deletions
This file was deleted.

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/SqoopJobType.java

Lines changed: 0 additions & 43 deletions
This file was deleted.

0 commit comments

Comments
 (0)