Skip to content

Commit 5314ac0

Browse files
authored
[Improvement-18056] Clean up unused methods and classes in the dolphinschudler-registry module (#18165)
1 parent 94bfbb0 commit 5314ac0

5 files changed

Lines changed: 0 additions & 57 deletions

File tree

dolphinscheduler-registry/dolphinscheduler-registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/ConnectStrategy.java

Lines changed: 0 additions & 29 deletions
This file was deleted.

dolphinscheduler-registry/dolphinscheduler-registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/RegistryClient.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import org.apache.commons.lang3.StringUtils;
3232

3333
import java.io.IOException;
34-
import java.time.Duration;
3534
import java.util.ArrayList;
3635
import java.util.Collection;
3736
import java.util.Date;
@@ -42,7 +41,6 @@
4241
import java.util.Optional;
4342
import java.util.Set;
4443

45-
import lombok.NonNull;
4644
import lombok.extern.slf4j.Slf4j;
4745

4846
import org.springframework.stereotype.Component;
@@ -77,10 +75,6 @@ public boolean isConnected() {
7775

7876
}
7977

80-
public void connectUntilTimeout(@NonNull Duration duration) throws RegistryException {
81-
registry.connectUntilTimeout(duration);
82-
}
83-
8478
public List<Server> getServerList(RegistryNodeType registryNodeType) {
8579
Map<String, String> serverMaps = getServerMaps(registryNodeType);
8680

dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-jdbc/src/main/java/org/apache/dolphinscheduler/plugin/registry/jdbc/repository/JdbcRegistryDataRepository.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,8 @@
1919

2020
import org.apache.dolphinscheduler.plugin.registry.jdbc.mapper.JdbcRegistryDataMapper;
2121
import org.apache.dolphinscheduler.plugin.registry.jdbc.model.DO.JdbcRegistryData;
22-
import org.apache.dolphinscheduler.plugin.registry.jdbc.model.DTO.DataType;
2322
import org.apache.dolphinscheduler.plugin.registry.jdbc.model.DTO.JdbcRegistryDataDTO;
2423

25-
import org.apache.commons.collections4.CollectionUtils;
26-
2724
import java.util.List;
2825
import java.util.Optional;
2926
import java.util.stream.Collectors;
@@ -50,13 +47,6 @@ public Optional<JdbcRegistryDataDTO> selectByKey(String key) {
5047
.map(JdbcRegistryDataDTO::fromJdbcRegistryData);
5148
}
5249

53-
public void deleteEphemeralDateByClientIds(List<Long> clientIds) {
54-
if (CollectionUtils.isEmpty(clientIds)) {
55-
return;
56-
}
57-
jdbcRegistryDataMapper.deleteByClientIds(clientIds, DataType.EPHEMERAL.name());
58-
}
59-
6050
public void deleteByKey(String key) {
6151
jdbcRegistryDataMapper.deleteByKey(key);
6252
}

dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-jdbc/src/main/java/org/apache/dolphinscheduler/plugin/registry/jdbc/repository/JdbcRegistryLockRepository.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
import org.apache.dolphinscheduler.plugin.registry.jdbc.model.DO.JdbcRegistryLock;
2424
import org.apache.dolphinscheduler.plugin.registry.jdbc.model.DTO.JdbcRegistryLockDTO;
2525

26-
import org.apache.commons.collections4.CollectionUtils;
27-
2826
import java.util.List;
2927
import java.util.stream.Collectors;
3028

@@ -44,13 +42,6 @@ public List<JdbcRegistryLockDTO> queryAll() {
4442
.collect(Collectors.toList());
4543
}
4644

47-
public void deleteByClientIds(List<Long> clientIds) {
48-
if (CollectionUtils.isEmpty(clientIds)) {
49-
return;
50-
}
51-
jdbcRegistryLockMapper.deleteByClientIds(clientIds);
52-
}
53-
5445
public void insert(JdbcRegistryLockDTO jdbcRegistryLock) {
5546
checkNotNull(jdbcRegistryLock);
5647
JdbcRegistryLock jdbcRegistryLockDO = JdbcRegistryLockDTO.toJdbcRegistryLock(jdbcRegistryLock);

dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-jdbc/src/main/java/org/apache/dolphinscheduler/plugin/registry/jdbc/server/JdbcRegistryServer.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@ public class JdbcRegistryServer implements IJdbcRegistryServer {
6161

6262
private final JdbcRegistryProperties jdbcRegistryProperties;
6363

64-
private final JdbcRegistryDataRepository jdbcRegistryDataRepository;
65-
6664
private final JdbcRegistryLockRepository jdbcRegistryLockRepository;
6765

6866
private final JdbcRegistryClientRepository jdbcRegistryClientRepository;
@@ -88,7 +86,6 @@ public JdbcRegistryServer(JdbcRegistryDataRepository jdbcRegistryDataRepository,
8886
JdbcRegistryDataChangeEventRepository jdbcRegistryDataChangeEventRepository,
8987
JdbcRegistryProperties jdbcRegistryProperties,
9088
TransactionTemplate transactionTemplate) {
91-
this.jdbcRegistryDataRepository = checkNotNull(jdbcRegistryDataRepository);
9289
this.jdbcRegistryLockRepository = checkNotNull(jdbcRegistryLockRepository);
9390
this.jdbcRegistryClientRepository = checkNotNull(jdbcRegistryClientRepository);
9491
this.jdbcRegistryProperties = checkNotNull(jdbcRegistryProperties);

0 commit comments

Comments
 (0)