Skip to content

Commit 52220c8

Browse files
authored
[Chore] Skip maven-dependency-plugin in ci (#17223)
1 parent 7266e3f commit 52220c8

6 files changed

Lines changed: 33 additions & 23 deletions

File tree

.github/workflows/api-test.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,9 @@ jobs:
8282
./mvnw -B clean install \
8383
-Dmaven.test.skip=true \
8484
-Dspotless.skip=true \
85-
-Pdocker,staging -Ddocker.tag=ci
85+
-Pdocker,staging \
86+
-Ddocker.tag=ci \
87+
-Danalyze.skip=true
8688
- name: Export Docker Images
8789
run: |
8890
docker save apache/dolphinscheduler-standalone-server:ci -o /tmp/standalone-image.tar \

.github/workflows/backend.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ jobs:
9191
./mvnw -B clean install \
9292
-Pstaging \
9393
-Dmaven.test.skip=true \
94-
-Dspotless.skip=true
94+
-Dspotless.skip=true \
95+
-Danalyze.skip=true
9596
- name: Check dependency license
9697
run: tools/dependencies/check-LICENSE.sh
9798
- uses: actions/upload-artifact@v4

.github/workflows/e2e-k8s.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,9 @@ jobs:
7272
./mvnw -B clean package \
7373
-Dmaven.test.skip=true \
7474
-Dspotless.skip=true \
75-
-Pdocker,staging -Ddocker.tag=ci
75+
-Pdocker,staging \
76+
-Ddocker.tag=ci \
77+
-Danalyze.skip=true
7678
- name: Create k8s Kind Cluster
7779
run: |
7880
# install kubectl

.github/workflows/e2e.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,9 @@ jobs:
8484
./mvnw -B clean install \
8585
-Dmaven.test.skip=true \
8686
-Dspotless.skip=true \
87-
-Pdocker,staging -Ddocker.tag=ci
87+
-Pdocker,staging \
88+
-Ddocker.tag=ci \
89+
-Danalyze.skip=true
8890
- name: Export Docker Images
8991
run: |
9092
docker save apache/dolphinscheduler-standalone-server:ci -o /tmp/standalone-image.tar \

.github/workflows/unit-test.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ jobs:
8181
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}-backend
8282
restore-keys: ${{ runner.os }}-maven-
8383
- name: Run Unit tests
84-
run: ./mvnw clean verify -B -Dmaven.test.skip=false -Dspotless.skip=true -DskipUT=false
84+
run: ./mvnw clean verify -B -Dmaven.test.skip=false -Dspotless.skip=true -DskipUT=false -Danalyze.skip=true
8585
- name: Upload coverage report to codecov
8686
run: CODECOV_TOKEN="09c2663f-b091-4258-8a47-c981827eb29a" bash <(curl -s https://codecov.io/bash)
8787

@@ -108,6 +108,7 @@ jobs:
108108
-Dmaven.wagon.http.pool=false
109109
-Dmaven.wagon.httpconnectionManager.ttlSeconds=120
110110
-DskipUT=true
111+
-Danalyze.skip=true
111112
env:
112113
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
113114
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

pom.xml

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@
100100
<build.assembly.skip>true</build.assembly.skip>
101101
<spotless.skip>false</spotless.skip>
102102
<maven.deploy.skip>true</maven.deploy.skip>
103+
<analyze.skip>false</analyze.skip>
103104

104105
<skipUT>false</skipUT>
105106
</properties>
@@ -492,6 +493,25 @@
492493
<groupId>org.apache.maven.plugins</groupId>
493494
<artifactId>maven-dependency-plugin</artifactId>
494495
<version>${maven-dependency-plugin.version}</version>
496+
<executions>
497+
<execution>
498+
<id>analyze-dependencies</id>
499+
<goals>
500+
<goal>analyze-only</goal>
501+
</goals>
502+
<configuration>
503+
<skip>${analyze.skip}</skip>
504+
<ignoredDependencies>
505+
<!-- Because of SpringBoot auto-configurations, the configuration is happening outside of your application code, so Maven believes these dependencies to be unused -->
506+
<!-- Static code analysis tools like (maven-dependency-plugin) can not detect runtime dependencies, so you should instruct them about runtime dependencies -->
507+
<!-- https://stackoverflow.com/questions/37528928/spring-boot-core-dependencies-seen-as-unused-by-maven-dependency-plugin -->
508+
<ignoredDependency>org.springframework*:*</ignoredDependency>
509+
<ignoredDependency>org.apache.dolphinscheduler:dolphinscheduler-meter</ignoredDependency>
510+
</ignoredDependencies>
511+
<ignoreNonCompile>true</ignoreNonCompile>
512+
</configuration>
513+
</execution>
514+
</executions>
495515
</plugin>
496516
<plugin>
497517
<groupId>org.apache.maven.plugins</groupId>
@@ -783,24 +803,6 @@
783803
<groupId>org.apache.maven.plugins</groupId>
784804
<artifactId>maven-dependency-plugin</artifactId>
785805
<version>${maven-dependency-plugin.version}</version>
786-
<executions>
787-
<execution>
788-
<id>analyze-dependencies</id>
789-
<goals>
790-
<goal>analyze-only</goal>
791-
</goals>
792-
<configuration>
793-
<ignoredDependencies>
794-
<!-- Because of SpringBoot auto-configurations, the configuration is happening outside of your application code, so Maven believes these dependencies to be unused -->
795-
<!-- Static code analysis tools like (maven-dependency-plugin) can not detect runtime dependencies, so you should instruct them about runtime dependencies -->
796-
<!-- https://stackoverflow.com/questions/37528928/spring-boot-core-dependencies-seen-as-unused-by-maven-dependency-plugin -->
797-
<ignoredDependency>org.springframework*:*</ignoredDependency>
798-
<ignoredDependency>org.apache.dolphinscheduler:dolphinscheduler-meter</ignoredDependency>
799-
</ignoredDependencies>
800-
<ignoreNonCompile>true</ignoreNonCompile>
801-
</configuration>
802-
</execution>
803-
</executions>
804806
</plugin>
805807
</plugins>
806808
</build>

0 commit comments

Comments
 (0)