Skip to content

Commit 373d9d6

Browse files
authored
[Improvement-18056] Clean up unused methods and classes in the dolphinschudler-dao-plugin module (#18156)
1 parent 25f7429 commit 373d9d6

4 files changed

Lines changed: 0 additions & 27 deletions

File tree

  • dolphinscheduler-dao-plugin
    • dolphinscheduler-dao-api/src/main/java/org/apache/dolphinscheduler/dao/plugin/api/dialect
    • dolphinscheduler-dao-h2/src/main/java/org/apache/dolphinscheduler/dao/plugin/h2/dialect
    • dolphinscheduler-dao-mysql/src/main/java/org/apache/dolphinscheduler/dao/plugin/mysql/dialect
    • dolphinscheduler-dao-postgresql/src/main/java/org/apache/dolphinscheduler/dao/plugin/postgresql/dialect

dolphinscheduler-dao-plugin/dolphinscheduler-dao-api/src/main/java/org/apache/dolphinscheduler/dao/plugin/api/dialect/DatabaseDialect.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,4 @@ public interface DatabaseDialect {
2121

2222
boolean tableExists(String tableName);
2323

24-
boolean columnExists(String tableName, String columnName);
25-
2624
}

dolphinscheduler-dao-plugin/dolphinscheduler-dao-h2/src/main/java/org/apache/dolphinscheduler/dao/plugin/h2/dialect/H2Dialect.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,4 @@ public boolean tableExists(String tableName) {
2626
throw new UnsupportedOperationException();
2727
}
2828

29-
@Override
30-
public boolean columnExists(String tableName, String columnName) {
31-
throw new UnsupportedOperationException();
32-
}
3329
}

dolphinscheduler-dao-plugin/dolphinscheduler-dao-mysql/src/main/java/org/apache/dolphinscheduler/dao/plugin/mysql/dialect/MysqlDialect.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,4 @@ public boolean tableExists(String tableName) {
4444
}
4545
}
4646

47-
@SneakyThrows
48-
@Override
49-
public boolean columnExists(String tableName, String columnName) {
50-
try (
51-
Connection conn = dataSource.getConnection();
52-
ResultSet rs =
53-
conn.getMetaData().getColumns(conn.getCatalog(), conn.getSchema(), tableName, columnName)) {
54-
return rs.next();
55-
56-
}
57-
}
5847
}

dolphinscheduler-dao-plugin/dolphinscheduler-dao-postgresql/src/main/java/org/apache/dolphinscheduler/dao/plugin/postgresql/dialect/PostgresqlDialect.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,6 @@ public boolean tableExists(String tableName) {
4646
}
4747
}
4848

49-
@SneakyThrows
50-
@Override
51-
public boolean columnExists(String tableName, String columnName) {
52-
try (
53-
Connection conn = dataSource.getConnection();
54-
ResultSet rs = conn.getMetaData().getTables(conn.getCatalog(), getSchema(), tableName, null)) {
55-
return rs.next();
56-
}
57-
}
58-
5949
private String getSchema() throws SQLException {
6050
try (
6151
Connection conn = dataSource.getConnection();

0 commit comments

Comments
 (0)