[Improvement-18039][Metrics] Refactor workflow state metrics and fix missing imports

This commit addresses feedback regarding missing variables and symbols in the workflow metrics implementation.

- Added the missing WorkflowInstanceMetrics import in AbstractWorkflowStateAction.
- Refactored the workflow state-to-tag mapping into WorkflowInstanceMetrics for better encapsulation. This ensures the correct lowercase tags (e.g., 'submit', 'fail') are consistently used.
- Removed unused task dispatch metrics in TaskMetrics to improve code maintainability.
- Applied project formatting standards using spotless.

Author: sanjana2505006

dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/statemachine/AbstractWorkflowStateAction.java

@@ -36,6 +36,7 @@
 import org.apache.dolphinscheduler.server.master.engine.workflow.lifecycle.event.WorkflowTopologyLogicalTransitionWithTaskFinishLifecycleEvent;
 import org.apache.dolphinscheduler.server.master.engine.workflow.policy.IWorkflowFailureStrategy;
 import org.apache.dolphinscheduler.server.master.engine.workflow.runnable.IWorkflowExecutionRunnable;
+import org.apache.dolphinscheduler.server.master.metrics.WorkflowInstanceMetrics;
 import org.apache.dolphinscheduler.server.master.utils.WorkflowInstanceUtils;
 import org.apache.dolphinscheduler.service.alert.WorkflowAlertManager;
 
@@ -173,7 +174,7 @@ protected void transformWorkflowInstanceState(final IWorkflowExecutionRunnable w
             log.info("Success set WorkflowExecuteRunnable: {} state from: {} to {}",
                     workflowInstance.getName(), originState.name(), targetState.name());
             WorkflowInstanceMetrics.incWorkflowInstanceByStateAndWorkflowDefinitionCode(
-                    targetState.name(),
+                    targetState,
                     String.valueOf(workflowInstance.getWorkflowDefinitionCode()));
         } catch (Exception ex) {
             workflowInstance.setState(originState);

dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/metrics/TaskMetrics.java

@@ -50,39 +50,12 @@ public class TaskMetrics {
 
     }
 
-    private final Counter taskDispatchCounter =
-            Counter.builder("ds.task.dispatch.count")
-                    .description("Task dispatch count")
-                    .register(Metrics.globalRegistry);
-
-    private final Counter taskDispatchFailCounter =
-            Counter.builder("ds.task.dispatch.failure.count")
-                    .description("Task dispatch failures count, retried ones included")
-                    .register(Metrics.globalRegistry);
-
-    private final Counter taskDispatchErrorCounter =
-            Counter.builder("ds.task.dispatch.error.count")
-                    .description("Number of errors during task dispatch")
-                    .register(Metrics.globalRegistry);
-
     public synchronized void registerTaskPrepared(Supplier<Number> consumer) {
         Gauge.builder("ds.task.prepared", consumer)
                 .description("Task prepared count")
                 .register(Metrics.globalRegistry);
     }
 
-    public void incTaskDispatchFailed(int failedCount) {
-        taskDispatchFailCounter.increment(failedCount);
-    }
-
-    public void incTaskDispatchError() {
-        taskDispatchErrorCounter.increment();
-    }
-
-    public void incTaskDispatch() {
-        taskDispatchCounter.increment();
-    }
-
     public void incTaskInstanceByState(final String state) {
         if (taskInstanceCounters.get(state) == null) {
             return;

dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/metrics/WorkflowInstanceMetrics.java

@@ -17,6 +17,8 @@
 
 package org.apache.dolphinscheduler.server.master.metrics;
 
+import org.apache.dolphinscheduler.common.enums.WorkflowExecutionStatus;
+
 import java.util.Set;
 import java.util.concurrent.TimeUnit;
 import java.util.function.Supplier;
@@ -36,7 +38,7 @@
 public class WorkflowInstanceMetrics {
 
     private final Set<String> workflowInstanceStates = ImmutableSet.of(
-            "submit", "timeout", "finish", "failover", "success", "fail", "stop");
+            "submit", "timeout", "finish", "failover", "success", "fail", "stop", "pause");
 
     static {
         for (final String state : workflowInstanceStates) {
@@ -78,18 +80,34 @@ public synchronized void registerWorkflowInstanceResubmitGauge(Supplier<Number>
                 .register(Metrics.globalRegistry);
     }
 
-    public void incWorkflowInstanceByStateAndWorkflowDefinitionCode(final String state,
-                                                                    final String workflowDefinitionCode) {
-        // When tags need to be determined from local context,
-        // you have no choice but to construct or lookup the Meter inside your method body.
-        // The lookup cost is just a single hash lookup, so it is acceptable for most use cases.
+    public void incWorkflowInstanceByStateAndWorkflowDefinitionCode(WorkflowExecutionStatus state,
+                                                                    String workflowDefinitionCode) {
         Metrics.globalRegistry.counter(
                 "ds.workflow.instance.count",
-                "state", state,
+                "state", getMetricState(state),
                 "workflow.definition.code", workflowDefinitionCode)
                 .increment();
     }
 
+    private String getMetricState(WorkflowExecutionStatus state) {
+        switch (state) {
+            case SUBMITTED_SUCCESS:
+                return "submit";
+            case FAILURE:
+                return "fail";
+            case SUCCESS:
+                return "success";
+            case STOP:
+                return "stop";
+            case PAUSE:
+                return "pause";
+            case FAILOVER:
+                return "failover";
+            default:
+                return state.name().toLowerCase();
+        }
+    }
+
     public void cleanUpWorkflowInstanceCountMetricsByDefinitionCode(final Long workflowDefinitionCode) {
         for (final String state : workflowInstanceStates) {
             final Counter counter = Metrics.globalRegistry.counter(